docs(ivy): add Ivy as a recognized label (#21428)

PR Close #21428
This commit is contained in:
Miško Hevery 2018-01-09 13:46:19 -08:00 committed by Alex Eagle
parent 92984ba794
commit a33ff2c68f
6 changed files with 20 additions and 9 deletions

View File

@ -62,7 +62,7 @@ jobs:
# Use bazel query so that we explicitly ask for all buildable targets to be built as well # Use bazel query so that we explicitly ask for all buildable targets to be built as well
# This avoids waiting for a build command to finish before running the first test # This avoids waiting for a build command to finish before running the first test
# See https://github.com/bazelbuild/bazel/issues/4257 # See https://github.com/bazelbuild/bazel/issues/4257
- run: bazel query --output=label '//modules/... union //packages/... union @angular//...' | xargs bazel test --config=ci - run: bazel query --output=label '//modules/... union //packages/... union //tools/... union @angular//...' | xargs bazel test --config=ci
- save_cache: - save_cache:
key: *cache_key key: *cache_key

View File

@ -20,6 +20,7 @@ The components have a clear piece of source code associated with it within the `
* `comp: common/http` - this includes core components / pipes * `comp: common/http` - this includes core components / pipes
* `comp: core & compiler` - because core, compiler, compiler-cli and * `comp: core & compiler` - because core, compiler, compiler-cli and
browser-platforms are very intertwined, we will be treating them as one browser-platforms are very intertwined, we will be treating them as one
* `comp: ivy` - a subset of core representing the new Ivy renderer.
* `comp: forms` * `comp: forms`
* `comp: http` * `comp: http`
* `comp: i18n` * `comp: i18n`

View File

@ -0,0 +1,6 @@
load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
jasmine_node_test(
name = "validate-commit-message",
srcs = glob(["*.js"]),
)

View File

@ -23,6 +23,7 @@
"core", "core",
"forms", "forms",
"http", "http",
"ivy",
"language-service", "language-service",
"platform-browser", "platform-browser",
"platform-browser-dynamic", "platform-browser-dynamic",

View File

@ -58,3 +58,5 @@ module.exports = function(commitSubject) {
function error(errorMessage, commitMessage) { function error(errorMessage, commitMessage) {
console.error(`INVALID COMMIT MSG: "${commitMessage}"\n => ERROR: ${errorMessage}`); console.error(`INVALID COMMIT MSG: "${commitMessage}"\n => ERROR: ${errorMessage}`);
} }
module.exports.config = config;

View File

@ -8,6 +8,7 @@
describe('validate-commit-message.js', function() { describe('validate-commit-message.js', function() {
var validateMessage = require('./validate-commit-message'); var validateMessage = require('./validate-commit-message');
var SCOPES = validateMessage.config.scopes.join(', ');
var errors = []; var errors = [];
var logs = []; var logs = [];
@ -51,22 +52,22 @@ describe('validate-commit-message.js', function() {
expect(validateMessage('refactor(docs): something')).toBe(INVALID); expect(validateMessage('refactor(docs): something')).toBe(INVALID);
['INVALID COMMIT MSG: "fix(Compiler): something"\n' + ['INVALID COMMIT MSG: "fix(Compiler): something"\n' +
' => ERROR: "Compiler" is not an allowed scope.\n' + ' => ERROR: "Compiler" is not an allowed scope.\n' +
' => SCOPES: aio, animations, bazel, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, service-worker, upgrade, packaging, changelog', ' => SCOPES: ' + SCOPES,
'INVALID COMMIT MSG: "feat(bah): something"\n' + 'INVALID COMMIT MSG: "feat(bah): something"\n' +
' => ERROR: "bah" is not an allowed scope.\n' + ' => ERROR: "bah" is not an allowed scope.\n' +
' => SCOPES: aio, animations, bazel, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, service-worker, upgrade, packaging, changelog', ' => SCOPES: ' + SCOPES,
'INVALID COMMIT MSG: "style(webworker): something"\n' + 'INVALID COMMIT MSG: "style(webworker): something"\n' +
' => ERROR: "webworker" is not an allowed scope.\n' + ' => ERROR: "webworker" is not an allowed scope.\n' +
' => SCOPES: aio, animations, bazel, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, service-worker, upgrade, packaging, changelog', ' => SCOPES: ' + SCOPES,
'INVALID COMMIT MSG: "refactor(security): something"\n' + 'INVALID COMMIT MSG: "refactor(security): something"\n' +
' => ERROR: "security" is not an allowed scope.\n' + ' => ERROR: "security" is not an allowed scope.\n' +
' => SCOPES: aio, animations, bazel, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, service-worker, upgrade, packaging, changelog', ' => SCOPES: ' + SCOPES,
'INVALID COMMIT MSG: "refactor(docs): something"\n' + 'INVALID COMMIT MSG: "refactor(docs): something"\n' +
' => ERROR: "docs" is not an allowed scope.\n' + ' => ERROR: "docs" is not an allowed scope.\n' +
' => SCOPES: aio, animations, bazel, benchpress, common, compiler, compiler-cli, core, forms, http, language-service, platform-browser, platform-browser-dynamic, platform-server, platform-webworker, platform-webworker-dynamic, router, service-worker, upgrade, packaging, changelog'] ' => SCOPES: ' + SCOPES,
.forEach((expectedErrorMessage, index) => { ].forEach((expectedErrorMessage, index) => {
expect(expectedErrorMessage).toEqual(errors[index]); expect(expectedErrorMessage).toEqual(errors[index]);
}); });
expect(validateMessage('release(angular): something')).toBe(INVALID); expect(validateMessage('release(angular): something')).toBe(INVALID);
}); });