ci: special case tooling-cli-shared-api review group (#37467)
The new tooling-cli-shared-api is used to guard changes to packages/compiler-cli/src/tooling.ts which is a private API sharing channel between Angular FW and CLI. Changes to this file should be rare and explicitly approved by at least two members of the CLI team. PR Close #37467
This commit is contained in:
parent
5568d824dd
commit
aaa20093b2
|
@ -843,6 +843,32 @@ groups:
|
|||
- jelbourn
|
||||
|
||||
|
||||
# =========================================================
|
||||
# Tooling: Compiler API shared with Angular CLI
|
||||
#
|
||||
# Changing this API might break Angular CLI, so we require
|
||||
# the CLI team to approve changes here.
|
||||
# =========================================================
|
||||
tooling-cli-shared-api:
|
||||
conditions:
|
||||
- *can-be-global-approved
|
||||
- *can-be-global-docs-approved
|
||||
- >
|
||||
contains_any_globs(files, [
|
||||
'packages/compiler-cli/src/tooling.ts'
|
||||
])
|
||||
reviewers:
|
||||
users:
|
||||
- alan-agius4
|
||||
- clydin
|
||||
- kyliau
|
||||
- IgorMinar
|
||||
reviews:
|
||||
request: -1 # request reviews from everyone
|
||||
required: 2 # require at least 2 approvals
|
||||
reviewed_for: required
|
||||
|
||||
|
||||
# =========================================================
|
||||
# Docs: CLI
|
||||
# =========================================================
|
||||
|
|
|
@ -7,11 +7,14 @@
|
|||
*/
|
||||
|
||||
/**
|
||||
* @module
|
||||
* @description
|
||||
* Tooling support helpers.
|
||||
* @fileoverview
|
||||
* This file is used as a private API channel to shared Angular FW APIs with @angular/cli.
|
||||
*
|
||||
* Any changes to this file should be discussed with the Angular CLI team.
|
||||
*/
|
||||
|
||||
|
||||
|
||||
/**
|
||||
* Known values for global variables in `@angular/core` that Terser should set using
|
||||
* https://github.com/terser-js/terser#conditional-compilation
|
||||
|
|
Loading…
Reference in New Issue