fix(core): `Attribute` decorator `attributeName` is mandatory (#38131)

`Attribute` decorator has defined `attributeName` as optional but actually its
 mandatory and compiler throws an error if `attributeName` is undefined. Made
`attributeName` mandatory in the `Attribute` decorator to reflect this functionality

Fixes #32658

PR Close #38131

goldens/public-api/core/core.d.ts

@@ -53,7 +53,7 @@ export declare function asNativeElements(debugEls: DebugElement[]): any;
 export declare function assertPlatform(requiredToken: any): PlatformRef;
 
 export declare interface Attribute {
-    attributeName?: string;
+    attributeName: string;
 }
 
 export declare const Attribute: AttributeDecorator;

packages/compiler/src/core.ts

@@ -22,10 +22,10 @@ export const createInjectionToken = makeMetadataFactory<object>(
     'InjectionToken', (desc: string) => ({_desc: desc, ɵprov: undefined}));
 
 export interface Attribute {
-  attributeName?: string;
+  attributeName: string;
 }
 export const createAttribute =
-    makeMetadataFactory<Attribute>('Attribute', (attributeName?: string) => ({attributeName}));
+    makeMetadataFactory<Attribute>('Attribute', (attributeName: string) => ({attributeName}));
 
 export interface Query {
   descendants: boolean;

packages/core/src/di/metadata.ts

@@ -271,7 +271,7 @@ export interface Attribute {
   /**
    * The name of the attribute whose value can be injected.
    */
-  attributeName?: string;
+  attributeName: string;
 }
 
 /**