build(bazel): update to latest stable chromium 74 on osx and linux for karma under bazel (#30502)
We were on 69 for both of these platforms which is fairly old. This update also requires a temporary patch to the @bazel/karma npm package to disable chrome sandboxing on OSX as it is broken under Bazel as of chromium 73. Windows is still on Chromium 66 but updating this will require upstream changes to rules_webtesting as the archive name & executable name has changed as of 72 for Windows and hard-coded paths in rules_webtesting break things. PR Close #30502
This commit is contained in:
Greg Magolan
Jason Aden
parent
73e3f565e0
commit
b4014e9a39
|
|
@ -96,7 +96,7 @@ web_test_repositories()
|
||||||
|
|
||||||
# Temporary work-around for https://github.com/angular/angular/issues/28681
|
# Temporary work-around for https://github.com/angular/angular/issues/28681
|
||||||
# TODO(gregmagolan): go back to @io_bazel_rules_webtesting browser_repositories
|
# TODO(gregmagolan): go back to @io_bazel_rules_webtesting browser_repositories
|
||||||
load("@npm_bazel_karma//:browser_repositories.bzl", "browser_repositories")
|
load("//:browser_repositories.bzl", "browser_repositories")
|
||||||
|
|
||||||
browser_repositories()
|
browser_repositories()
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,114 @@
|
||||||
|
# Copyright 2018 The Bazel Authors. All rights reserved.
|
||||||
|
#
|
||||||
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
# you may not use this file except in compliance with the License.
|
||||||
|
# You may obtain a copy of the License at
|
||||||
|
#
|
||||||
|
# http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
#
|
||||||
|
# Unless required by applicable law or agreed to in writing, software
|
||||||
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
# See the License for the specific language governing permissions and
|
||||||
|
# limitations under the License.
|
||||||
|
|
||||||
|
"""Pinned browser versions for karma testing
|
||||||
|
"""
|
||||||
|
|
||||||
|
load("@io_bazel_rules_webtesting//web/internal:platform_http_file.bzl", "platform_http_file")
|
||||||
|
|
||||||
|
def browser_repositories():
|
||||||
|
"""Load pinned rules_webtesting browser versions."""
|
||||||
|
|
||||||
|
platform_http_file(
|
||||||
|
name = "org_chromium_chromium",
|
||||||
|
amd64_sha256 =
|
||||||
|
"eb6754c7918da5eab42a42bbda7efdf7f1661eaa3802b8940841f0c2c312299f",
|
||||||
|
amd64_urls = [
|
||||||
|
# Chromium 74.0.3729.0 (2019-03-08 snaphot 638880)
|
||||||
|
# https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/638880/
|
||||||
|
# Current linux stable as of 2019-05-15
|
||||||
|
# https://www.chromium.org/developers/calendar
|
||||||
|
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/638880/chrome-linux.zip",
|
||||||
|
],
|
||||||
|
licenses = ["notice"], # BSD 3-clause (maybe more?)
|
||||||
|
macos_sha256 =
|
||||||
|
"c48bdffac6a91c85c17a848012b1a45fbf36e3a2d4aaac5b6ded8ac65b1d96e3",
|
||||||
|
macos_urls = [
|
||||||
|
# Chromium 74.0.3729.0 (2019-03-08 snaphot 638880)
|
||||||
|
# https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/638880/
|
||||||
|
# Current mac stable as of 2019-05-15
|
||||||
|
# https://www.chromium.org/developers/calendar
|
||||||
|
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/638880/chrome-mac.zip",
|
||||||
|
],
|
||||||
|
windows_sha256 =
|
||||||
|
"d1bb728118c12ea436d8ea07dba980789e7d860aa664dd1fad78bc20e8d9391c",
|
||||||
|
windows_urls = [
|
||||||
|
# Chromium 66.0.3359.0 (2018-03-01 snaphot 540270)
|
||||||
|
# https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/612439/
|
||||||
|
# NOTE: There is an issue with chromium 68-71 with Windows: https://bugs.chromium.org/p/chromium/issues/detail?id=540270
|
||||||
|
# and pinning to 72 is not possible as the archive name has changed to chrome-win.zip which breaks
|
||||||
|
# as the executable path the hard-coded in rules_webtesting and includes the archive name.
|
||||||
|
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Win_x64/540270/chrome-win32.zip",
|
||||||
|
],
|
||||||
|
)
|
||||||
|
|
||||||
|
platform_http_file(
|
||||||
|
name = "org_chromium_chromedriver",
|
||||||
|
amd64_sha256 =
|
||||||
|
"ec9dbe021338f0befaecca702abc576cb7cc31a2f5a852c2c41e94721af5d3ad",
|
||||||
|
amd64_urls = [
|
||||||
|
# ChromeDriver 74.0.3729.6 supports Chrome 74
|
||||||
|
# http://chromedriver.chromium.org/downloads
|
||||||
|
"https://chromedriver.storage.googleapis.com/74.0.3729.6/chromedriver_linux64.zip",
|
||||||
|
],
|
||||||
|
licenses = ["reciprocal"], # BSD 3-clause, ICU, MPL 1.1, libpng (BSD/MIT-like), Academic Free License v. 2.0, BSD 2-clause, MIT
|
||||||
|
macos_sha256 =
|
||||||
|
"b4b73681404d231d81a9b7ab9d4f0cb090f3e69240296eca2eb46e2629519152",
|
||||||
|
macos_urls = [
|
||||||
|
# ChromeDriver 74.0.3729.6 supports Chrome 74
|
||||||
|
# http://chromedriver.chromium.org/downloads
|
||||||
|
"https://chromedriver.storage.googleapis.com/74.0.3729.6/chromedriver_mac64.zip",
|
||||||
|
],
|
||||||
|
windows_sha256 =
|
||||||
|
"a8fa028acebef7b931ef9cb093f02865f9f7495e49351f556e919f7be77f072e",
|
||||||
|
windows_urls = [
|
||||||
|
# ChromeDriver 2.38 supports Chrome v65-67
|
||||||
|
# http://chromedriver.chromium.org/downloads
|
||||||
|
"https://chromedriver.storage.googleapis.com/2.38/chromedriver_win32.zip",
|
||||||
|
],
|
||||||
|
)
|
||||||
|
|
||||||
|
platform_http_file(
|
||||||
|
name = "org_mozilla_firefox",
|
||||||
|
amd64_sha256 =
|
||||||
|
"3a729ddcb1e0f5d63933177a35177ac6172f12edbf9fbbbf45305f49333608de",
|
||||||
|
amd64_urls = [
|
||||||
|
"https://mirror.bazel.build/ftp.mozilla.org/pub/firefox/releases/61.0.2/linux-x86_64/en-US/firefox-61.0.2.tar.bz2",
|
||||||
|
"https://ftp.mozilla.org/pub/firefox/releases/61.0.2/linux-x86_64/en-US/firefox-61.0.2.tar.bz2",
|
||||||
|
],
|
||||||
|
licenses = ["reciprocal"], # MPL 2.0
|
||||||
|
macos_sha256 =
|
||||||
|
"bf23f659ae34832605dd0576affcca060d1077b7bf7395bc9874f62b84936dc5",
|
||||||
|
macos_urls = [
|
||||||
|
"https://mirror.bazel.build/ftp.mozilla.org/pub/firefox/releases/61.0.2/mac/en-US/Firefox%2061.0.2.dmg",
|
||||||
|
"https://ftp.mozilla.org/pub/firefox/releases/61.0.2/mac/en-US/Firefox%2061.0.2.dmg",
|
||||||
|
],
|
||||||
|
)
|
||||||
|
|
||||||
|
platform_http_file(
|
||||||
|
name = "org_mozilla_geckodriver",
|
||||||
|
amd64_sha256 =
|
||||||
|
"c9ae92348cf00aa719be6337a608fae8304691a95668e8e338d92623ba9e0ec6",
|
||||||
|
amd64_urls = [
|
||||||
|
"https://mirror.bazel.build/github.com/mozilla/geckodriver/releases/download/v0.21.0/geckodriver-v0.21.0-linux64.tar.gz",
|
||||||
|
"https://github.com/mozilla/geckodriver/releases/download/v0.21.0/geckodriver-v0.21.0-linux64.tar.gz",
|
||||||
|
],
|
||||||
|
licenses = ["reciprocal"], # MPL 2.0
|
||||||
|
macos_sha256 =
|
||||||
|
"ce4a3e9d706db94e8760988de1ad562630412fa8cf898819572522be584f01ce",
|
||||||
|
macos_urls = [
|
||||||
|
"https://mirror.bazel.build/github.com/mozilla/geckodriver/releases/download/v0.21.0/geckodriver-v0.21.0-macos.tar.gz",
|
||||||
|
"https://github.com/mozilla/geckodriver/releases/download/v0.21.0/geckodriver-v0.21.0-macos.tar.gz",
|
||||||
|
],
|
||||||
|
)
|
||||||
|
|
@ -27,21 +27,28 @@ const log = console.log;
|
||||||
// COMMENTED OUT BECAUSE WE CURRENTLY REQUIRE NO PATCHES
|
// COMMENTED OUT BECAUSE WE CURRENTLY REQUIRE NO PATCHES
|
||||||
// UNCOMMENT TO REENABLE PATCHING AND LOG OUTPUT
|
// UNCOMMENT TO REENABLE PATCHING AND LOG OUTPUT
|
||||||
//
|
//
|
||||||
// log('===== about to run the postinstall-patches.js script =====');
|
log('===== about to run the postinstall-patches.js script =====');
|
||||||
// // fail on first error
|
// fail on first error
|
||||||
// set('-e');
|
set('-e');
|
||||||
// // print commands as being executed
|
// print commands as being executed
|
||||||
// set('-v');
|
set('-v');
|
||||||
// // jump to project root
|
// jump to project root
|
||||||
// cd(path.join(__dirname, '../'));
|
cd(path.join(__dirname, '../'));
|
||||||
|
|
||||||
// /* EXAMPLE PATCH:
|
/* EXAMPLE PATCH:
|
||||||
// // https://github.com/ReactiveX/rxjs/pull/3302
|
// https://github.com/ReactiveX/rxjs/pull/3302
|
||||||
// // make node_modules/rxjs compilable with Typescript 2.7
|
// make node_modules/rxjs compilable with Typescript 2.7
|
||||||
// // remove when we update to rxjs v6
|
// remove when we update to rxjs v6
|
||||||
// log('\n# patch: reactivex/rxjs#3302 make node_modules/rxjs compilable with Typescript 2.7');
|
log('\n# patch: reactivex/rxjs#3302 make node_modules/rxjs compilable with Typescript 2.7');
|
||||||
// sed('-i', '(\'response\' in xhr)', '(\'response\' in (xhr as any))',
|
sed('-i', '(\'response\' in xhr)', '(\'response\' in (xhr as any))',
|
||||||
// 'node_modules/rxjs/src/observable/dom/AjaxObservable.ts');
|
'node_modules/rxjs/src/observable/dom/AjaxObservable.ts');
|
||||||
// */
|
*/
|
||||||
|
|
||||||
// log('===== finished running the postinstall-patches.js script =====');
|
// make chrome 74 work on OSX with karma under bazel
|
||||||
|
// remove when we update to the next @bazel/karma release
|
||||||
|
log('\n# patch: @bazel/karma 0.29.0 to disable chrome sandbox for OSX');
|
||||||
|
sed('-i', 'process.platform !== \'linux\'',
|
||||||
|
'process.platform !== \'linux\' && process.platform !== \'darwin\'',
|
||||||
|
'node_modules/@bazel/karma/karma.conf.js');
|
||||||
|
|
||||||
|
log('===== finished running the postinstall-patches.js script =====');
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue