From b9854e582f0e0ef015b9b262e0804720af1bb5dc Mon Sep 17 00:00:00 2001 From: Daniel Ruf Date: Thu, 17 Jan 2019 12:34:30 +0100 Subject: [PATCH] refactor: remove unused parameters (#28203) PR Close #28203 --- packages/bazel/src/protractor/protractor.conf.js | 3 +-- tools/gulp-tasks/cldr/util.js | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/bazel/src/protractor/protractor.conf.js b/packages/bazel/src/protractor/protractor.conf.js index e7a3403b27..6388a13ef6 100644 --- a/packages/bazel/src/protractor/protractor.conf.js +++ b/packages/bazel/src/protractor/protractor.conf.js @@ -143,8 +143,7 @@ if (process.env['WEB_TEST_METADATA']) { binary: chromeBin, args: args, } - }, - 'is determined by the browsers attribute'); + }); } if (webTestNamedFiles['FIREFOX']) { // TODO(gmagolan): implement firefox support for protractor diff --git a/tools/gulp-tasks/cldr/util.js b/tools/gulp-tasks/cldr/util.js index 692f051560..ded4d56c35 100644 --- a/tools/gulp-tasks/cldr/util.js +++ b/tools/gulp-tasks/cldr/util.js @@ -146,7 +146,7 @@ module.exports.stringify = function(obj, quoteKeys) { objStack.push(obj_part); for (var prop in obj_part) { if (obj_part.hasOwnProperty(prop)) { - var value = internalStringify(obj_part, prop, false); + var value = internalStringify(obj_part, prop); if (typeof value !== 'undefined' && value !== null) { nonEmpty = true; key = isWord(prop) && !quoteKeys ? prop : escapeString(prop, quoteKeys); @@ -173,7 +173,7 @@ module.exports.stringify = function(obj, quoteKeys) { // but when top-level, return undefined var topLevelHolder = {'': obj}; if (obj === undefined) { - return getReplacedValueOrUndefined(topLevelHolder, '', true); + return getReplacedValueOrUndefined(topLevelHolder, ''); } return internalStringify(topLevelHolder, ''); };