From bafab6de79d9cc7dfda0d06cbf61f02ebf515b63 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Wed, 17 Feb 2021 14:45:19 -0800 Subject: [PATCH] build: update dependencies to enable strict_visibility for bazel yarn_install (#40895) Beginning with rules_nodejs@3.0.0, strict visibility defaults to true. This means that we are no longer, in bazel dependencies, able to depend on a package which was transitively depended on from another dependency we do have in our package.json PR Close #40895 --- WORKSPACE | 3 --- package.json | 3 +++ yarn.lock | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 52384881ab..918c4235f8 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -31,9 +31,6 @@ yarn_install( name = "npm", manual_build_file_contents = npm_package_archives(), package_json = "//:package.json", - # TODO(josephperrott): Correct usage of transitive dependencies to reenable strict_visibility - # See: https://github.com/bazelbuild/rules_nodejs/wiki#strict_visibility-on-yarn_install-and-npm_install-now-defaults-true-2199 - strict_visibility = False, yarn_lock = "//:yarn.lock", ) diff --git a/package.json b/package.json index 1b934363d4..f124df5d1b 100644 --- a/package.json +++ b/package.json @@ -61,6 +61,7 @@ "@microsoft/api-extractor": "7.7.11", "@octokit/rest": "16.28.7", "@octokit/types": "^5.0.1", + "tmp": "0.0.33", "@schematics/angular": "11.0.0-rc.1", "@types/angular": "^1.6.47", "@types/babel__core": "^7.1.6", @@ -78,6 +79,8 @@ "@types/jasmine": "3.5.10", "@types/jasmine-ajax": "^3.3.1", "@types/jasminewd2": "^2.0.8", + "@babel/parser": "^7.0.0", + "@types/events": "3.0.0", "@types/minimist": "^1.2.0", "@types/multimatch": "^4.0.0", "@types/node": "^12.11.1", diff --git a/yarn.lock b/yarn.lock index a18329158a..5b12121fd4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2469,7 +2469,7 @@ resolved "https://registry.yarnpkg.com/@types/estree/-/estree-0.0.39.tgz#e177e699ee1b8c22d23174caaa7422644389509f" integrity sha512-EYNwp3bU+98cpU4lAWYYL7Zz+2gryWH1qbdDTidVd6hkiR6weksdbMadyXKXNPEkQFhXM+hVO9ZygomHXp+AIw== -"@types/events@*": +"@types/events@*", "@types/events@3.0.0": version "3.0.0" resolved "https://registry.yarnpkg.com/@types/events/-/events-3.0.0.tgz#2862f3f58a9a7f7c3e78d79f130dd4d71c25c2a7" integrity sha512-EaObqwIvayI5a8dCzhFrjKzVwKLxjoG9T6Ppd5CEo07LRKfQ8Yokw54r5+Wq7FaBQ+yXRvQAYPrHwya1/UFt9g==