From bd7d8744fa0eb0bf28ae24b8564f4fe593ae2909 Mon Sep 17 00:00:00 2001 From: Andrew Scott Date: Wed, 23 Sep 2020 11:23:28 -0700 Subject: [PATCH] test(core): enable test in compiler compliance for namespace uri (#38957) Enables test that was fixed by #24386. resolves #24426. PR Close #38957 --- .../test/compliance/r3_compiler_compliance_spec.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/compiler-cli/test/compliance/r3_compiler_compliance_spec.ts b/packages/compiler-cli/test/compliance/r3_compiler_compliance_spec.ts index 4042a056da..157b724db0 100644 --- a/packages/compiler-cli/test/compliance/r3_compiler_compliance_spec.ts +++ b/packages/compiler-cli/test/compliance/r3_compiler_compliance_spec.ts @@ -167,9 +167,7 @@ describe('compiler compliance', () => { expectEmit(result.source, template, 'Incorrect template'); }); - // TODO(https://github.com/angular/angular/issues/24426): We need to support the parser actually - // building the proper attributes based off of xmlns attributes. - xit('should support namespaced attributes', () => { + it('should support namespaced attributes', () => { const files = { app: { 'spec.ts': ` @@ -194,7 +192,10 @@ describe('compiler compliance', () => { // The template should look like this (where IDENT is a wild card for an identifier): const template = ` … - consts: [["class", "my-app", 0, "http://someuri/foo", "foo:bar", "baz", "title", "Hello", 0, "http://someuri/foo", "foo:qux", "quacks"]], + consts: [[${AttributeMarker.NamespaceURI}, "xmlns", "foo", "http://someuri/foo", ${ + AttributeMarker.NamespaceURI}, "foo", "bar", "baz", "title", "Hello", ${ + AttributeMarker.NamespaceURI}, "foo", "qux", "quacks", ${ + AttributeMarker.Classes}, "my-app"]], template: function MyComponent_Template(rf, ctx) { if (rf & 1) { $r3$.ɵɵelementStart(0, "div", 0);