fix(typings): fix typings which were previously unchecked

Closes #4625
This commit is contained in:
Alex Eagle 2015-10-08 22:44:58 -07:00 committed by Alex Eagle
parent 597f79e0c7
commit c178ad476e
5 changed files with 10 additions and 8 deletions

View File

@ -108,12 +108,12 @@ export class NgClass implements DoCheck, OnDestroy {
this._initialClasses.forEach(className => this._toggleClass(className, !isCleanup)); this._initialClasses.forEach(className => this._toggleClass(className, !isCleanup));
} }
private _applyClasses(rawClassVal, isCleanup: boolean) { private _applyClasses(rawClassVal: string[] | {[key: string]: string}, isCleanup: boolean) {
if (isPresent(rawClassVal)) { if (isPresent(rawClassVal)) {
if (isListLikeIterable(rawClassVal)) { if (isListLikeIterable(rawClassVal)) {
(<string[]>rawClassVal).forEach(className => this._toggleClass(className, !isCleanup)); (<string[]>rawClassVal).forEach(className => this._toggleClass(className, !isCleanup));
} else { } else {
StringMapWrapper.forEach(rawClassVal, (expVal, className) => { StringMapWrapper.forEach(<{[k: string]: string}>rawClassVal, (expVal, className) => {
if (expVal) this._toggleClass(className, !isCleanup); if (expVal) this._toggleClass(className, !isCleanup);
}); });
} }

View File

@ -212,13 +212,15 @@ function _createProtoQueryRefs(bindings: BindingWithVisibility[]): ProtoQueryRef
var res = []; var res = [];
ListWrapper.forEachWithIndex(bindings, (b, i) => { ListWrapper.forEachWithIndex(bindings, (b, i) => {
if (b.binding instanceof DirectiveBinding) { if (b.binding instanceof DirectiveBinding) {
var directiveBinding = <DirectiveBinding>b.binding;
// field queries // field queries
var queries: QueryMetadataWithSetter[] = b.binding.queries; var queries: QueryMetadataWithSetter[] = directiveBinding.queries;
queries.forEach(q => res.push(new ProtoQueryRef(i, q.setter, q.metadata))); queries.forEach(q => res.push(new ProtoQueryRef(i, q.setter, q.metadata)));
// queries passed into the constructor. // queries passed into the constructor.
// TODO: remove this after constructor queries are no longer supported // TODO: remove this after constructor queries are no longer supported
var deps: DirectiveDependency[] = b.binding.resolvedFactories[0].dependencies; var deps: DirectiveDependency[] =
<DirectiveDependency[]>directiveBinding.resolvedFactory.dependencies;
deps.forEach(d => { deps.forEach(d => {
if (isPresent(d.queryDecorator)) res.push(new ProtoQueryRef(i, null, d.queryDecorator)); if (isPresent(d.queryDecorator)) res.push(new ProtoQueryRef(i, null, d.queryDecorator));
}); });

View File

@ -42,7 +42,7 @@ export class MultiMetric extends Metric {
} }
} }
function mergeStringMaps(maps: any[]): Object { function mergeStringMaps(maps: { [key: string]: string }[]): Object {
var result = {}; var result = {};
maps.forEach( maps.forEach(
map => { StringMapWrapper.forEach(map, (value, prop) => { result[prop] = value; }); }); map => { StringMapWrapper.forEach(map, (value, prop) => { result[prop] = value; }); });

View File

@ -142,7 +142,7 @@ export class PerflogMetric extends Metric {
}); });
} }
_addEvents(events: any[]) { _addEvents(events: { [key: string]: string }[]) {
var needSort = false; var needSort = false;
events.forEach(event => { events.forEach(event => {
if (StringWrapper.equals(event['ph'], 'X')) { if (StringWrapper.equals(event['ph'], 'X')) {

View File

@ -5,14 +5,14 @@ export class Statistic {
return Statistic.calculateStandardDeviation(sample, mean) / mean * 100; return Statistic.calculateStandardDeviation(sample, mean) / mean * 100;
} }
static calculateMean(samples: any[]) { static calculateMean(samples: number[]) {
var total = 0; var total = 0;
// TODO: use reduce // TODO: use reduce
samples.forEach(x => total += x); samples.forEach(x => total += x);
return total / samples.length; return total / samples.length;
} }
static calculateStandardDeviation(samples: any[], mean) { static calculateStandardDeviation(samples: number[], mean) {
var deviation = 0; var deviation = 0;
// TODO: use reduce // TODO: use reduce
samples.forEach(x => deviation += Math.pow(x - mean, 2)); samples.forEach(x => deviation += Math.pow(x - mean, 2));