refactor(ivy): pull property read into a constant (#34290)

PR Close #34290
This commit is contained in:
Misko Hevery 2019-12-06 20:21:24 -08:00 committed by Andrew Kushnir
parent 4ef6f1ab2e
commit c8447d21bd
1 changed files with 5 additions and 4 deletions

View File

@ -55,13 +55,14 @@ const _CLEAN_PROMISE = (() => Promise.resolve(null))();
export function setHostBindings(tView: TView, lView: LView): void { export function setHostBindings(tView: TView, lView: LView): void {
const selectedIndex = getSelectedIndex(); const selectedIndex = getSelectedIndex();
try { try {
if (tView.expandoInstructions !== null) { const expandoInstructions = tView.expandoInstructions;
if (expandoInstructions !== null) {
let bindingRootIndex = setBindingIndex(tView.expandoStartIndex); let bindingRootIndex = setBindingIndex(tView.expandoStartIndex);
setBindingRoot(bindingRootIndex); setBindingRoot(bindingRootIndex);
let currentDirectiveIndex = -1; let currentDirectiveIndex = -1;
let currentElementIndex = -1; let currentElementIndex = -1;
for (let i = 0; i < tView.expandoInstructions.length; i++) { for (let i = 0; i < expandoInstructions.length; i++) {
const instruction = tView.expandoInstructions[i]; const instruction = expandoInstructions[i];
if (typeof instruction === 'number') { if (typeof instruction === 'number') {
if (instruction <= 0) { if (instruction <= 0) {
// Negative numbers mean that we are starting new EXPANDO block and need to update // Negative numbers mean that we are starting new EXPANDO block and need to update
@ -70,7 +71,7 @@ export function setHostBindings(tView: TView, lView: LView): void {
setActiveHostElement(currentElementIndex); setActiveHostElement(currentElementIndex);
// Injector block and providers are taken into account. // Injector block and providers are taken into account.
const providerCount = (tView.expandoInstructions[++i] as number); const providerCount = (expandoInstructions[++i] as number);
bindingRootIndex += INJECTOR_BLOOM_PARENT_SIZE + providerCount; bindingRootIndex += INJECTOR_BLOOM_PARENT_SIZE + providerCount;
currentDirectiveIndex = bindingRootIndex; currentDirectiveIndex = bindingRootIndex;