From c88e18a0513c2e4606a4d6c240b61c8c9ebae641 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Thu, 24 Jun 2021 20:56:41 +0300 Subject: [PATCH] ci: exclude `service-worker/` sub-directories from `fw-testing` PullApprove group (#42631) The `fw-testing` PullApprove group, which by default owns all `testing/` sub-directories, is supposed to own resources related to testing Angular applications (from an end-user's perspective). The `service-worker` package source code includes some `testing/` sub-directories which are intended for internal use only (i.e. to test the `service-worker` package itself) and are not distributed to end-users of the package. Previously, changes in these `testing/` sub-directories would incorrectly require approval from the `fw-testing` group. This commit fixes this by excluding the `service-worker` package sub-directories from the files owned by the `fw-testing` group. PR Close #42631 --- .pullapprove.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 2f1d22fb80..66e19b8ddc 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -665,7 +665,7 @@ groups: - *can-be-global-approved - *can-be-global-docs-approved - > - contains_any_globs(files.exclude('packages/compiler-cli/**').exclude('packages/language-service/**'), [ + contains_any_globs(files.exclude('packages/compiler-cli/**').exclude('packages/language-service/**').exclude('packages/service-worker/**'), [ 'packages/**/testing/**', 'aio/content/guide/testing.md', 'aio/content/guide/test-debugging.md',