iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler-cli): disable buggy expression lowering (#18513)

Browse Source
This commit is contained in:
Victor Berchet 2017-08-03 14:31:23 -07:00 committed by GitHub
parent 9b015a95eb
commit ca695e0632
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/compiler-cli/src/transformers/program.ts
View File

@ -187,7 +187,8 @@ class AngularCompilerProgram implements Program {
const before: ts.TransformerFactory<ts.SourceFile>[] = []; const before: ts.TransformerFactory<ts.SourceFile>[] = [];
const after: ts.TransformerFactory<ts.SourceFile>[] = []; const after: ts.TransformerFactory<ts.SourceFile>[] = [];
if (!this.options.disableExpressionLowering) { if (!this.options.disableExpressionLowering) {
before.push(getExpressionLoweringTransformFactory(this.metadataCache)); // TODO(chuckj): fix and re-enable + tests - see https://github.com/angular/angular/pull/18388
// before.push(getExpressionLoweringTransformFactory(this.metadataCache));
} }
if (!this.options.skipTemplateCodegen) { if (!this.options.skipTemplateCodegen) {
after.push(getAngularEmitterTransformFactory(this.generatedFiles)); after.push(getAngularEmitterTransformFactory(this.generatedFiles));

2
packages/compiler-cli/test/ngc_spec.ts
View File

@ -315,7 +315,7 @@ describe('ngc command-line', () => {
.toBe(true); .toBe(true);
}); });
describe('expression lowering', () => { xdescribe('expression lowering', () => {
beforeEach(() => { beforeEach(() => {
writeConfig(`{ writeConfig(`{
"extends": "./tsconfig-base.json", "extends": "./tsconfig-base.json",