revert: "revert: "feat(dev-infra): exposed new rule 'component_benchmark' via dev_infra (#36434)" (#36798)" (#36800)

This reverts commit ad8c4cdd75.

PR Close #36800

.pullapprove.yml

@@ -968,8 +968,6 @@ groups:
           'docs/TOOLS.md',
           'docs/TRIAGE_AND_LABELS.md',
           'goldens/*',
-          'modules/e2e_util/e2e_util.ts',
-          'modules/e2e_util/perf_util.ts',
           'modules/*',
           'packages/*',
           'packages/examples/test-utils/**',
@@ -977,14 +975,10 @@ groups:
           'packages/examples/*',
           'scripts/**',
           'third_party/**',
-          'tools/brotli-cli/**',
-          'tools/browsers/**',
           'tools/build/**',
           'tools/circular_dependency_test/**',
           'tools/contributing-stats/**',
-          'tools/components/**',
           'tools/gulp-tasks/**',
-          'tools/ng_rollup_bundle/**',
           'tools/ngcontainer/**',
           'tools/npm/**',
           'tools/npm_integration_test/**',

BUILD.bazel

@@ -2,7 +2,6 @@ package(default_visibility = ["//visibility:public"])
 
 exports_files([
     "LICENSE",
-    "protractor-perf.conf.js",
     "karma-js.conf.js",
     "browser-providers.conf.js",
     "scripts/ci/track-payload-size.sh",

WORKSPACE

@@ -64,7 +64,7 @@ load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories"
 
 web_test_repositories()
 
-load("//tools/browsers:browser_repositories.bzl", "browser_repositories")
+load("//dev-infra/benchmark/browsers:browser_repositories.bzl", "browser_repositories")
 
 browser_repositories()
 

dev-infra/benchmark/BUILD.bazel

@@ -0,0 +1,12 @@
+package(default_visibility = ["//visibility:public"])
+
+# Make source files available for distribution via pkg_npm
+filegroup(
+    name = "files",
+    srcs = glob(["*"]) + [
+        "//dev-infra/benchmark/brotli-cli:files",
+        "//dev-infra/benchmark/browsers:files",
+        "//dev-infra/benchmark/component_benchmark:files",
+        "//dev-infra/benchmark/ng_rollup_bundle:files",
+    ],
+)

dev-infra/benchmark/brotli-cli/BUILD.bazel

@@ -0,0 +1,19 @@
+package(default_visibility = ["//visibility:public"])
+
+load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
+
+nodejs_binary(
+    name = "brotli-cli",
+    data = [
+        "cli.js",
+        "@npm//brotli",
+    ],
+    entry_point = ":cli.js",
+    visibility = ["//visibility:public"],
+)
+
+# Make source files available for distribution via pkg_npm
+filegroup(
+    name = "files",
+    srcs = glob(["*"]),
+)

dev-infra/benchmark/browsers/BUILD.bazel

@@ -14,6 +14,8 @@
 #
 ################################################################################
 #
+package(default_visibility = ["//visibility:public"])
+
 load("@io_bazel_rules_webtesting//web:web.bzl", "browser", "web_test_archive")
 
 # Override of chromium web_test_archive so that the archive is selected based on platform
@@ -31,7 +33,7 @@ web_test_archive(
         "@io_bazel_rules_webtesting//common/conditions:mac": {"CHROMIUM": "chrome-mac/Chromium.app/Contents/MacOS/chromium"},
         "@io_bazel_rules_webtesting//common/conditions:windows": {"CHROMIUM": "chrome-win/chrome.exe"},
     }),
-    visibility = ["//tools/browsers:__subpackages__"],
+    visibility = ["//dev-infra/benchmark/browsers:__subpackages__"],
 )
 
 # Override of chromedriver web_test_archive so that the archive is selected based on platform
@@ -55,7 +57,7 @@ web_test_archive(
             "CHROMEDRIVER": "chromedriver_win32/chromedriver.exe",
         },
     }),
-    visibility = ["//tools/browsers:__subpackages__"],
+    visibility = ["//dev-infra/benchmark/browsers:__subpackages__"],
 )
 
 browser(
@@ -68,3 +70,9 @@ browser(
         "@io_bazel_rules_webtesting//go/wsl",
     ],
 )
+
+# Make source files available for distribution via pkg_npm
+filegroup(
+    name = "files",
+    srcs = glob(["*"]),
+)

dev-infra/benchmark/component_benchmark/BUILD.bazel

@@ -0,0 +1,12 @@
+package(default_visibility = ["//visibility:public"])
+
+exports_files([
+    "protractor-perf.conf.js",
+    "start-server.js",
+])
+
+# Make source files available for distribution via pkg_npm
+filegroup(
+    name = "files",
+    srcs = glob(["*"]) + ["//dev-infra/benchmark/component_benchmark/defaults:files"],
+)

dev-infra/benchmark/component_benchmark/benchmark_test.bzl

@@ -1,4 +1,4 @@
-load("//tools:defaults.bzl", "protractor_web_test_suite")
+load("@npm_bazel_protractor//:index.bzl", "protractor_web_test_suite")
 
 """
   Macro that can be used to define a benchmark test. This differentiates from
@@ -10,11 +10,9 @@ load("//tools:defaults.bzl", "protractor_web_test_suite")
 def benchmark_test(name, server, tags = [], **kwargs):
     protractor_web_test_suite(
         name = name,
-        configuration = "//:protractor-perf.conf.js",
+        browsers = ["//dev-infra/benchmark/browsers:chromium"],
-        data = [
+        configuration = "//dev-infra/benchmark/component_benchmark:protractor-perf.conf.js",
-            "//packages/benchpress",
+        on_prepare = "//dev-infra/benchmark/component_benchmark:start-server.js",
-        ],
-        on_prepare = "//modules/benchmarks:start-server.js",
         server = server,
         # Benchmark targets should not run on CI by default.
         tags = tags + [

dev-infra/benchmark/component_benchmark/component_benchmark.bzl

@@ -1,9 +1,11 @@
-load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver", "ts_library")
+load("//dev-infra/benchmark/ng_rollup_bundle:ng_rollup_bundle.bzl", "ng_rollup_bundle")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//tools:defaults.bzl", "ng_module")
+load("@npm_bazel_typescript//:index.bzl", "ts_devserver", "ts_library")
+load(":benchmark_test.bzl", "benchmark_test")
 
 def copy_default_file(origin, destination):
     """
-    Copies a file from tools/components/defaults to the destination.
+    Copies a file from /defaults to the destination.
 
     Args:
         origin: The name of a file in benchpress/defaults to be copied.
@@ -11,7 +13,7 @@ def copy_default_file(origin, destination):
     """
     native.genrule(
         name = "copy_default_" + origin + "_file_genrule",
-        srcs = ["//tools/components/defaults:" + origin],
+        srcs = ["//dev-infra/benchmark/component_benchmark/defaults:" + origin],
         outs = [destination],
         cmd = "cat $(SRCS) >> $@",
     )
@@ -105,6 +107,7 @@ def component_benchmark(
         # Creates ngFactory and ngSummary to be imported by the app's entry point.
         generate_ve_shims = True,
         deps = ng_deps,
+        tsconfig = "//dev-infra/benchmark/component_benchmark:tsconfig-e2e.json",
     )
 
     # Bundle the application (needed by ts_devserver).
@@ -117,7 +120,7 @@ def component_benchmark(
     # The ts_library for the driver that runs tests against the benchmark app.
     ts_library(
         name = benchmark_driver,
-        tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
+        tsconfig = "//dev-infra/benchmark/component_benchmark:tsconfig-e2e.json",
         testonly = True,
         srcs = [driver],
         deps = driver_deps,
@@ -130,7 +133,8 @@ def component_benchmark(
         port = 4200,
         static_files = assets + styles,
         deps = [":" + app_main + ".min_debug.es2015.js"],
-        additional_root_paths = ["tools/components/defaults"],
+        additional_root_paths = ["//dev-infra/benchmark/component_benchmark/defaults"],
+        serving_path = "/app_bundle.js",
     )
 
     # Runs a protractor test that's set up to use @angular/benchpress.

dev-infra/benchmark/component_benchmark/defaults/BUILD.bazel

@@ -1,5 +1,11 @@
 package(default_visibility = ["//visibility:public"])
 
+# Make source files available for distribution via pkg_npm
+filegroup(
+    name = "files",
+    srcs = glob(["*"]),
+)
+
 exports_files([
     "index.html",
     "index.ts",

dev-infra/benchmark/component_benchmark/tsconfig-e2e.json

@@ -0,0 +1,6 @@
+{
+  "compilerOptions": {
+    "lib": ["es2015", "dom"],
+    "types": ["node", "jasmine"]
+  }
+}

dev-infra/benchmark/driver-utilities/BUILD.bazel

@@ -1,15 +1,16 @@
-load("//tools:defaults.bzl", "ts_library")
-
 package(default_visibility = ["//visibility:public"])
 
+load("@npm_bazel_typescript//:index.bzl", "ts_library")
+
 ts_library(
-    name = "e2e_util",
+    name = "driver-utilities",
-    testonly = 1,
     srcs = glob(["*.ts"]),
+    module_name = "@angular/dev-infra/benchmark/driver-utilities",
+    tsconfig = "//dev-infra/benchmark/component_benchmark:tsconfig-e2e.json",
     deps = [
-        "//packages:types",
         "//packages/benchpress",
         "@npm//@types/fs-extra",
+        "@npm//@types/node",
         "@npm//@types/selenium-webdriver",
         "@npm//fs-extra",
         "@npm//node-uuid",

dev-infra/benchmark/driver-utilities/index.ts

@@ -0,0 +1,9 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+export {openBrowser, verifyNoBrowserErrors} from './e2e_util';
+export {runBenchmark} from './perf_util';

dev-infra/benchmark/ng_rollup_bundle/BUILD.bazel

@@ -18,3 +18,9 @@ nodejs_binary(
     ],
     entry_point = "@npm//:node_modules/rollup/dist/bin/rollup",
 )
+
+# Make source files available for distribution via pkg_npm
+filegroup(
+    name = "files",
+    srcs = glob(["*"]),
+)

dev-infra/benchmark/ng_rollup_bundle/ng_rollup_bundle.bzl

@@ -175,10 +175,10 @@ _NG_ROLLUP_BUNDLE_ATTRS = {
     "_rollup": attr.label(
         executable = True,
         cfg = "host",
-        default = Label("//tools/ng_rollup_bundle:rollup_with_build_optimizer"),
+        default = Label("//dev-infra/benchmark/ng_rollup_bundle:rollup_with_build_optimizer"),
     ),
     "_rollup_config_tmpl": attr.label(
-        default = Label("//tools/ng_rollup_bundle:rollup.config.js"),
+        default = Label("//dev-infra/benchmark/ng_rollup_bundle:rollup.config.js"),
         allow_single_file = True,
     ),
 }
@@ -392,7 +392,7 @@ def ng_rollup_bundle(name, **kwargs):
         # maintain the comments off behavior. We pass the --comments flag with
         # a regex that always evaluates to false to do this.
         "args": ["--comments", "/bogus_string_to_suppress_all_comments^/"],
-        "config_file": "//tools/ng_rollup_bundle:terser_config.json",
+        "config_file": "//dev-infra/benchmark/ng_rollup_bundle:terser_config.json",
         "sourcemap": False,
     }
 
@@ -413,7 +413,7 @@ def ng_rollup_bundle(name, **kwargs):
     native.filegroup(name = name + ".min_debug.js", srcs = [name + ".min_debug"], visibility = visibility)
     npm_package_bin(
         name = "_%s_brotli" % name,
-        tool = "//tools/brotli-cli",
+        tool = "//dev-infra/benchmark/brotli-cli",
         data = [name + ".min.js"],
         outs = [name + ".min.js.br"],
         args = [
@@ -436,7 +436,7 @@ def ng_rollup_bundle(name, **kwargs):
     native.filegroup(name = name + ".min_debug.es2015.js", srcs = [name + ".min_debug.es2015"], visibility = visibility)
     npm_package_bin(
         name = "_%s_es2015_brotli" % name,
-        tool = "//tools/brotli-cli",
+        tool = "//dev-infra/benchmark/brotli-cli",
         data = [name + ".min.es2015.js"],
         outs = [name + ".min.es2015.js.br"],
         args = [

dev-infra/tools/BUILD.bazel

@@ -0,0 +1,12 @@
+package(default_visibility = ["//visibility:public"])
+
+# Make source files available for distribution via pkg_npm
+filegroup(
+    name = "files",
+    srcs = glob(["*"]) + [
+        "//dev-infra/benchmark/brotli-cli:files",
+        "//dev-infra/benchmark/browsers:files",
+        "//dev-infra/benchmark/component_benchmark:files",
+        "//dev-infra/benchmark/ng_rollup_bundle:files",
+    ],
+)

modules/benchmarks/BUILD.bazel

@@ -3,5 +3,4 @@ package(default_visibility = ["//visibility:public"])
 exports_files([
     "tsconfig-build.json",
     "tsconfig-e2e.json",
-    "start-server.js",
 ])

modules/benchmarks/e2e_test.bzl

@@ -9,7 +9,7 @@ load("//tools:defaults.bzl", "protractor_web_test_suite")
 def e2e_test(name, server, **kwargs):
     protractor_web_test_suite(
         name = name,
-        on_prepare = "//modules/benchmarks:start-server.js",
+        on_prepare = "//dev-infra/benchmark/component_benchmark:start-server.js",
         server = server,
         **kwargs
     )

modules/benchmarks/src/change_detection/BUILD.bazel

@@ -15,7 +15,7 @@ ts_library(
     srcs = ["change_detection.perf-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )
@@ -26,7 +26,7 @@ ts_library(
     srcs = ["change_detection.e2e-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )

modules/benchmarks/src/change_detection/change_detection.e2e-spec.ts

@@ -8,7 +8,7 @@
 
 import {$} from 'protractor';
 
-import {openBrowser, verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {openBrowser, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('change detection benchmark', () => {
   afterEach(verifyNoBrowserErrors);

modules/benchmarks/src/change_detection/change_detection.perf-spec.ts

@@ -7,7 +7,7 @@
  */
 
 import {$} from 'protractor';
-import {runBenchmark, verifyNoBrowserErrors} from '../../../e2e_util/perf_util';
+import {runBenchmark, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 interface Worker {
   id: string;

modules/benchmarks/src/change_detection/transplanted_views/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/class_bindings/class_bindings.perf-spec.ts

@@ -7,7 +7,7 @@
  */
 
 import {$, browser} from 'protractor';
-import {runBenchmark} from '../../../e2e_util/perf_util';
+import {runBenchmark} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('class bindings perf', () => {
   it('should work for update', async () => {

modules/benchmarks/src/expanding_rows/BUILD.bazel

@@ -1,7 +1,7 @@
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 
 ng_module(
     name = "application_lib",
@@ -26,7 +26,7 @@ ts_library(
     srcs = ["expanding_rows.perf-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )

modules/benchmarks/src/expanding_rows/expanding_rows.perf-spec.ts

@@ -7,7 +7,7 @@
  */
 
 import {$, browser} from 'protractor';
-import {runBenchmark} from '../../../e2e_util/perf_util';
+import {runBenchmark} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('benchmarks', () => {
   it('should work for create', async () => {

modules/benchmarks/src/js-web-frameworks/BUILD.bazel

@@ -8,7 +8,7 @@ ts_library(
     srcs = ["js-web-frameworks.perf-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )

modules/benchmarks/src/js-web-frameworks/js-web-frameworks.perf-spec.ts

@@ -7,7 +7,7 @@
  */
 
 import {$} from 'protractor';
-import {runBenchmark, verifyNoBrowserErrors} from '../../../e2e_util/perf_util';
+import {runBenchmark, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 interface Worker {
   id: string;

modules/benchmarks/src/js-web-frameworks/ng2/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 

modules/benchmarks/src/largeform/BUILD.bazel

@@ -8,7 +8,7 @@ ts_library(
     srcs = ["largeform.perf-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )
@@ -19,7 +19,7 @@ ts_library(
     srcs = ["largeform.e2e-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )

modules/benchmarks/src/largeform/largeform.e2e-spec.ts

@@ -8,7 +8,7 @@
 
 import {$, By, element} from 'protractor';
 
-import {openBrowser, verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {openBrowser, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('largeform benchmark', () => {
   afterEach(verifyNoBrowserErrors);

modules/benchmarks/src/largeform/largeform.perf-spec.ts

@@ -8,8 +8,7 @@
 
 import {$} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {runBenchmark, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
-import {runBenchmark} from '../../../e2e_util/perf_util';
 
 interface Worker {
   id: string;

modules/benchmarks/src/largeform/ng2/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/largetable/BUILD.bazel

@@ -15,7 +15,7 @@ ts_library(
     srcs = ["largetable.perf-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )
@@ -26,7 +26,7 @@ ts_library(
     srcs = ["largetable.e2e-spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )

modules/benchmarks/src/largetable/baseline/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/largetable/incremental_dom/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/largetable/iv/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/largetable/largetable.e2e-spec.ts

@@ -8,7 +8,7 @@
 
 import {$} from 'protractor';
 
-import {openBrowser, verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {openBrowser, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('largetable benchmark', () => {
   afterEach(verifyNoBrowserErrors);

modules/benchmarks/src/largetable/largetable.perf-spec.ts

@@ -7,7 +7,7 @@
  */
 
 import {$} from 'protractor';
-import {runBenchmark, verifyNoBrowserErrors} from '../../../e2e_util/perf_util';
+import {runBenchmark, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 interface Worker {
   id: string;

modules/benchmarks/src/largetable/ng2/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/largetable/ng2_switch/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/largetable/render3/BUILD.bazel

@@ -1,7 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 ng_module(

modules/benchmarks/src/styling/BUILD.bazel

@@ -8,7 +8,7 @@ ts_library(
     srcs = ["styling_perf.spec.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )

modules/benchmarks/src/styling/ng2/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 

modules/benchmarks/src/styling/styling_perf.spec.ts

@@ -7,8 +7,7 @@
  */
 
 import {$, by, element} from 'protractor';
-import {openBrowser, verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {openBrowser, runBenchmark, verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
-import {runBenchmark} from '../../../e2e_util/perf_util';
 
 /** List of possible scenarios that should be tested.  */
 const SCENARIOS = [

modules/benchmarks/src/tree/BUILD.bazel

@@ -15,7 +15,7 @@ ts_library(
     srcs = ["test_utils.ts"],
     tsconfig = "//modules/benchmarks:tsconfig-e2e.json",
     deps = [
-        "//modules/e2e_util",
+        "//dev-infra/benchmark/driver-utilities",
         "@npm//protractor",
     ],
 )

modules/benchmarks/src/tree/baseline/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/incremental_dom/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/iv/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/ng1/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/ng2/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/ng2_next/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/ng2_static/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ts_devserver", "ts_library")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/ng2_switch/BUILD.bazel

@@ -1,5 +1,5 @@
 load("//tools:defaults.bzl", "ng_module", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])

modules/benchmarks/src/tree/render3/BUILD.bazel

@@ -1,7 +1,7 @@
 package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
 load("//tools:defaults.bzl", "ng_module", "ng_rollup_bundle", "ts_devserver")
-load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
+load("//dev-infra/benchmark/component_benchmark:benchmark_test.bzl", "benchmark_test")
 load("//modules/benchmarks:e2e_test.bzl", "e2e_test")
 
 ng_module(

modules/benchmarks/src/tree/test_utils.ts

@@ -8,8 +8,7 @@
 
 import {browser} from 'protractor';
 
-import {openBrowser} from '../../../e2e_util/e2e_util';
+import {openBrowser, runBenchmark} from '../../../../dev-infra/benchmark/driver-utilities';
-import {runBenchmark} from '../../../e2e_util/perf_util';
 
 export function runTreeBenchmark({id, prepare, setup, work}: {
   id: string; prepare ? () : void; setup ? () : void; work(): void;

modules/benchmarks/tsconfig.json

@@ -14,7 +14,7 @@
       "rxjs/*": ["../../node_modules/rxjs/*"],
       "@angular/*": ["../../packages/*"],
       "zone.js/*": ["../../packages/zone.js/*"],
-      "e2e_util/*": ["../e2e_util/*"]
+      "dev_infra/*": ["../../dev-infra/*"]
     },
     "rootDir": ".",
     "inlineSourceMap": true,
@@ -31,5 +31,6 @@
     "no-floating-promises": true,
     "no-unused-expression": true,
     "no-unused-variable": true
-  }
+  },
+  "include": ["../../dev-infra/benchmark/driver-utilities/"]
 }

modules/playground/e2e_test/async/async_spec.ts

@@ -9,7 +9,7 @@
 import {$, browser} from 'protractor';
 import {promise} from 'selenium-webdriver';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('async', () => {
   const URL = '/';

modules/playground/e2e_test/example_test.bzl

@@ -7,7 +7,7 @@ def example_test(name, srcs, server, data = [], **kwargs):
         srcs = srcs,
         tsconfig = "//modules/playground:tsconfig-e2e.json",
         deps = [
-            "//modules/e2e_util",
+            "//dev-infra/benchmark/driver-utilities",
             "//packages/private/testing",
             "@npm//@types/jasminewd2",
             "@npm//@types/selenium-webdriver",

modules/playground/e2e_test/hello_world/hello_world_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('hello world', function() {
   afterEach(verifyNoBrowserErrors);

modules/playground/e2e_test/http/http_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('http', function() {
   afterEach(verifyNoBrowserErrors);

modules/playground/e2e_test/jsonp/jsonp_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('jsonp', function() {
   afterEach(verifyNoBrowserErrors);

modules/playground/e2e_test/key_events/key_events_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element, protractor} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 const Key = protractor.Key;
 

modules/playground/e2e_test/model_driven_forms/model_driven_forms_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('Model-Driven Forms', function() {
   afterEach(verifyNoBrowserErrors);

modules/playground/e2e_test/order_management/order_management_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('Order Management CRUD', function() {
   const URL = '/';

modules/playground/e2e_test/person_management/person_management_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('Person Management CRUD', function() {
   const URL = '/';

modules/playground/e2e_test/relative_assets/assets_spec.ts

@@ -8,7 +8,7 @@
 
 import {$, browser, by, element, ExpectedConditions} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 function waitForElement(selector: string) {
   // Waits for the element with id 'abc' to be present on the dom.

modules/playground/e2e_test/routing/routing_spec.ts

@@ -8,7 +8,7 @@
 
 import {$, browser, by, element, ExpectedConditions} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 function waitForElement(selector: string) {
   // Waits for the element with id 'abc' to be present on the dom.

modules/playground/e2e_test/svg/svg_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('SVG', function() {
   const URL = '/';

modules/playground/e2e_test/template_driven_forms/template_driven_forms_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('Template-Driven Forms', function() {
   afterEach(verifyNoBrowserErrors);

modules/playground/e2e_test/upgrade/upgrade_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('ngUpgrade', function() {
   const URL = '/';

modules/playground/e2e_test/web_workers/animations/animations_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element, protractor} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../../dev-infra/benchmark/driver-utilities';
 
 
 // Disabled because with ViewEngine animations within webworkers is not supported.

modules/playground/e2e_test/web_workers/input/input_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element, ExpectedConditions, protractor} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../../dev-infra/benchmark/driver-utilities';
 
 describe('WebWorkers Input', function() {
   afterEach(() => {

modules/playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element, ExpectedConditions, protractor} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../../dev-infra/benchmark/driver-utilities';
 
 describe('WebWorkers Kitchen Sink', function() {
   afterEach(() => {

modules/playground/e2e_test/web_workers/message_broker/message_broker_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element, ExpectedConditions, protractor} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../../dev-infra/benchmark/driver-utilities';
 
 const URL = '/';
 

modules/playground/e2e_test/web_workers/router/router_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element, protractor} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../../dev-infra/benchmark/driver-utilities';
 
 describe('WebWorker Router', () => {
   beforeEach(() => {

modules/playground/e2e_test/web_workers/todo/todo_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element, protractor} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../../dev-infra/benchmark/driver-utilities';
 
 describe('WebWorkers Todo', function() {
   afterEach(() => {

modules/playground/e2e_test/zippy_component/zippy_spec.ts

@@ -8,7 +8,7 @@
 
 import {browser, by, element} from 'protractor';
 
-import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util';
+import {verifyNoBrowserErrors} from '../../../../dev-infra/benchmark/driver-utilities';
 
 describe('Zippy Component', function() {
   afterEach(verifyNoBrowserErrors);

modules/tsconfig.json

@@ -23,7 +23,6 @@
     "types": ["angular"]
   },
   "exclude": [
-    "benchmarks_external",
     "payload_tests",
     "playground/",
     "benchmarks/"

packages/language-service/bundles/BUILD.bazel

@@ -1,4 +1,4 @@
-load("//tools/ng_rollup_bundle:ng_rollup_bundle.bzl", "ls_rollup_bundle")
+load("//dev-infra/benchmark/ng_rollup_bundle:ng_rollup_bundle.bzl", "ls_rollup_bundle")
 
 ls_rollup_bundle(
     name = "language-service",

packages/tsconfig.json

@@ -19,8 +19,7 @@
       "selenium-webdriver": ["./node_modules/@types/selenium-webdriver/index.d.ts"],
       "rxjs/*": ["./node_modules/rxjs/*"],
       "@angular/*": ["./packages/*"],
-      "zone.js/*": ["./packages/zone.js/*"],
+      "zone.js/*": ["./packages/zone.js/*"]
-      "e2e_util/*": ["./modules/e2e_util/*"]
     },
     "rootDir": ".",
     "inlineSourceMap": true,

packages/zone.js/test/karma_test.bzl

@@ -70,7 +70,7 @@ def karma_test(name, env_srcs, env_deps, env_entry_point, test_srcs, test_deps,
                             ":" + name + "_env_rollup.umd",
                         ] + bootstrap +
                         _karma_test_required_dist_files,
-            browsers = ["//tools/browsers:chromium"],
+            browsers = ["//dev-infra/benchmark/browsers:chromium"],
             static_files = [
                 ":assets/sample.json",
                 ":assets/worker.js",
@@ -93,7 +93,7 @@ def karma_test(name, env_srcs, env_deps, env_entry_point, test_srcs, test_deps,
                     ":" + name + "_env_rollup.umd",
                     "//packages/zone.js/dist:zone-testing-bundle.min.js",
                 ] + _karma_test_required_dist_files,
-                browsers = ["//tools/browsers:chromium"],
+                browsers = ["//dev-infra/benchmark/browsers:chromium"],
                 config_file = "//:karma-js.conf.js",
                 configuration_env_vars = ["KARMA_WEB_TEST_MODE"],
                 data = [

tools/brotli-cli/BUILD.bazel

@@ -1,11 +0,0 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-
-nodejs_binary(
-    name = "brotli-cli",
-    data = [
-        "cli.js",
-        "@npm//brotli",
-    ],
-    entry_point = ":cli.js",
-    visibility = ["//:__subpackages__"],
-)

tools/components/BUILD.bazel

@@ -1,4 +0,0 @@
-# This BUILD file exists to mark //tools/components as a package.
-#
-# Without this, using component_benchmark.bzl would throw an error saying:
-# Label '//tools/components:component_benchmark.bzl' is invalid because 'tools/components' is not a package

tools/defaults.bzl

@@ -10,7 +10,7 @@ load("@npm_bazel_typescript//:index.bzl", _ts_devserver = "ts_devserver", _ts_li
 load("@npm_bazel_protractor//:index.bzl", _protractor_web_test_suite = "protractor_web_test_suite")
 load("@npm//typescript:index.bzl", "tsc")
 load("//packages/bazel:index.bzl", _ng_module = "ng_module", _ng_package = "ng_package")
-load("//tools/ng_rollup_bundle:ng_rollup_bundle.bzl", _ng_rollup_bundle = "ng_rollup_bundle")
+load("//dev-infra/benchmark/ng_rollup_bundle:ng_rollup_bundle.bzl", _ng_rollup_bundle = "ng_rollup_bundle")
 load("//tools:ng_benchmark.bzl", _ng_benchmark = "ng_benchmark")
 load("//tools/ts-api-guardian:index.bzl", _ts_api_guardian_test = "ts_api_guardian_test", _ts_api_guardian_test_npm_package = "ts_api_guardian_test_npm_package")
 
@@ -245,7 +245,7 @@ def karma_web_test_suite(name, **kwargs):
         runtime_deps = runtime_deps,
         bootstrap = bootstrap,
         deps = deps,
-        browsers = ["//tools/browsers:chromium"],
+        browsers = ["//dev-infra/benchmark/browsers:chromium"],
         data = data,
         tags = tags,
         **kwargs
@@ -282,7 +282,7 @@ def protractor_web_test_suite(**kwargs):
     """Default values for protractor_web_test_suite"""
 
     _protractor_web_test_suite(
-        browsers = ["//tools/browsers:chromium"],
+        browsers = ["//dev-infra/benchmark/browsers:chromium"],
         **kwargs
     )