iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(elements): clean up TestStrategy between tests (#36114)

Browse Source 
Previously, the `TestStrategy` `NgElementStrategy` used in
`createCustomElement()` tests was created once and re-used in each test
(due to complications related to how `customElements.register()` works).
As a result, the `TestStrategy` instance's state (e.g. inputs) could be
polluted from previous tests and affect subsequent ones.

This commit ensures the strategy instance is reset before each test.

PR Close #36114
This commit is contained in:
George Kalpakas 2020-05-20 11:10:25 +03:00 committed by Kara Erickson
parent ed46d9ebd7
commit cb719ee16e
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/elements/test/create-custom-element_spec.ts
View File

@ -45,6 +45,8 @@ if (browserDetection.supportsCustomElements) {
.then(done, done.fail); .then(done, done.fail);
}); });
afterEach(() => strategy.reset());
afterAll(() => destroyPlatform()); afterAll(() => destroyPlatform());
it('should use a default strategy for converting component inputs', () => { it('should use a default strategy for converting component inputs', () => {
@ -155,6 +157,12 @@ if (browserDetection.supportsCustomElements) {
setInputValue(propName: string, value: string): void { setInputValue(propName: string, value: string): void {
this.inputs.set(propName, value); this.inputs.set(propName, value);
} }
reset(): void {
this.connectedElement = null;
this.disconnectCalled = false;
this.inputs.clear();
}
} }
class TestStrategyFactory implements NgElementStrategyFactory { class TestStrategyFactory implements NgElementStrategyFactory {