iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(PipeRegistry): improve error messages 

Closes #1504
This commit is contained in:
Pawel Kozlowski 2015-04-23 15:27:20 +02:00 committed by Misko Hevery
parent fa8e059f28
commit d0059b5d75
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/angular2/src/change_detection/pipes/pipe_registry.js vendored
View File

@ -15,14 +15,14 @@ export class PipeRegistry {
get(type:string, obj, cdRef:ChangeDetectorRef):Pipe { get(type:string, obj, cdRef:ChangeDetectorRef):Pipe {
var listOfConfigs = this.config[type]; var listOfConfigs = this.config[type];
if (isBlank(listOfConfigs)) { if (isBlank(listOfConfigs)) {
throw new BaseException(`Cannot find a pipe for type '${type}' object '${obj}'`); throw new BaseException(`Cannot find '${type}' pipe supporting object '${obj}'`);
} }
var matchingConfig = ListWrapper.find(listOfConfigs, var matchingConfig = ListWrapper.find(listOfConfigs,
(pipeConfig) => pipeConfig.supports(obj)); (pipeConfig) => pipeConfig.supports(obj));
if (isBlank(matchingConfig)) { if (isBlank(matchingConfig)) {
throw new BaseException(`Cannot find a pipe for type '${type}' object '${obj}'`); throw new BaseException(`Cannot find '${type}' pipe supporting object '${obj}'`);
} }
return matchingConfig.create(cdRef); return matchingConfig.create(cdRef);

4
modules/angular2/test/change_detection/pipes/pipe_registry_spec.js vendored
View File

@ -22,7 +22,7 @@ export function main() {
it("should throw when no matching type", () => { it("should throw when no matching type", () => {
var r = new PipeRegistry({}); var r = new PipeRegistry({});
expect(() => r.get("unknown", "some object", null)).toThrowError( expect(() => r.get("unknown", "some object", null)).toThrowError(
`Cannot find a pipe for type 'unknown' object 'some object'` `Cannot find 'unknown' pipe supporting object 'some object'`
); );
}); });
@ -32,7 +32,7 @@ export function main() {
}); });
expect(() => r.get("type", "some object", null)).toThrowError( expect(() => r.get("type", "some object", null)).toThrowError(
`Cannot find a pipe for type 'type' object 'some object'` `Cannot find 'type' pipe supporting object 'some object'`
); );
}); });
}); });