From d0e086a5fe23e2fc7565211ea4574dd3f50fb5b4 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Mon, 22 Jan 2018 22:48:11 +0200 Subject: [PATCH] fix(aio): remove remaining `plnkr` references (#20165) PR Close #20165 --- aio/content/guide/change-log.md | 2 +- aio/content/guide/setup-systemjs-anatomy.md | 2 +- aio/content/marketing/test.html | 12 ++++++------ aio/tools/RELEASE.md | 15 ++++++++++----- 4 files changed, 18 insertions(+), 13 deletions(-) diff --git a/aio/content/guide/change-log.md b/aio/content/guide/change-log.md index 08d56deb1e..854f93010e 100644 --- a/aio/content/guide/change-log.md +++ b/aio/content/guide/change-log.md @@ -83,7 +83,7 @@ HTTP guide. ## Testing: added component test plunkers (2016-12-02) -Added two plunkers that each test _one simple component_ so you can write a component test plunker of your own: one for the QuickStart seed's `AppComponent` and another for the Testing guide's `BannerComponent`. +Added two plunkers that each test _one simple component_ so you can write a component test plunker of your own: one for the QuickStart seed's `AppComponent` and another for the Testing guide's `BannerComponent`. Linked to these plunkers in [Testing](guide/testing#live-examples) and [Setup anatomy](guide/setup-systemjs-anatomy) guides. ## Internationalization: pluralization and _select_ (2016-11-30) diff --git a/aio/content/guide/setup-systemjs-anatomy.md b/aio/content/guide/setup-systemjs-anatomy.md index e75d792ef1..0cf2aa63dd 100644 --- a/aio/content/guide/setup-systemjs-anatomy.md +++ b/aio/content/guide/setup-systemjs-anatomy.md @@ -54,7 +54,7 @@ If you do, this page can help you understand their purpose. the bootstrap file, `main.ts`. Try the sample application - and the unit test + and the unit test as _live examples_. diff --git a/aio/content/marketing/test.html b/aio/content/marketing/test.html index 872c66c45a..271bd9be11 100644 --- a/aio/content/marketing/test.html +++ b/aio/content/marketing/test.html @@ -110,13 +110,13 @@ Try this .

live-example with name

-

live-example with spacey name and plnkr

- +

live-example with spacey name and stackblitz

+ -

live-example with name and plnkr but no download

- +

live-example with name and stackblitz but no download

+ -

live-example embedded with name and plnkr

- +

live-example embedded with name and stackblitz

+

More text follows ...

diff --git a/aio/tools/RELEASE.md b/aio/tools/RELEASE.md index df8bb9831a..64293bf196 100644 --- a/aio/tools/RELEASE.md +++ b/aio/tools/RELEASE.md @@ -12,13 +12,18 @@ $ yarn upgrade-interactive --tilde There, select all the packages that are updated on the new Angular release. -**2)** Changes to the tsconfig.json? There is one to update at `/aio/tools/examples/shared/boilerplate/src/tsconfig.json` +**2)** Changes to the tsconfig.json? There are several files in `/aio/tools/examples/shared/boilerplate/*/tsconfig.json` (based on the example type). -**3)** The file `/aio/tools/examples/shared/boilerplate/src/systemjs.config.web.js` contains the configuration for plunkers. It has some hardcoded versions that could be updated. +**3)** The files `/aio/tools/examples/shared/boilerplate/systemjs/src/systemjs.config.web[.build].js` contains the configuration for plunkers. They have some hardcoded versions that could be updated. >N.B.: Plunkers have been replaced by Stackblitz and (almost) all examples have be replaced by CLI/WebPack-based examples that do not use SystemJS. The upgrade examples may still rely on SystemJS. -**4)** As in step 3, more hardcoded versions at `/aio/tools/plunker-builder/translator/rules/indexHtml.js` - ->Note the same caveat about migration from plunker to Stackblitz. +--- +> NOTE(gkalpak): +> There are some `package.json` files in `/aio/tools/examples/shared/boilerplate/*`. +> AFAICT, they are copied over to the examples (based on the example type), but they are neither +> used for installing dependencies (which come from `/aio/tools/examples/shared/package.json`) nor +> used in zips (since they are overwritten by `/aio/tools/example-zipper/customizer`). +> For all stackblitz live-examples, `/aio/tools/examples/shared/boilerplate/cli/package.json` seems +> to be used.