iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(animations): do not throw errors when a destroyed component is animated (#23836) 

PR Close #23836
This commit is contained in:
Matias Niemelä 2018-05-10 15:57:58 -07:00
parent 474dbf09ec
commit d2a86872a9
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/animations/browser/src/render/transition_animation_engine.ts
View File

@ -649,8 +649,11 @@ export class TransitionAnimationEngine {
trigger(namespaceId: string, element: any, name: string, value: any): boolean { trigger(namespaceId: string, element: any, name: string, value: any): boolean {
if (isElementNode(element)) { if (isElementNode(element)) {
this._fetchNamespace(namespaceId).trigger(element, name, value); const ns = this._fetchNamespace(namespaceId);
return true; if (ns) {
ns.trigger(element, name, value);
return true;
}
} }
return false; return false;
} }

7
packages/animations/browser/test/render/transition_animation_engine_spec.ts
View File

@ -616,6 +616,13 @@ const DEFAULT_NAMESPACE_ID = 'id';
expect(element.contains(child1)).toBe(true); expect(element.contains(child1)).toBe(true);
expect(element.contains(child2)).toBe(true); expect(element.contains(child2)).toBe(true);
}); });
it('should not throw an error if a missing namespace is used', () => {
const engine = makeEngine();
const ID = 'foo';
const TRIGGER = 'fooTrigger';
expect(() => { engine.trigger(ID, element, TRIGGER, 'something'); }).not.toThrow();
});
}); });
}); });
})(); })();