build(docs-infra): upgrade preview server dependencies (#25671)

PR Close #25671

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/circle-ci-api.ts

@@ -62,7 +62,7 @@ export class CircleCiApi {
       if (response.status !== 200) {
         throw new Error(`${baseUrl}: ${response.status} - ${response.statusText}`);
       }
-      return response.json<BuildInfo>();
+      return response.json();
     } catch (error) {
         throw new Error(`CircleCI build info request failed (${error.message})`);
     }
@@ -77,7 +77,7 @@ export class CircleCiApi {
     const baseUrl = `${CIRCLE_CI_API_URL}/${this.githubOrg}/${this.githubRepo}/${buildNumber}`;
     try {
       const response = await fetch(`${baseUrl}/artifacts?${this.tokenParam}`);
-      const artifacts = await response.json<ArtifactResponse>();
+      const artifacts = await response.json() as ArtifactResponse;
       const artifact = artifacts.find(item => item.path === artifactPath);
       if (!artifact) {
         throw new Error(`Missing artifact (${artifactPath}) for CircleCI build: ${buildNumber}`);

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/run-tests.ts

@@ -1,14 +1,13 @@
-export const runTests = (specFiles: string[], helpers?: string[]) => {
+// We can't use `import...from` here, because of the following mess:
-  // We can't use `import` here, because of the following mess:
+// - GitHub project `jasmine/jasmine` is `jasmine-core` on npm and its typings `@types/jasmine`.
-  // - GitHub project `jasmine/jasmine` is `jasmine-core` on npm and its typings `@types/jasmine`.
+// - GitHub project `jasmine/jasmine-npm` is `jasmine` on npm and has no typings.
-  // - GitHub project `jasmine/jasmine-npm` is `jasmine` on npm and has no typings.
+//
-  //
+// Using `import...from 'jasmine'` here, would import from `@types/jasmine` (which refers to the
-  // Using `import...from 'jasmine'` here, would import from `@types/jasmine` (which refers to the
+// `jasmine-core` module and the `jasmine` module).
-  // `jasmine-core` module and the `jasmine` module).
+import Jasmine = require('jasmine');
-  // tslint:disable-next-line: no-var-requires variable-name
+
-  const Jasmine = require('jasmine');
+export const runTests = (specFiles: string[]) => {
   const config = {
-    helpers,
     random: true,
     spec_files: specFiles,
     stopSpecOnExpectationFailure: true,
@@ -16,7 +15,7 @@ export const runTests = (specFiles: string[], helpers?: string[]) => {
 
   process.on('unhandledRejection', (reason: any) => console.log('Unhandled rejection:', reason));
 
-  const runner = new Jasmine();
+  const runner = new Jasmine({});
   runner.loadConfig(config);
   runner.onComplete((passed: boolean) => process.exit(passed ? 0 : 1));
   runner.execute();

aio/aio-builds-setup/dockerbuild/scripts-js/lib/preview-server/preview-server-factory.ts

@@ -2,6 +2,7 @@
 import * as bodyParser from 'body-parser';
 import * as express from 'express';
 import * as http from 'http';
+import {AddressInfo} from 'net';
 import {CircleCiApi} from '../common/circle-ci-api';
 import {GithubApi} from '../common/github-api';
 import {GithubPullRequests} from '../common/github-pull-requests';
@@ -52,7 +53,7 @@ export class PreviewServerFactory {
     const httpServer = http.createServer(middleware as any);
 
     httpServer.on('listening', () => {
-      const info = httpServer.address();
+      const info = httpServer.address() as AddressInfo;
       logger.info(`Up and running (and listening on ${info.address}:${info.port})...`);
     });
 

aio/aio-builds-setup/dockerbuild/scripts-js/package.json

@@ -25,30 +25,30 @@
     "~~test-watch": "nodemon --delay 1 --exec \"yarn ~~test-only\" --watch dist"
   },
   "dependencies": {
-    "body-parser": "^1.18.2",
+    "body-parser": "^1.18.3",
     "delete-empty": "^2.0.0",
-    "express": "^4.15.4",
+    "express": "^4.16.3",
-    "jasmine": "^2.8.0",
+    "jasmine": "^3.2.0",
-    "nock": "^9.2.5",
+    "nock": "^9.6.1",
-    "node-fetch": "^2.1.2",
+    "node-fetch": "^2.2.0",
-    "shelljs": "^0.8.1",
+    "shelljs": "^0.8.2",
-    "tar-stream": "^1.6.0",
+    "tar-stream": "^1.6.1",
-    "tslib": "^1.7.1"
+    "tslib": "^1.9.3"
   },
   "devDependencies": {
-    "@types/body-parser": "^1.16.5",
+    "@types/body-parser": "^1.17.0",
-    "@types/express": "^4.0.37",
+    "@types/express": "^4.16.0",
-    "@types/jasmine": "^2.6.0",
+    "@types/jasmine": "^2.8.8",
-    "@types/nock": "^9.1.3",
+    "@types/nock": "^9.3.0",
-    "@types/node": "^8.0.30",
+    "@types/node": "^10.9.2",
-    "@types/node-fetch": "^1.6.8",
+    "@types/node-fetch": "^2.1.2",
     "@types/shelljs": "^0.8.0",
-    "@types/supertest": "^2.0.3",
+    "@types/supertest": "^2.0.5",
-    "nodemon": "^1.12.1",
+    "nodemon": "^1.18.3",
     "npm-run-all": "^4.1.3",
-    "supertest": "^3.0.0",
+    "supertest": "^3.1.0",
-    "tslint": "^5.7.0",
+    "tslint": "^5.11.0",
-    "tslint-jasmine-noSkipOrFocus": "^1.0.8",
+    "tslint-jasmine-noSkipOrFocus": "^1.0.9",
-    "typescript": "^2.5.2"
+    "typescript": "^3.0.1"
   }
 }

aio/aio-builds-setup/dockerbuild/scripts-js/test/helpers.ts

@@ -1,6 +0,0 @@
-declare namespace jasmine {
-  export interface DoneFn extends Function {
-    (): void;
-    fail: (message: Error | string) => void;
-  }
-}

aio/aio-builds-setup/dockerbuild/scripts-js/test/index.ts

@@ -3,5 +3,4 @@ import {runTests} from '../lib/common/run-tests';
 
 // Run
 const specFiles = [`${__dirname}/**/*.spec.js`];
-const helpers = [`${__dirname}/helpers.js`];
+runTests(specFiles);
-runTests(specFiles, helpers);