iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: changes to `packages/common/http` should not require `fw-common` approval (#41887) 

Currently when the change is made to the code inside the `packages/common/http` folder, both `fw-http` and `fw-common` group members are assigned for review. However only `fw-http` is required and should be sufficient. This commit updates the PullApprove config to exclude `packages/common/http` path from the list of folders that `fw-common` "owns".

PR Close #41887
This commit is contained in:
Andrew Kushnir 2021-04-29 12:11:43 -07:00 committed by Misko Hevery
parent ca0fcd6c08
commit e53c80c7ca
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pullapprove.yml
View File

@ -444,7 +444,7 @@ groups:
- *can-be-global-approved - *can-be-global-approved
- *can-be-global-docs-approved - *can-be-global-docs-approved
- > - >
contains_any_globs(files.exclude("packages/core/schematics/**"), [ contains_any_globs(files.exclude("packages/core/schematics/**").exclude("packages/common/http/**"), [
'packages/common/**', 'packages/common/**',
'packages/examples/common/**', 'packages/examples/common/**',
]) ])