From e618032d53314545ba38b038da91d7fef2879765 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matias=20Niemel=C3=A4?= Date: Wed, 7 Nov 2018 13:03:11 -0800 Subject: [PATCH] feat(ivy): introduce `getPlayers()` to global utils (#27008) PR Close #27008 --- packages/core/src/core_render3_private_export.ts | 2 +- packages/core/src/render3/component.ts | 2 +- .../render3/{publish_global_util.ts => global_utils.ts} | 2 ++ .../{dev_mode_publish_spec.ts => global_utils_spec.ts} | 9 ++++++--- 4 files changed, 10 insertions(+), 5 deletions(-) rename packages/core/src/render3/{publish_global_util.ts => global_utils.ts} (95%) rename packages/core/test/render3/{dev_mode_publish_spec.ts => global_utils_spec.ts} (87%) diff --git a/packages/core/src/core_render3_private_export.ts b/packages/core/src/core_render3_private_export.ts index 720f51215b..dc7ef34146 100644 --- a/packages/core/src/core_render3_private_export.ts +++ b/packages/core/src/core_render3_private_export.ts @@ -230,7 +230,7 @@ export { export { publishGlobalUtil as ɵpublishGlobalUtil, publishDefaultGlobalUtils as ɵpublishDefaultGlobalUtils -} from './render3/publish_global_util'; +} from './render3/global_utils'; export { SWITCH_INJECTOR_FACTORY__POST_R3__ as ɵSWITCH_INJECTOR_FACTORY__POST_R3__, } from './di/injector'; diff --git a/packages/core/src/render3/component.ts b/packages/core/src/render3/component.ts index 02b08e98e3..3f879bb545 100644 --- a/packages/core/src/render3/component.ts +++ b/packages/core/src/render3/component.ts @@ -16,6 +16,7 @@ import {assertComponentType, assertDefined} from './assert'; import {getComponentViewByInstance} from './context_discovery'; import {getComponentDef} from './definition'; import {diPublicInInjector, getOrCreateNodeInjectorForNode} from './di'; +import {publishDefaultGlobalUtils} from './global_utils'; import {queueInitHooks, queueLifecycleHooks} from './hooks'; import {CLEAN_PROMISE, createLViewData, createNodeAtIndex, createTView, getOrCreateTView, initNodeFlags, instantiateRootComponent, locateHostElement, prefillHostVars, queueComponentIndexForCheck, refreshDescendantViews} from './instructions'; import {ComponentDef, ComponentType} from './interfaces/definition'; @@ -23,7 +24,6 @@ import {TElementNode, TNodeFlags, TNodeType} from './interfaces/node'; import {PlayerHandler} from './interfaces/player'; import {RElement, Renderer3, RendererFactory3, domRendererFactory3} from './interfaces/renderer'; import {CONTEXT, HEADER_OFFSET, HOST, HOST_NODE, INJECTOR, LViewData, LViewFlags, RootContext, RootContextFlags, TVIEW} from './interfaces/view'; -import {publishDefaultGlobalUtils} from './publish_global_util'; import {enterView, leaveView, resetComponentState} from './state'; import {defaultScheduler, getRootView, readElementValue, readPatchedLViewData, stringify} from './util'; diff --git a/packages/core/src/render3/publish_global_util.ts b/packages/core/src/render3/global_utils.ts similarity index 95% rename from packages/core/src/render3/publish_global_util.ts rename to packages/core/src/render3/global_utils.ts index a48a429b09..25c14c2116 100644 --- a/packages/core/src/render3/publish_global_util.ts +++ b/packages/core/src/render3/global_utils.ts @@ -7,6 +7,7 @@ */ import {global} from '../util'; import {getComponent, getDirectives, getHostComponent, getInjector, getRootComponents} from './discovery_utils'; +import {getPlayers} from './players'; /** * This file introduces series of globally accessible debug tools @@ -41,6 +42,7 @@ export function publishDefaultGlobalUtils() { publishGlobalUtil('getInjector', getInjector); publishGlobalUtil('getRootComponents', getRootComponents); publishGlobalUtil('getDirectives', getDirectives); + publishGlobalUtil('getPlayers', getPlayers); } } diff --git a/packages/core/test/render3/dev_mode_publish_spec.ts b/packages/core/test/render3/global_utils_spec.ts similarity index 87% rename from packages/core/test/render3/dev_mode_publish_spec.ts rename to packages/core/test/render3/global_utils_spec.ts index 38e450e581..06ef793a22 100644 --- a/packages/core/test/render3/dev_mode_publish_spec.ts +++ b/packages/core/test/render3/global_utils_spec.ts @@ -6,11 +6,12 @@ * found in the LICENSE file at https://angular.io/license */ import {getComponent, getDirectives, getHostComponent, getInjector, getRootComponents} from '../../src/render3/discovery_utils'; -import {GLOBAL_PUBLISH_EXPANDO_KEY, GlobalDevModeContainer, publishDefaultGlobalUtils, publishGlobalUtil} from '../../src/render3/publish_global_util'; +import {GLOBAL_PUBLISH_EXPANDO_KEY, GlobalDevModeContainer, publishDefaultGlobalUtils, publishGlobalUtil} from '../../src/render3/global_utils'; import {global} from '../../src/util'; +import {getPlayers} from '../../src/render3/players'; -describe('dev mode utils', () => { - describe('devModePublish', () => { +describe('global utils', () => { + describe('publishGlobalUtil', () => { it('should publish a function to the window', () => { const w = global as any as GlobalDevModeContainer; expect(w[GLOBAL_PUBLISH_EXPANDO_KEY]['foo']).toBeFalsy(); @@ -34,6 +35,8 @@ describe('dev mode utils', () => { () => { assertPublished('getHostComponent', getHostComponent); }); it('should publish getInjector', () => { assertPublished('getInjector', getInjector); }); + + it('should publish getPlayers', () => { assertPublished('getPlayers', getPlayers); }); }); });