iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(compiler-cli): Add test for checkTypeOfDomReferences = false (#39539)

Browse Source 
Add test for when `checkTypeOfDomReferences = false` to ensure that we
do not regress in behavior at any point. The desired behavior for this
case is that the `TemplateTypeChecker` will honor the user's
configuration and not produce symbols for the dom reference.

PR Close #39539
This commit is contained in:
Andrew Scott 2020-11-02 11:01:49 -08:00 committed by Misko Hevery
parent 7901ebafa0
commit e92d8a8e8f
1 changed files with 46 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
packages/compiler-cli/src/ngtsc/typecheck/test/type_checker__get_symbol_of_template_node_spec.ts
View File

@ -539,31 +539,57 @@ runInEachFileSystem(() => {
expect(program.getTypeChecker().typeToString(bSymbol.tsType)).toEqual('number'); expect(program.getTypeChecker().typeToString(bSymbol.tsType)).toEqual('number');
}); });
it('should get symbol for local reference of an Element', () => { describe('local reference of an Element', () => {
const fileName = absoluteFrom('/main.ts'); it('checkTypeOfDomReferences = true', () => {
const {templateTypeChecker, program} = setup([ const fileName = absoluteFrom('/main.ts');
{ const {templateTypeChecker, program} = setup([
fileName, {
templates: { fileName,
'Cmp': ` templates: {
'Cmp': `
<input #myRef> <input #myRef>
<div [input]="myRef"></div>` <div [input]="myRef"></div>`
},
}, },
}, ]);
]); const sf = getSourceFileOrError(program, fileName);
const sf = getSourceFileOrError(program, fileName); const cmp = getClass(sf, 'Cmp');
const cmp = getClass(sf, 'Cmp'); const nodes = getAstElements(templateTypeChecker, cmp);
const nodes = getAstElements(templateTypeChecker, cmp);
const refSymbol = templateTypeChecker.getSymbolOfNode(nodes[0].references[0], cmp)!; const refSymbol = templateTypeChecker.getSymbolOfNode(nodes[0].references[0], cmp)!;
assertReferenceSymbol(refSymbol); assertReferenceSymbol(refSymbol);
expect((refSymbol.target as TmplAstElement).name).toEqual('input'); expect((refSymbol.target as TmplAstElement).name).toEqual('input');
expect((refSymbol.declaration as TmplAstReference).name).toEqual('myRef'); expect((refSymbol.declaration as TmplAstReference).name).toEqual('myRef');
const myRefUsage = templateTypeChecker.getSymbolOfNode(nodes[1].inputs[0].value, cmp)!; const myRefUsage = templateTypeChecker.getSymbolOfNode(nodes[1].inputs[0].value, cmp)!;
assertReferenceSymbol(myRefUsage); assertReferenceSymbol(myRefUsage);
expect((myRefUsage.target as TmplAstElement).name).toEqual('input'); expect((myRefUsage.target as TmplAstElement).name).toEqual('input');
expect((myRefUsage.declaration as TmplAstReference).name).toEqual('myRef'); expect((myRefUsage.declaration as TmplAstReference).name).toEqual('myRef');
});
it('checkTypeOfDomReferences = false', () => {
const fileName = absoluteFrom('/main.ts');
const {templateTypeChecker, program} = setup(
[
{
fileName,
templates: {
'Cmp': `
<input #myRef>
<div [input]="myRef"></div>`
},
},
],
{checkTypeOfDomReferences: false});
const sf = getSourceFileOrError(program, fileName);
const cmp = getClass(sf, 'Cmp');
const nodes = getAstElements(templateTypeChecker, cmp);
const refSymbol = templateTypeChecker.getSymbolOfNode(nodes[0].references[0], cmp);
// Our desired behavior here is to honor the user's compiler settings and not produce a
// symbol for the reference when `checkTypeOfDomReferences` is false.
expect(refSymbol).toBeNull();
});
}); });
it('should get symbols for references which refer to directives', () => { it('should get symbols for references which refer to directives', () => {