From ea70d41ac2314cdfc58688b488f85108466e5f92 Mon Sep 17 00:00:00 2001 From: Filipe Silva Date: Sat, 13 Apr 2019 15:29:48 +0100 Subject: [PATCH] test: ensure correct TS version before running postinstall (#29885) The bazel-schematics test could suffer from a version skew where new CLI projects were not yet using a new TS version, but Angular packages already were. This caused the the `ngc` call in the added `postinstall` to run and fail: https://circleci.com/gh/angular/angular/283109 PR Close #29885 --- integration/bazel-schematics/test.sh | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/integration/bazel-schematics/test.sh b/integration/bazel-schematics/test.sh index 0b55efbe34..8245e399c4 100755 --- a/integration/bazel-schematics/test.sh +++ b/integration/bazel-schematics/test.sh @@ -26,11 +26,8 @@ function testBazel() { # Create project ng new demo --collection=@angular/bazel --routing --skip-git --skip-install --style=scss cd demo - # Do an initial install to ensure packages like node-sass are built. - yarn # Force more recent TS version until new Angular CLI projects also use it. - # --ignore-scripts is necessary because there is a postinstall script that uses ngc. - yarn add typescript@3.4.2 --dev --ignore-scripts + yarn add typescript@3.4.2 --dev installLocalPackages yarn webdriver-manager update --gecko=false --standalone=false ${CI_CHROMEDRIVER_VERSION_ARG:---versions.chrome 2.45} ng generate component widget --style=css