From eba185edc830ba223747487cb63ce06c3da5d75e Mon Sep 17 00:00:00 2001
From: George Kalpakas <kalpakas.g@gmail.com>
Date: Mon, 30 Nov 2020 13:59:13 +0200
Subject: [PATCH] test(docs-infra): reduce ambiguity in `deploy-to-firebase.js`
 test descriptions (#39853)

Previously, test descriptions used `latest` to refer to the most
recent/highest version. This was ambiguous, because `latest` can also
refer to the stable version of a package (e.g. see `@latest` npm tag).

This commit replaces `latest` with `highest` (or `highest for major`) to
reduce ambiguity.

Discussed in:
https://github.com/angular/angular/pull/39853#discussion_r531730317

PR Close #39853
---
 aio/scripts/deploy-to-firebase.spec.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/aio/scripts/deploy-to-firebase.spec.js b/aio/scripts/deploy-to-firebase.spec.js
index c434f8b0a2..42467f2ddd 100644
--- a/aio/scripts/deploy-to-firebase.spec.js
+++ b/aio/scripts/deploy-to-firebase.spec.js
@@ -231,7 +231,7 @@ describe('deploy-to-firebase:', () => {
     ]);
   });
 
-  it('archive - skip deploy - major same as stable, minor less than stable', () => {
+  it('archive - skip deploy - major same as stable, minor lower than stable', () => {
     expect(getDeploymentsInfoFor({
       CI_REPO_OWNER: 'angular',
       CI_REPO_NAME: 'angular',
@@ -249,7 +249,7 @@ describe('deploy-to-firebase:', () => {
     ]);
   });
 
-  it('archive - skip deploy - major lower than stable, minor not latest', () => {
+  it('archive - skip deploy - major lower than stable, minor not highest for major', () => {
     expect(getDeploymentsInfoFor({
       CI_REPO_OWNER: 'angular',
       CI_REPO_NAME: 'angular',
@@ -287,7 +287,7 @@ describe('deploy-to-firebase:', () => {
     ]);
   });
 
-  it('rc - deploy success - major same as stable, minor higher', () => {
+  it('rc - deploy success - major same as stable, minor highest for major', () => {
     // Create a stable branch name that has the same major and lower minor than
     // `mostRecentMinorBranch`.
     // NOTE: Since `mostRecentMinorBranch` can have a minor version of `0`, we may end up with `-1`
@@ -332,7 +332,7 @@ describe('deploy-to-firebase:', () => {
     ]);
   });
 
-  it('rc - skip deploy - major same as stable, minor not latest', () => {
+  it('rc - skip deploy - major same as stable, minor not highest for major', () => {
     expect(getDeploymentsInfoFor({
       CI_REPO_OWNER: 'angular',
       CI_REPO_NAME: 'angular',
@@ -350,7 +350,7 @@ describe('deploy-to-firebase:', () => {
     ]);
   });
 
-  it('rc - skip deploy - major higher than stable, minor not latest', () => {
+  it('rc - skip deploy - major higher than stable, minor not highest for major', () => {
     expect(getDeploymentsInfoFor({
       CI_REPO_OWNER: 'angular',
       CI_REPO_NAME: 'angular',
@@ -368,7 +368,7 @@ describe('deploy-to-firebase:', () => {
     ]);
   });
 
-  it('rc - skip deploy - major higher than stable but lower than most recent, minor latest', () => {
+  it('rc - skip deploy - major higher than stable but not highest, minor highest for major', () => {
     expect(getDeploymentsInfoFor({
       CI_REPO_OWNER: 'angular',
       CI_REPO_NAME: 'angular',