build: remove compile build variable (#34280)

Remove the remaining check for compile build variable in the ng_module
rule.  Now that components is no longer relying on this build variable
we can safely remove it from our repository.

We will leave the remaining check for if the compile build variable is
used within our own repo, with plans to remove it in a couple months.
It is being kept in place to ensure that uncommitted local scripts for
our own development that we have locally, kill error as expected if
they still reference the compile build variable.

PR Close #34280
This commit is contained in:
Joey Perrott 2019-12-06 09:56:36 -08:00 committed by Andrew Kushnir
parent 89ef77f750
commit f72de51a6f
1 changed files with 2 additions and 7 deletions

View File

@ -35,6 +35,8 @@ def is_ivy_enabled(ctx):
Returns:
Boolean, Whether the ivy compiler should be used.
"""
# TODO(josephperott): Remove after ~Feb 2020, to allow local script migrations
if "compile" in ctx.var and ctx.workspace_name == "angular":
fail(
msg = "Setting ViewEngine/Ivy using --define=compile is deprecated, please use " +
@ -47,13 +49,6 @@ def is_ivy_enabled(ctx):
if hasattr(ctx.attr, "ivy") and ctx.attr.ivy == True:
return True
# TODO(josephperrott): Remove configuration via compile=aot define flag.
if ctx.var.get("compile", None) == "aot":
# buildifier: disable=print
print("Setting ViewEngine/Ivy using the compile build variable (--define=compile=*) " +
"is deprecated, please use the --define=angular_ivy_enabled=True instead.")
return True
if ctx.var.get("angular_ivy_enabled", None) == "True":
return True