iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(service-worker): remove work-around for Chrome code highlighting bug (#40234)

Browse Source 
Chrome debugger code highlighting bug [659515][1] has been fixed, so we
can remove the work-around.
(See #38332 for more details on the work-around.)

[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=659515

PR Close #40234
This commit is contained in:
George Kalpakas 2021-01-08 14:07:01 +02:00 committed by atscott
parent 5e0dbe314b
commit f8aad11866
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/service-worker/worker/src/driver.ts
View File

@ -720,12 +720,7 @@ export class Driver implements Debuggable, UpdateSource {
private async deleteAllCaches(): Promise<void> { private async deleteAllCaches(): Promise<void> {
const cacheNames = await this.scope.caches.keys(); const cacheNames = await this.scope.caches.keys();
const ownCacheNames = const ownCacheNames =
cacheNames cacheNames.filter(name => name.startsWith(`${this.adapter.cacheNamePrefix}:`));
// The Chrome debugger is not able to render the syntax properly when the
// code contains backticks. This is a known issue in Chrome and they have an
// open [issue](https://bugs.chromium.org/p/chromium/issues/detail?id=659515) for that.
// As a work-around for the time being, we can use \\ ` at the end of the line.
.filter(name => name.startsWith(`${this.adapter.cacheNamePrefix}:`)); // `
await Promise.all(ownCacheNames.map(name => this.scope.caches.delete(name))); await Promise.all(ownCacheNames.map(name => this.scope.caches.delete(name)));
} }