iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,842 Commits 5 Branches 1 Tag 142 MiB
Commit Graph

64 Commits

Author SHA1 Message Date
Joey Perrott 296dc0622f ci: Migrate from CODEOWNERS to PullApprove for PR review management (#34814) 
We are migrating to PullApprove for our PR review management in an attempt
to allow for more granular and equitable code review assignments across the
team.  Currently this migration is equivalent in the review assignments
it will create. Once stable, our expectation is that we will be able to
take advantage of PullApproves additional features for things like staged
reviews.

PR Close #34814
 2020-01-28 09:19:34 -08:00
Igor Minar 224d78765f ci: replace our pullapprove setup with GitHub CODEOWNERS (#27690) 
Summary of changes:
- created .github/CODEOWNERS with docs and config similar to the one in .pullapprove.yml
- updated docs
- updated .github/angular-robot.yml to not expect pullapprove status
- removed .pullapprove.yml

The primary motivations behind this change are:
- CODEOWNERS didn't exist when we introduced pullapprove
- CODEOWNERS is a functionality tightly integrated with github which results in better DX
- pullapprove v2 has been very unstable recently causing productivity loss
- pullapprove v2 has been deprecated in favor of v3, which requires and migration

PR Close #27690
 2019-01-05 17:39:00 -08:00
Igor Minar e3180818b0 ci: remove packages/bazel from compiler-cli group (#27641) 
it doesn't make sense require approvals from compiler-cli group for most @angular/bazel changes.

PR Close #27641
 2018-12-13 10:58:58 -08:00
Kara Erickson cdf5cacdc0 build: add kara to more approval lists (#27493) 
PR Close #27493
 2018-12-05 14:41:50 -08:00
Kara Erickson 653eb5949d build: add kara to approvers for packages needing ivy TestBed updates (#27337) 
PR Close #27337
 2018-11-29 21:22:24 -08:00
Igor Minar b9eeb1c383 ci: exclude symbol golden files from build-and-ci pullapprove group (#27004) 
these files are test data and note test infrastructure, so they don't belong to this group.

this means that the core group can now approve the golden symbol changes

PR Close #27004
 2018-11-08 13:10:53 -08:00
Alex Eagle 30d6233e83 build: update ngcontainer to bazel 0.18.0 (#26465) (#26488) 
* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory

PR Close #26488
 2018-10-19 20:59:29 -07:00
Kara Erickson 1a666dea61 ci: add forms-overview guide to forms approval list (#26549) 
PR Close #26549
 2018-10-18 12:01:15 -07:00
Miško Hevery 0fe708ff82 ci: remove `vicb` from `pullapprove.yml` (#25702) 
PR Close #25702
 2018-08-28 11:15:53 -07:00
Igor Minar 3d7f555044 ci: update pullapprove groups and add docs (#25257) 
With this update to permissions the docs team can easily identify the technical reviewer for a particular doc, which should streamline the reviews.

I also added Jennifer into all groups that contain docs, so that she can approve changes that contain only editorial changes.

Closes #21692

PR Close #25257
 2018-08-01 15:53:41 -07:00
Victor Berchet 2aab1c9dd6 ci: remove Tina from pullaprove (#25006) 
She has been removed as a collaborator to the project and pullaprove rejects
this config file which still lists her name.

PR Close #25006
 2018-07-20 10:25:52 -07:00
Alex Eagle 971e78dc35 ci: Remove Chuck from pullapprove (#23798) 
Jason takes over his role on core, Keen for everything else

PR Close #23798
 2018-05-09 11:41:58 -07:00
Brandon Roberts 84b4593d01 ci: add Brandon Roberts as an aio approver (#23417) 
PR Close #23417
 2018-04-27 07:17:04 -07:00
Alex Rickabaugh 999ab0a690 ci: add alxhub as owner to a few packages (#23510) 
PR Close #23510
 2018-04-23 10:08:25 -07:00
Alex Rickabaugh f2563ca800 ci(compiler): replace chuckjaz with alxhub as compiler owner (#23456) 
PR Close #23456
 2018-04-19 16:32:31 -07:00
Rob Wormald b8f4e433d5 build: add robwormald to pullapprove (#23002) 
PR Close #23002
 2018-04-12 22:36:12 -07:00
Andrew Seguin 22b96b9690 feat(elements): add support for creating custom elements (#22413) 
PR Close #22413
 2018-03-16 12:39:07 -07:00
Alex Eagle 21e44c6ba9 ci: add alexeagle to pullapprove root group (#22724) 
PR Close #22724
 2018-03-12 16:23:58 -07:00
Miško Hevery 0c9ec37e26 ci: mark PRs with rejection as not green (#21922) 
PR Close #21922
 2018-02-05 13:01:11 -08:00
Misko Hevery 52cfe3952a build: add mhevery to bazel approvers (#21314) 
PR Close #21314
 2018-01-17 17:02:22 -08:00
Igor Minar 50ca01e255 ci: update pullapprove rules now that we allow selfapprovals (#21494) 
PR Close #21494
 2018-01-12 10:11:21 -08:00
Kara Erickson 72246d48db ci: update forms approval list to include guides (#21449) 
PR Close #21449
 2018-01-10 12:15:50 -08:00
Alex Eagle 27fc458ef6 build: fix pullapprove (#21140) 
Currently it gives a green status if I edit a file I'm an owner of,
even without anyone else's approval.

PR Close #21140
 2017-12-21 14:04:20 -08:00
Alex Eagle 0487a9f140 build: update pullapprove: (#21117) 
- remove ex-team members
- allow author to approve their own change
- move more bazel files under the bazel group

PR Close #21117
 2017-12-21 13:17:00 -08:00
Alex Rickabaugh e48f477477 ci: temporarily remove wardbell from pullapprove (2FA) 2017-12-18 08:41:44 -08:00
Alex Eagle 981947d104 ci: allow me to approve circleCI changes (#20957) 
Removes the root group from the pullapprove settings for .circleci/*
PR Close #20957
 2017-12-12 11:55:35 -08:00
Igor Minar 75e468494c ci: add IgorMinar to bazel pullapprove group (#20843) 
PR Close #20843
 2017-12-08 10:24:00 -08:00
Olivier Combe 7cf5e95ac9 ci: update pullapprove (#20540) 
PR Close #20540
 2017-11-21 11:49:52 -06:00
Igor Minar 3997d97806 revert: feat(elements): implement `@angular/elements` #19469 (#20152) 
This PR was merged without API docs and general rollout plan.

We can't release this as is in 5.1 without a plan for documentation, cli integration, etc.
 2017-11-03 15:54:54 -07:00
George Kalpakas ebfa204af0 feat(elements): set up the `elements` package 2017-11-02 16:09:09 -07:00
Filipe Silva 14380ff086 build: add warning about changing ngtools_api2 2017-10-20 09:39:30 -07:00
Matias Niemelä 507290d30d build: fix broken path for animations in .pullapprove (#19453) 
PR Close #19453
 2017-10-17 10:45:10 -07:00
Olivier Combe 2e45267705 ci: add service-worker to pullapprove (#19642) 
PR Close #19642
 2017-10-13 09:15:59 -07:00
Alex Eagle 5406a49f06 docs: add 'bazel' as an Angular component (#19346) 2017-09-28 09:28:42 -07:00
George Kalpakas c6adddf02e ci: update pullapprove `http` files (#19221) 
PR Close #19221
 2017-09-22 13:09:50 -07:00
Chuck Jazdzewski f96142cd7c build: remove references to `tsc-wrapped` (#19298) 
With this commit `ngc` is used instead of `tsc-wrapped` for
collecting metadata and tsickle rewriting and `tsc-wrapped`
is removed from the repository.

`@angular/tsc-wrapped@5` is now deprecated and is no longer
used, updated, or maintained as part as of Angular 5.x.x.

`@angular/tsc-wrapped@4` is still maintained and required by
Angular 4.x.x and will be maintained as long as 4.x.x is in
LTS.

PR Close #19298
 2017-09-21 13:55:52 -07:00
Alex Eagle 9ffa490d3f refactor(compiler-cli): move ngc-wrapped to packages/bazel (#18733) 
See design: https://goo.gl/rAeYWx

PR Close #18733
 2017-08-23 11:34:51 -05:00
Chuck Jazdzewski cae3e6dca0 ci: give ownership of ngc-wrapped to compiler-cli maintainers (#18354) 
PR Close #18354
 2017-07-26 17:55:24 -05:00
Chuck Jazdzewski 619e625ee2 refactor(tsc-wrapped): move tsc-wrapped to the packages directory (#18160) 2017-07-21 12:26:16 -05:00
Peter Bacon Darwin 0bb8423df9 ci: add GK and PBD to aio content and marketing groups 2017-07-17 10:52:34 -07:00
Peter Bacon Darwin e28f097fc2 ci: add aio/content to aio group 
This commit also simplifies the rules for the aio content and marketing groups
 2017-07-11 11:55:09 +01:00
Matias Niemelä f2f61c9cf0 ci: allow chuck to approve animations (#17940) 2017-07-06 11:49:44 -07:00
Igor Minar 6282a86135 ci: add angular.io content related groups to .pullapprove.yaml 2017-07-05 15:26:27 -07:00
Victor Berchet b51697c197 ci: add Chuck to the owners of core (#17892) 2017-07-05 15:10:11 -07:00
Matias Niemelä 02d74cafba ci: update pullapprove to reflect animation ownership 2017-06-05 11:17:24 -07:00
Tobias Bosch 255d7226d1 ci: add vicb as owner to compiler-cli (#16832) 2017-05-23 10:41:23 -06:00
Victor Berchet 91b2e394d5 ci: add jasonaden to the router 2017-04-11 11:16:02 -07:00
Chuck Jazdzewski a9ae4daab2 ci: add tbosch and vicb as approvers of the language service (#15530) 2017-03-27 17:38:43 -07:00
Kara Erickson a805d00256 ci(forms): add tina as secondary for forms (#15262) 
PR Close #15262
 2017-03-20 17:13:52 -05:00
Pete Bacon Darwin 71cd2957f7 ci: add wardbell and gkalpak to aio approvers (#15030) 2017-03-13 09:34:40 -07:00