Alex Rickabaugh
3bcf0cf472
fix(service-worker): PushEvent.data has to be decoded ( #19764 )
...
PushEvent.data is not the data object itself, but an instance representing
the data in wire format, with methods to synchronously decode it to JSON,
ArrayBuffer, etc. NGSW assumes all push data is in JSON format.
PR Close #19764
2017-10-18 11:18:34 -07:00
Alex Rickabaugh
396c2417d9
fix(service-worker): freshness strategy should clone response for cache ( #19764 )
...
When Cache.put() is called with a Response, it consumes the response. If
the Response is used for any other purpose (such as satisfying the
original FetchEvent) it must be cloned first.
A bug exists in the mocks used for SW tests, where this condition is not
validated. The bodies of MockResponses can be utilized repeatedly without
erroring in the same way that a real browser would. This bug is fixed by
this commit, which causes tests for the freshness strategy of data caching
to start failing.
The cause of this failure is a second bug in the data caching code, where
the Response is not cloned prior to being passed to Cache.put(). This is
also fixed.
PR Close #19764
2017-10-18 11:18:34 -07:00
Alex Eagle
56774dfb79
fix(compiler-cli): diagnostics file paths relative to cwd, not tsconfig ( #19748 )
...
PR Close #19748
2017-10-18 11:18:17 -07:00
Matias Niemelä
c0cc6eeca1
test(animations): ensure :enter callbacks fire on container insertion ( #19674 )
...
PR Close #19674
2017-10-18 11:18:08 -07:00
vsavkin
6f2939da62
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-18 11:17:55 -07:00
Jason Aden
7d1abd9adb
build: update to rxjs@5.5.0 ( #19345 )
...
PR Close #19345
2017-10-18 11:17:43 -07:00
Tobias Bosch
b0c7ea8181
Revert "fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )"
...
This reverts commit c569b75249
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:58:41 -07:00
Tobias Bosch
30ecb6e88a
Revert "test(animations): ensure :enter callbacks fire on container insertion ( #19674 )"
...
This reverts commit 41f57affb6
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:57:56 -07:00
Tobias Bosch
8d735da5d8
Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )"
...
This reverts commit 5a9ed2de27
.
As it broke an internal test.
2017-10-18 09:56:59 -07:00
Matias Niemelä
5a9ed2de27
fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )
...
Closes #19100
PR Close #19753
2017-10-17 20:57:57 -07:00
Matias Niemelä
41f57affb6
test(animations): ensure :enter callbacks fire on container insertion ( #19674 )
...
PR Close #19674
2017-10-17 20:57:48 -07:00
vsavkin
c569b75249
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-17 20:57:30 -07:00
Tobias Bosch
ad130d62d8
fix(compiler): add first bazel test for `ng_module` ( #19703 )
...
We were missing quite a bit of test coverage,
this is the start of recreating it.
PR Close #19703
2017-10-17 15:18:31 -07:00
Vohmyanin Sergey Vasilevich
621f87b2bd
fix(service-worker): use posix path resolution for generation of ngsw.json ( #19527 )
...
PR Close #19527
2017-10-17 15:18:17 -07:00
Trotyl
15a8429b96
fix(service-worker): add missing annotation for SwPush ( #19721 )
...
PR Close #19721
2017-10-17 10:38:45 -07:00
Chuck Jazdzewski
60bdcd6f5f
fix(compiler): generate correct imports for type check blocks ( #19582 )
...
Fixes : #19485
PR Close #19582
2017-10-17 10:37:55 -07:00
Matias Niemelä
d035175cdb
fix(animations): ensure inner :leave animations do not remove node when skipped ( #19532 ) ( #19693 )
...
PR Close #19693
2017-10-16 11:13:58 -07:00
Matias Niemelä
f42d317d2f
fix(animations): ensure animateChild() works with all inner leave animations ( #19006 ) ( #19532 ) ( #19693 )
...
PR Close #19693
2017-10-16 11:13:58 -07:00
Vikram Subramanian
405ccc7195
fix(bazel): fix the output directory for extractor to be genfiles/ instead of bin/ ( #19716 )
...
PR Close #19716
2017-10-13 17:31:10 -07:00
Vikram Subramanian
836c889baa
fix(compiler): prepare for future Bazel semantics of += ( #19717 )
...
This is a local mod that was already applied in G3.
PR Close #19717
2017-10-13 16:29:46 -07:00
Casey Schroeder
e81d1fc361
docs(animations): add missing bracket to fadeAnimation
...
Closes #18899
2017-10-13 09:12:36 -07:00
Tobias Bosch
02394d2d80
fix(core): don't refer to `hydration` in docs anymore.
...
Closes #18458
2017-10-13 08:53:44 -07:00
Tobias Bosch
653a211743
Revert "Revert "Revert "perf(compiler): skip type check and emit in bazel in some cases. ( #19646 )"""
...
This reverts commit 6b7cead0c5
.
2017-10-12 16:09:49 -07:00
Chuck Jazdzewski
6b7cead0c5
Revert "Revert "perf(compiler): skip type check and emit in bazel in some cases. ( #19646 )""
...
This reverts commit 94a925a1b0
.
2017-10-12 10:32:21 -07:00
Chuck Jazdzewski
94a925a1b0
Revert "perf(compiler): skip type check and emit in bazel in some cases. ( #19646 )"
...
This reverts commit a22121d65d
.
2017-10-12 10:26:53 -07:00
Tobias Bosch
a22121d65d
perf(compiler): skip type check and emit in bazel in some cases. ( #19646 )
...
If no user files changed:
- only type check the changed generated files
Never emit non changed generated files
- we still calculate them, but don’t send them through
TypeScript to emit them but cache the written files instead.
PR Close #19646
2017-10-11 15:54:02 -07:00
Chuck Jazdzewski
46992b4bda
Revert "fix(animations): ensure animateChild() works with all inner leave animations ( #19006 ) ( #19532 )"
...
This reverts commit 9130505b57
.
2017-10-11 10:51:52 -07:00
Chuck Jazdzewski
d0af45c31a
Revert "fix(animations): ensure inner :leave animations do not remove node when skipped ( #19532 )"
...
This reverts commit ac50bd678e
.
2017-10-11 10:37:12 -07:00
Tobias Bosch
b0befd7376
fix(compiler): `TestBed.overrideProvider` should keep imported `NgModule`s eager ( #19624 )
...
Before, as soon as a user called `TestBed.overrideProvider` for a provider
of a `NgModule` that was imported via `TestBed.configureTestingModule`,
that `NgModule` became lazy.
This commit changes this behavior to keep the `NgModule` eager,
with or without a call to `TestBed.overrideProvider`.
PR Close #19624
2017-10-10 13:51:25 -07:00
Matias Niemelä
ac50bd678e
fix(animations): ensure inner :leave animations do not remove node when skipped ( #19532 )
...
PR Close #19532
2017-10-10 12:41:47 -07:00
Matias Niemelä
9130505b57
fix(animations): ensure animateChild() works with all inner leave animations ( #19006 ) ( #19532 )
...
Closes #18305
PR Close #19532
2017-10-10 12:41:47 -07:00
Tobias Bosch
931cf78057
refactor(compiler): introduce `TestBed.deprecatedOverrideProvider` ( #19558 )
...
This allows use to fix `TestBed.overrideProvider` to keep imported `NgModule`s eager,
while allowing our users to still keep the old semantics until they have fixed their
tests.
PR Close #19558
2017-10-10 10:15:46 -07:00
Tobias Bosch
6ade68cff1
fix(compiler): correctly instantiate eager providers that are used via `Injector.get` ( #19558 )
...
Closes #15501
PR Close #19558
2017-10-10 10:15:46 -07:00
Tobias Bosch
d30ce19231
fix(compiler): correctly calculate the out path on windows ( #19601 )
...
Fixes #19543
PR Close #19601
2017-10-10 10:15:06 -07:00
Chuck Jazdzewski
d7eac7ee56
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit 43c5b638b9
.
2017-10-09 16:38:12 -07:00
Chuck Jazdzewski
d53b96f2a2
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit 6651541230
.
2017-10-09 16:37:31 -07:00
Kapunahele Wong
79deeacbd7
docs(aio): add copy about ngNoForm to NgForm API doc ( #19561 )
...
PR Close #19561
2017-10-09 14:53:49 -07:00
vsavkin
6651541230
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-09 11:45:13 -07:00
vsavkin
43c5b638b9
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-09 11:45:13 -07:00
Matias Niemelä
c3a52697f5
perf(animations): reduce size of bundle by removing AST classes ( #19539 )
...
This CL refactors the animation AST code to make use of interfaces instead of classes. Given that interfaces are not persisted during runtime the removal of classes should nicely cut down on size for the animations-browser bundle.
-- before --
animations-browser.umd.js = 222kb
animations-browser.umd.min.js = 107kb
-- after --
animations-browser.umd.js = 213kb
animations-browser.umd.min.js = 102kb
PR Close #19539
2017-10-09 10:00:48 -07:00
Matias Niemelä
c4704c8abc
fix(animations): properly support boolean-based transitions and state changes ( #19279 )
...
Closes #9396
Closes #12337
PR Close #19279
2017-10-09 10:00:32 -07:00
Chuck Jazdzewski
b1ca5d4ddf
Revert "perf(animations): reduce size of bundle by removing AST classes ( #19539 )"
...
This reverts commit d5c9c5f183
.
2017-10-06 18:16:30 -07:00
Chuck Jazdzewski
9fecd72f44
Revert "test(animations): test to see if triggers get cancelled on removal ( #19532 )"
...
This reverts commit f12e15e682
.
2017-10-06 18:15:26 -07:00
Chuck Jazdzewski
f4480d46b4
Revert "fix(animations): ensure animateChild() works with all inner leave animations ( #19532 )"
...
This reverts commit 1c77cdadaf
.
2017-10-06 18:15:22 -07:00
Chuck Jazdzewski
8e5b582b61
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit b67d574a95
.
2017-10-06 18:15:19 -07:00
Chuck Jazdzewski
0cc87c5ba1
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit fdfa31798b
.
2017-10-06 18:15:16 -07:00
Chuck Jazdzewski
6aa7cc1d96
Revert "fix(animations): properly support boolean-based transitions and state changes ( #19279 )"
...
This reverts commit a8920eb774
.
2017-10-06 18:15:08 -07:00
Matias Niemelä
a8920eb774
fix(animations): properly support boolean-based transitions and state changes ( #19279 )
...
Closes #9396
Closes #12337
PR Close #19279
2017-10-06 15:35:37 -07:00
vsavkin
fdfa31798b
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-06 15:35:25 -07:00
vsavkin
b67d574a95
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-06 15:35:24 -07:00