closes#1807
- e2e tests now also cover the tax calculator.
- Dart app updated to match TS (it had no sales tax calculator).
- TS sample source cleanup (e.g. removed many unnecessary `docregions`).
- Prose updated to include @kwalrath's revisions from a while ago, Ward's comments, and
some of my edits as well.
Contributes to #1598 and #1508.
closes#1832
The shred map (xref) builder was issuing warnings. This fix includes
- Adjustments to the shredder map builder itself so that it
understands, e.g., app-project relative example paths.
- `**/guide/glossary.jade` now (Jade) `includes` the shared parent
`glossary.jade` rather than (Harp) importing (via `partial`). This
fixes `makeExample` path issues in the glossary.
- Adjusted some `makeExample` paths that were ok for site build, but
confused the xref tool.
* docs(displaying-data/dart): proofread
- Dart prose simplified by removing discussion of "additions to
pubspec.yaml" which are no longer necessary given the current state of
QuickStart.
- E2e suites passed:
public/docs/_examples/displaying-data/dart
public/docs/_examples/displaying-data/ts
Contributes to #1598 and #1508.
* docs(displaying-data/ts): proofread
- TS prose updated to include @kwalrath's revisions from a while ago,
with some of my edits as well.
- E2e suites passed:
public/docs/_examples/displaying-data/dart
public/docs/_examples/displaying-data/ts
* docs(displaying-data/ts): post-review edits
closes#1818
Previously, the markdown of some chapters was converted to Jade markup
to support the conditional exclusion of TS prose parts in Dart
chapters. This commit reverts some of that back to clean markdown,
thanks to a few custom directives.
- Renamed `angular2_getting_started` to `angular2_quickstart` (to match
TS).
- s/-/_/g in project names elsewhere (only toh-5 & -6 needed to be
updated).
Fixes#378.
- App now shows how Angular handles untrusted URLs and resources
- E2e test covered new functionality
- Copyedits to prose
- Updated provider expressions to use latest syntax
The original security feature tracker:
https://github.com/angular/angular/issues/8511
The new router once required TS1.9 but it doesn't anymore. It's best to revert our examples to TS 1.8 since that is what we tell users to install, and we want to be testing on the current setup.
Originally the dashboard TS expression ``heroes.slice(1, 5))` had been
written as:
> _heroService.getHeroes().getRange(1, 5)
which is brittle; it fails if there are not enough heroes. Slice
doesn't fail; an equivalent express
ion in Dart is
> _heroService.getHeroes().skip(1).take(4)
This is now used.
Other changes:
- Fix in css (missed TS-side update).
- Ran `dartfmt` on `heroes_component.dart`.
Mainly Dart-side review, following #1654:
- Updates to follow style guide
- Enabled e2e tests
- Fixes to ensure tests pass: in after_view_component.dart and
after_content_component.dart
- Changed test over comment field in template to be:
*ngIf="comment.isNotEmpty"
- Suites passed:
public/docs/_examples/lifecycle-hooks/dart
public/docs/_examples/lifecycle-hooks/ts
* docs(toh-6/dart): first edition of prose and example code
NOTE: this PR depends on #1686.
Dart prose and example match TS except that:
- No child-to-parent event emission occurs.
- Support for Add Hero is added as an unconditional feature of the
Heroes view.
- http `_post` takes only a name
- http `delete` takes only a hero id.
- The Dart in-memory-data-service has been dropped in favor of an
implementation based on the "standard" `http.testing.MockClient` class.
* post-review changes
Foxandxss
Patrice Chalin
Brandon Roberts
Ward Bell
Patrice Chalin
Christos Koutsiaris
eltronix
Stephen Fox
Naomi Black
Filipe Silva
Zhimin YE (Rex)
Karan Gandhi
priestch
Fabriece Sumuni