Misko Hevery
40dfe39e64
build(router): enable bazel tests for router ( #21053 )
...
Bazel runs on newer version of RxJs than is installed in Yarn. The never version subclasses `EmptyError` in a different way which fails the `instanceof` check. This change makes the `instanceof` check more robust with respect to `EmptyError`.
PR Close #21053
2017-12-22 13:10:51 -08:00
Misko Hevery
3d50fd7cac
build: add bazel test rules for remainder of packages ( #21053 )
...
PR Close #21053
2017-12-22 13:10:51 -08:00
Jason Aden
5ba1cf1063
fix(router): fix wildcard route with lazy loaded module (again) ( #18139 )
...
Closes #13848
Description:
We doesn't handle children of wildcard route properly link. It's always an empty array.
Created from #13851
PR Close #18139
2017-12-22 09:20:11 -08:00
Zaven Muradyan
5efea2f6a0
feat(router): add "paramsInheritanceStrategy" router configuration option
...
Previously, the router would merge path and matrix params, as well as
data/resolve, with special rules (only merging down when the route has
an empty path, or is component-less). This change adds an extra option
"paramsInheritanceStrategy" which, when set to 'always', makes child
routes unconditionally inherit params from parent routes.
Closes #20572 .
2017-12-20 10:06:24 -08:00
Alex Rickabaugh
e4c53f8529
Revert "feat(router): add a function set up router sync when used with downgradeModule"
...
This reverts commit f5bb999319
. The commit
does not include proper tests.
2017-12-20 09:15:15 -08:00
Alex Rickabaugh
b61e3e9d20
Revert "fix(router): replaceURL when reacting to a change coming from angularjs"
...
This reverts commit 0b2d636b75
. The commit
does not include proper tests.
2017-12-20 09:14:27 -08:00
vsavkin
0b2d636b75
fix(router): replaceURL when reacting to a change coming from angularjs
...
Closes : #20549
2017-12-15 07:59:56 -08:00
vsavkin
f5bb999319
feat(router): add a function set up router sync when used with downgradeModule
2017-12-15 07:59:56 -08:00
Yuan Gao
e544742156
refactor(core): Removed readonly getters and changed to readonly ( #19842 )
...
variables
PR Close #19842
2017-12-08 10:24:19 -08:00
vsavkin
d8cc09b76c
fix(router): NavigatonError and NavigationCancel should be emitted after resetting the URL ( #20803 )
...
PR Close #20803
2017-12-07 13:34:20 -08:00
Alex Eagle
ef534c0cc1
build: upgrade bazel rules to latest ( #20768 )
...
Add enough BUILD files to make it possible to
`bazel build packages/core/test`
Also re-format BUILD.bazel files with Buildifier.
Add a CI lint check that they stay formatted.
PR Close #20768
2017-12-07 11:27:50 -08:00
Alex Eagle
5ec1717c58
fix: Update test code to type-check under TS 2.5 ( #20175 )
...
PR Close #20175
2017-11-15 18:12:16 -06:00
Mark Kennedy
a622e19df6
fix(router): 'merge' queryParamHandling strategy should be able to remove query params ( #19733 )
...
Closes #18463 , #17202
PR Close #19733
2017-11-14 11:01:04 -08:00
George Kalpakas
901436e46f
docs: fix link texts
...
Fixes #19701
PR Close #19709
2017-11-01 15:44:59 -04:00
Hans Larsen
13f8648a00
fix: add missing globals from each rollup configuration ( #20028 )
...
PR Close #20028
2017-10-30 23:09:17 -04:00
Hans Larsen
b6abcb2500
refactor: make all rollup config ES5 compatible ( #20028 )
...
So they can be required by other Node scripts.
PR Close #20028
2017-10-30 23:09:17 -04:00
vsavkin
d3211a2468
feat(router): add "onSameUrlNavigation" router configuration option ( #19463 )
...
PR Close #19463
2017-10-23 20:56:53 -04:00
vsavkin
adab4f3e49
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-23 20:56:52 -04:00
vsavkin
82fed62af2
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-23 20:56:52 -04:00
vsavkin
6f2939da62
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-18 11:17:55 -07:00
Jason Aden
7d1abd9adb
build: update to rxjs@5.5.0 ( #19345 )
...
PR Close #19345
2017-10-18 11:17:43 -07:00
Tobias Bosch
b0c7ea8181
Revert "fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )"
...
This reverts commit c569b75249
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:58:41 -07:00
vsavkin
c569b75249
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-17 20:57:30 -07:00
Chuck Jazdzewski
d7eac7ee56
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit 43c5b638b9
.
2017-10-09 16:38:12 -07:00
Chuck Jazdzewski
d53b96f2a2
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit 6651541230
.
2017-10-09 16:37:31 -07:00
vsavkin
6651541230
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-09 11:45:13 -07:00
vsavkin
43c5b638b9
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-09 11:45:13 -07:00
Chuck Jazdzewski
8e5b582b61
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit b67d574a95
.
2017-10-06 18:15:19 -07:00
Chuck Jazdzewski
0cc87c5ba1
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit fdfa31798b
.
2017-10-06 18:15:16 -07:00
vsavkin
fdfa31798b
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-06 15:35:25 -07:00
vsavkin
b67d574a95
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-06 15:35:24 -07:00
Victor Berchet
6a9ce67714
Revert "refactor(core): Removed readonly getters and changed to readonly ( #19225 )"
...
This reverts commit 2b84b86fc0
.
2017-09-28 13:36:44 -07:00
Victor Savkin
a9d32a3f89
fix(router): resolve and guards should be able to reject with null and undefined ( #19418 )
...
Closes #17148
2017-09-28 11:06:08 -07:00
tinayuangao
2b84b86fc0
refactor(core): Removed readonly getters and changed to readonly ( #19225 )
...
variables
2017-09-28 09:36:29 -07:00
Alex Eagle
82e49230ff
build: Give names to the AMD modules nested in Angular UMD distro ( #19425 )
2017-09-28 09:29:22 -07:00
Olivier Combe
0f5c70d563
build: update npm dependencies ( #19328 )
...
PR Close #19328
2017-09-22 13:20:52 -07:00
Chuck Jazdzewski
f96142cd7c
build: remove references to `tsc-wrapped` ( #19298 )
...
With this commit `ngc` is used instead of `tsc-wrapped` for
collecting metadata and tsickle rewriting and `tsc-wrapped`
is removed from the repository.
`@angular/tsc-wrapped@5` is now deprecated and is no longer
used, updated, or maintained as part as of Angular 5.x.x.
`@angular/tsc-wrapped@4` is still maintained and required by
Angular 4.x.x and will be maintained as long as 4.x.x is in
LTS.
PR Close #19298
2017-09-21 13:55:52 -07:00
cexbrayat
2c4107c531
fix(router): fix activation events toString and docs ( #19147 )
...
PR Close #19147
2017-09-20 13:52:21 -07:00
Yuan Gao
549f2254b4
refactor(core): remove getters for packages/animations, language-service, platform-browser, router ( #19151 )
...
PR Close #19151
2017-09-20 12:38:37 -07:00
Jason Aden
15e8d50313
build: roll up to named .js files rather than 'index.js' ( #19190 )
...
PR Close #19190
2017-09-19 16:59:18 -07:00
Olivier Combe
a9ef858359
refactor(router): remove deprecated `RouterOutlet` properties
...
BREAKING CHANGE: `RouterOutlet` properties `locationInjector` and `locationFactoryResolver` have been removed as they were deprecated since v4.
2017-09-08 16:19:32 -04:00
Jason Aden
8f7915022c
feat(router): add ActivationStart/End events
2017-09-08 13:24:26 -04:00
Jason Aden
66f0ab0371
fix(router): adjust ChildActivation events to only fire when the child is actually changing ( #19043 )
...
* The problem was with the `fireChildActivationStart` function. It was taking a `path` param, which was an
array of `ActivatedRouteSnapshot`s. The function was being fired for each piece of the route that was being
activated. This resulted in far too many `ChildActivationStart` events being fired, and being fired on routes
that weren't actually getting activated. This change fires the event only for those routes that are actually
being activated.
fixes #18942
PR Close #19043
2017-09-05 15:46:29 -05:00
Jason Aden
dce36751f5
refactor(router): remove RouteEvent base class ( #19043 )
...
* Introduced with #18407 , `RouteEvents` don't actually have a common constructor. Reverting here to be able to add new functionality to ChildActivation events.
PR Close #19043
2017-09-05 15:46:29 -05:00
Jason Aden
fd701b07f0
build: publish tree of files rather than FESMs ( #18541 )
...
* Remove now unnecessary portions of build.
* Add a compilePackageES5 method to build ES5 from sources
* Rework all package.json and rollup config files to new format
* Remove "extends" from tsconfig-build.json files and fixup compilation roots
PR Close #18541
2017-08-31 15:34:50 -07:00
Miško Hevery
a80ecf6a77
Revert "refactor(router): remove deprecated `initialNavigation` options ( #18781 )"
...
This reverts commit d76761bf01
.
2017-08-22 18:39:06 -05:00
Miško Hevery
7236095f6f
Revert "refactor(router): remove deprecated `RouterOutlet` properties ( #18781 )"
...
This reverts commit d1c4a94bbf
.
2017-08-22 18:38:53 -05:00
Olivier Combe
d1c4a94bbf
refactor(router): remove deprecated `RouterOutlet` properties ( #18781 )
...
BREAKING CHANGE: `RouterOutlet` properties `locationInjector` and `locationFactoryResolver` have been removed as they were deprecated since v4.
PR Close #18781
2017-08-22 16:53:00 -05:00
Olivier Combe
d76761bf01
refactor(router): remove deprecated `initialNavigation` options ( #18781 )
...
BREAKING CHANGE: the values `true`, `false`, `legacy_enabled` and `legacy_disabled` for the router parameter `initialNavigation` have been removed as they were deprecated. Use `enabled` or `disabled` instead.
PR Close #18781
2017-08-22 16:53:00 -05:00
Chuck Jazdzewski
3a227a1f6f
refactor(router): compile router cleanly with TypeScript 2.4 ( #18465 )
2017-08-02 17:32:02 -07:00
Jan Peer Stöcklmair
81cb5bc3a7
docs(router): fix typo ( #18479 )
2017-08-02 17:31:09 -07:00
Jason Aden
49cd8513e4
feat(router): add events tracking activation of individual routes
...
* Adds `ChildActivationStart` and `ChildActivationEnd`
* Adds test to verify the PreActivation phase of routing
2017-08-01 10:44:00 -07:00
Victor Berchet
9479a106bb
build: enable TSLint on the packages folder
2017-07-31 15:47:57 -07:00
Miško Hevery
a7f2468184
Revert "fix(router): should throw when lazy loaded module doesn't define any routes ( #15001 )"
...
This reverts commit 82923a381d
.
2017-07-27 10:53:01 -07:00
Dzmitry Shylovich
086f4aa72c
fix(router): child CanActivate guard should wait for parent to complete ( #18110 )
...
Closes #15670
PR Close #18110
2017-07-26 17:11:22 -05:00
Dzmitry Shylovich
82923a381d
fix(router): should throw when lazy loaded module doesn't define any routes ( #15001 )
...
Closes #14596
PR Close #15001
2017-07-26 17:11:07 -05:00
Lars Gyrup Brink Nielsen
c67bad4f43
docs(router): minor typo ( #18226 )
...
Fix a minor typo in the description of a router spec.
2017-07-20 09:32:34 -07:00
Sam Verschueren
b399cb26d9
fix(router): terminal route in custom matcher
2017-07-18 10:25:18 -07:00
Roy Ling
e20cfe1bbc
fix(router): canDeactivate guards should run from bottom to top
...
Closes #15657 .
2017-07-18 10:04:39 -07:00
Dzmitry Shylovich
eb6fb5f87e
fix(router): should navigate to the same url when config changes
...
Closes #15535
2017-07-18 10:04:11 -07:00
Dzmitry Shylovich
ad3029e786
fix(router): should run resolvers for the same route concurrently
...
Fixes #14279
2017-07-18 10:03:33 -07:00
Yaroslav Admin
df06e8b7a4
fix(router): fix outdated homepage url in NPM package ( #17899 )
2017-07-11 12:00:56 -07:00
Victor Berchet
c723d42d0a
refactor: fix typos ( #18000 )
2017-07-07 16:55:17 -07:00
Jason Aden
ae27af7399
fix(router): encode URLs the same way AngularJS did (closer to spec) ( #17890 )
...
fixes #16067
2017-07-06 17:10:25 -07:00
Igor Minar
578bdeb522
fix(router): export missing UrlMatcher and UrlMatchResult types
...
Fixes #15140
2017-07-05 15:26:27 -07:00
Jason Aden
8a1a989a1c
feat(router): add router-level events for GuardsCheck and Resolve ( #17601 )
2017-07-01 10:30:17 -07:00
Pawel Kozlowski
3165fd3dc9
refactor(router): remove usage of deprecated Renderer
2017-06-23 16:12:43 -07:00
Alex Rickabaugh
c59c390cdc
fix: argument destructuring sometimes breaks strictNullChecks
...
Destructuring of the form:
function foo({a, b}: {a?, b?} = {})
breaks strictNullChecks, due to the TypeScript bug https://github.com/microsoft/typescript/issues/10078 .
This change eliminates usage of destructuring in function argument lists in cases where it would leak
into the public API .d.ts.
2017-06-20 12:56:08 -07:00
Igor Minar
d3c92a307a
fix(router): update the version placeholder so that it gets replaced during the build
...
Fixes #17403
2017-06-19 15:11:06 -07:00
Rafael
7c78282ce8
docs: fix typo in 'Routes' docs
2017-06-05 11:18:43 -07:00
Robert Spier
4c32cb952f
fix(router): opening links in new window
...
Shift-clicks on router-links should not prevent browser default action.
A follow on to:
1ac9dda93d
2017-06-02 17:32:12 -04:00
Chuck Jazdzewski
e5138081ec
build: update router package.json placeholder ( #17060 )
2017-05-30 13:19:54 -07:00
Jason Aden
fa809ec8cf
build: import tslib rather than output TS helpers ( #16901 )
2017-05-23 14:01:39 -06:00
Matias Niemelä
f1a9e3c1bb
feat(animations): introduce routeable animation support
2017-05-19 13:45:22 -07:00
Victor Berchet
5d4f5434fd
refactor(router): don't run the change detection every time an outlet is activated
...
fix(router): inside on push // SQUASH after review
2017-05-19 11:55:15 -07:00
Victor Berchet
81ca51a8f0
refactor(router): cleanup, simplification
2017-05-19 11:55:15 -07:00
Matias Niemelä
86b7bd9c8e
revert: refactor(router): cleanup, simplification
...
This reverts commit 44d48d9d7a
.
2017-05-18 11:57:22 -07:00
Matias Niemelä
a0a6029915
revert: refactor(router): don't run the change detection every time an outlet is activated
...
This reverts commit 198edb3109
.
2017-05-18 11:57:22 -07:00
Victor Berchet
198edb3109
refactor(router): don't run the change detection every time an outlet is activated
2017-05-17 19:32:04 -07:00
Victor Berchet
44d48d9d7a
refactor(router): cleanup, simplification
2017-05-17 19:32:04 -07:00
Victor Berchet
569b1e0eb7
fix(router): Wrap Promise-like instances in native Promises ( #16759 )
...
Hybrid apps (mix of Angular and AngularJS) might return AngularJS implementation
of Promises that do not play well with the change detection. Wrapping them in
native Promises fix this issue.
This could be the case when a Resolver returns a `$q` promise.
2017-05-12 10:03:54 -07:00
Tobias Bosch
ce1d7c4a6e
refactor: use view engine also for `NgModuleFactory`s ( #16658 )
...
* refactor(core): provide error message in stack for reflective DI
Fixes #16355
* fix(compiler): make AOT work with `noUnusedParameters`
Fixes #15532
* refactor: use view engine also for `NgModuleFactory`s
This is a prerequisite for being able to mock providers
in AOTed code later on.
2017-05-11 10:26:02 -07:00
Aaron Hoffman
d28a3f7878
docs(router): Change CanDeactivate to CanLoad ( #16237 )
...
fix mistake in docs. CanDeactivate should be CanLoad
2017-05-10 16:34:34 -07:00
Pete Bacon Darwin
d0e72a8f8f
docs(*) fix dangling links in API docs ( #16632 )
...
* docs(animations): fix links to `Component` animations
* docs(core): fix links to `ReflectiveInjector` methods
The `resolve` and other methods were moved from the
`Injector` to the `ReflectiveInjector`.
* docs(core): fix links to `Renderer`
The local links were assuming that that methods were on the
current document (e.g. `RootRenderer`), but they are actually
on the `Renderer` class.
* docs(router): fix links to methods
* docs(forms): fix links to methods
* docs(core): fix links to methods
* docs(router): fix API page links and an internal link
2017-05-09 15:51:37 -07:00
Victor Berchet
5d4b36f80f
fix(router): fix redirect to a URL with a param having multiple values ( #16376 )
...
fixes #16310
PR Close #16376
2017-05-08 17:50:33 -05:00
Victor Berchet
415a0f8047
test(router): simplify redirect tests ( #16376 )
2017-05-08 17:50:29 -05:00
Igor Minar
71f5b73296
docs: fix links in api docs
2017-05-03 09:22:32 +01:00
Victor Berchet
2f977312be
fix(router): forward the query parameters in the ng1 -> ng2 url sync ( #16249 )
...
fixes #16067
PR Close #16249
2017-04-24 12:13:47 -05:00
Miško Hevery
5293794316
fix: turn on nullability in the code base.
2017-04-18 12:07:33 -07:00
Miško Hevery
a0d124bd91
fix(router): relax nullability requirements
2017-04-18 12:07:33 -07:00
Miško Hevery
bc431888f3
fix(router): Update types for TypeScript nullability support
...
This reverts commit ea8ffc9841
.
2017-04-18 12:07:33 -07:00
Victor Berchet
82417b3ca5
fix(router): prevent `RouterLinkActive` from causing an infinite CD loop
...
fixes #15825
2017-04-17 10:15:44 -07:00
Tobias Bosch
ea8ffc9841
Revert "fix(router): Update types for TypeScript nullability support"
...
This reverts commit 56c46d70f7
.
Broke in G3.
2017-04-17 09:56:09 -07:00
Miško Hevery
56c46d70f7
fix(router): Update types for TypeScript nullability support
2017-04-14 14:31:17 -07:00
Victor Berchet
ea4afebeb9
refactor(router): drop the `InternalRoute` interface
2017-04-14 09:08:13 -07:00
Dzmitry Shylovich
886cca028f
refactor(router): misc refactoring
2017-04-14 09:08:13 -07:00
Victor Berchet
a487563768
fix(router): fix query param parsing
2017-04-11 11:15:11 -07:00
Victor Berchet
0ab04bd62c
refactor(router): cleanup & simplifications
2017-04-11 11:15:11 -07:00
Marc Laval
46ce3317c3
test(router): enable running the campaign in non-ES6 browsers
...
Closes #15806 .
2017-04-10 15:43:42 -07:00
Victor Berchet
83527fd4fb
test(router): test preloading when a module is already loaded
2017-04-10 16:35:47 -06:00