2143 Commits

Author SHA1 Message Date
George Kalpakas
10e414f617 test(docs-infra): fix tests ()
PR Close 
2018-10-08 13:43:31 -07:00
siddhant
0bdea1f69c docs: update docs to reflect the changes in RxJS 6 ()
PR Close 
2018-10-08 13:43:12 -07:00
George Kalpakas
decc0b840d ci(docs-infra): re-use env variable ()
PR Close 
2018-10-08 12:01:02 -07:00
JiaLi.Passion
ccceff5ecc docs: add fakeAsync test new feature document ()
PR Close 
2018-10-05 15:43:37 -07:00
Frederik Schlemmer
6c6bc95ac0 docs: Rename 'QuickStart' into 'Getting Started' ()
Delete symlink

docs: Undo unwanted changes

docs: Rename 'QuickStart' into 'Getting Started'

Revert symlink commit
PR Close 
2018-10-05 15:43:16 -07:00
George Kalpakas
3a5cb1cb11 fix(docs-infra): fix positioning of message for disabled JavaScript ()
PR Close 
2018-10-05 15:39:23 -07:00
George Kalpakas
ab6f055479 ci(docs-infra): show custom 404 page on preview server (for consistency) ()
PR Close 
2018-10-05 15:39:02 -07:00
Atuuh
3683c6a188 docs: fix wording ()
fix wording to sound better
PR Close 
2018-10-05 14:19:08 -07:00
thanhpd
4006c9b6e6 docs: fix spelling errors ()
PR Close 
2018-10-05 14:18:19 -07:00
Kirankumar Sripati
245b85f72a docs: typo fixes ()
PR Close 
2018-10-05 14:00:20 -07:00
Charles Lyding
3cce4afa0d build(docs-infra): update fsevents to 1.2.4 to support node 10 ()
PR Close 
2018-10-05 13:45:36 -07:00
Suguru Inatomi
35936864bc docs: add Suguru Inatomi to GDE resources ()
PR Close 
2018-10-04 10:10:52 -07:00
Pete Bacon Darwin
a2878b0b1d fix(docs-infra): remove unnecessary margin on short descriptions ()
(This was added in 405d97431fa374afdd5cddc6780f8949ee76a2c6 but it is
not clear the reasoning. It looks better to remove it now.)

PR Close 
2018-10-01 09:36:34 -07:00
Pete Bacon Darwin
5977b72e9c build(docs-infra): fix formatting of entry point export table ()
Now that `list-table` cells are `pre` formatterd we must be careful
of what whitespace appears in text nodes.

PR Close 
2018-10-01 09:36:34 -07:00
Pete Bacon Darwin
7373da9b11 build(docs-infra): simplify property syntax rendering ()
PR Close 
2018-10-01 09:36:34 -07:00
Pete Bacon Darwin
783a682a7d build(docs-infra): remove unused property table heading ()
PR Close 
2018-10-01 09:36:34 -07:00
Pete Bacon Darwin
d22418d417 build(docs-infra): add short description "See more" link ()
If there is additional (non-short) description then add in a
link to the short description to take the reader there.

PR Close 
2018-10-01 09:36:34 -07:00
Pete Bacon Darwin
4b1fd98093 build(docs-infra): pluralize NgModule(s) heading as appropriate ()
PR Close 
2018-10-01 09:36:34 -07:00
Pete Bacon Darwin
935ef13096 build(docs-infra): improve directive selector rendering ()
`:not(...)` blocks are now rendered as italic, while the
rest of the selector is bold.

PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
f4b60588fb build(docs-infra): move directive macros into memberHelpers.html ()
PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
15dadb92ef build(docs-infra): include directives etc in class descendants lists ()
PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
ce06a75ebf build(docs-infra): display inherited members on directives ()
PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
9889276b15 build(docs-infra): directive inputs and outputs ()
PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
d0f7eadc09 build(docs-infra): rename example template variable in directive pages ()
PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
4b132c9848 build(docs-infra): remove class overview from directive pages ()
PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
46729c76a0 build(docs-infra): improve directive selector rendering ()
If the documentation contains a `@selectors` tag then the content of that
is used to describe the selectors of a directive.

Otherwise the selector string is split and each selector is listed as
a list item in an unordered list.

PR Close 
2018-10-01 09:36:33 -07:00
Pete Bacon Darwin
f22deb2e2d build(docs-infra): improve directive API doc templates ()
Closes 
Closes 

PR Close 
2018-10-01 09:36:32 -07:00
George Kalpakas
57de9fc41a build(docs-infra): upgrade @angular/cli to 6.2.3 ()
PR Close 
2018-10-01 09:35:49 -07:00
George Kalpakas
31034f5146 build(docs-infra): upgrade @angular/* to 7.0.0-beta.7 ()
PR Close 
2018-10-01 09:35:48 -07:00
George Kalpakas
c5899f4cd4 build(docs-infra): update payload size limits to reflect current status ()
PR Close 
2018-10-01 09:35:48 -07:00
Jordan Whitfield
794c3595d4 docs: fix a typo in the Universal guide ()
line 39: `highly-interactive` is the pre-qualifier of `Angular application`, which is the subject so the comma is not necessary (I think). I think this will make it easier for non-native speakers.

PR Close 
2018-09-28 09:36:09 -07:00
Judy Bogart
f455518d80 docs: integrate cli doc from wiki into main doc ()
PR Close 
2018-09-27 15:33:47 -07:00
Ben Lesh
ffc6e199bf build: RxJS updated to 6.3 ()
PR Close 
2018-09-26 17:01:15 -07:00
George Kalpakas
a01acec7fe fix(docs-infra): use correct parameters for paginated requests to GitHub ()
As it turns out, in GitHub API paginated requests, page numbering is
1-based. (https://developer.github.com/v3/#pagination)

Starting at page 0 (which returns the first page), results in making the
same request twice and logging incorrect numbers (since the first 100
items are listed twice).

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
021f4344b1 fix(docs-infra): fix preview server periodic clean-up ()
Includes the following fixes:

- Fix cron entry format for clean-up script.
  Crontabs in `/etc` should not have a user field. No idea why it used
  to work before, but it started giving errors recently:
  `/bin/sh: root: not found`.

- Set required env variable in clean-up script. (Broken in cc6f36a9d.)
  This was producing the following error:
  `ERROR: Missing required environment variable 'AIO_CIRCLE_CI_TOKEN'!`

- Use the correct path for downloads to be removed. (Broken in cc6f36a9d.)

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
f113b49909 test(docs-infra): remove unnecessary test helpers ()
`supertest.Request` extends `Promise` and can be used directly without
"promisifying".

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
d8d276c245 docs(docs-infra): update preview server docs to account for recent changes ()
Mostly (but not exclusively) a follow-up to .

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
e42bd012f9 ci(docs-infra): test PR previews on CI ()
The deployment of PR previews is triggered by the notification webhook
of the `aio_preview` CircleCI job (which creates and stores the build
artifacts).

This commit adds a new job (`test_aio_preview`), which waits for the
preview to be deployed (for PRs that do have a preview) and then runs
some tests against it (currently only PWA tests).

Fixes 

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
6d6b0ff1ad feat(docs-infra): add API endpoint for checking if PR can have preview ()
There several reasons why PRs cannot have (public) previews:
- The PR did not affect any relevant files (e.g. non-spec files in
  `aio/` or `packages/`).
- The PR cannot be automatically verified as "trusted" (based on its
  author or labels).

Note:
The endpoint does not check whether there currently is a (public)
preview for the specified PR; only whether there can be one.

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
f378454c92 fix(docs-infra): correctly check PR files on preview server ()
According to the docs, the response of GitHub's [PR files API][1]
_"includes a maximum of 300 files"_. This means that if a PR contains
more files, it is possible that not all files are retrieved (which
could, for example, give a false negative for the "significant files
touched" check - not likely but possible).

This commit fixes it by using paginated requests to retrieve all changed
files.

[1]: https://developer.github.com/v3/pulls/#list-pull-requests-files

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
c8c8436e58 test(docs-infra): fix test for preview server's GithubPullRequests ()
PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
b31c8b6063 test(docs-infra): fix test for preview server's BuildCleaner completing prematurely ()
PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
897261efdc test(docs-infra): fix preview server unit tests on Windows ()
Some tests where comparing actual with expected paths, without taking
into account that paths will be different on Windows.

This commit uses `path.resolve()` to convert expected paths to their
OS-specific form.

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
35d70ff265 test(docs-infra): add support for source-maps in preview server tests ()
PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
fc0a7959a4 refactor(docs-infra): use mockable logger ()
Related discussion:
https://github.com/angular/angular/pull/23576#discussion_r187925949.

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
182c08bee1 refactor(docs-infra): fix method name (getPrfromBranch --> getPrFromBranch) ()
PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
e2bc0ad6c2 build(docs-infra): upgrade preview server dependencies ()
PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
73333ee3e5 build(docs-infra): replace concurrently with npm-run-all for preview server dev ()
`npm-run-all` works just as well, but is better at handling termination on Windows.

PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
c819859598 build(docs-infra): do not exit preview server dev script when build fails ()
PR Close 
2018-09-26 15:26:19 -07:00
George Kalpakas
79aefa7659 build(docs-infra): avoid race condition in aio-builds-setup/ npm scripts ()
Previously, due to multiple scripts re-building during `yarn dev`
initialization, there could be race conditions that led to errors.

This commit fixes it by ensuring `yarn build` is run once (before
the main `yarn dev` script).

PR Close 
2018-09-26 15:26:19 -07:00