293 Commits

Author SHA1 Message Date
Jason Aden
e8768acacc fix(common): escape query selector used when anchor scrolling ()
When an anchor scroll happens, we run document.querySelector. This value can be taken directly from the user. Therefore it's possible to throw an error on scrolling, which can cause the application to fail.

This PR escapes the selector before using it.

Related to 
[Internal discussion](https://groups.google.com/a/google.com/forum/#!topic/angular-users/d82GHfmRKLc)

PR Close 
2019-03-29 10:39:38 -07:00
Judy Bogart
333bfa0ffb docs: api doc for i18n ()
PR Close 
2019-03-29 10:27:42 -07:00
Vani
b17d1a9aa3 docs: update description text ()
PR Close 
2019-03-27 09:57:36 -07:00
Vani
60f6d9e733 docs: fix lint error ()
PR Close 
2019-03-27 09:57:36 -07:00
Vani
416b0d29b9 docs: add details to HttpUrlEncodingCodec API description ()
PR Close 
2019-03-27 09:57:36 -07:00
Marc Laval
66b72bfa58 fix(ivy): ViewContainerRef.destroy should properly clean the DOM ()
PR Close 
2019-03-22 13:13:12 -07:00
Pete Bacon Darwin
a770aa231d refactor(ivy): move ngcc into a higher level folder ()
PR Close 
2019-03-20 14:45:54 -04:00
Matias Niemelä
8714daf276 fix(ivy): introduce host-specific styling instructions ()
This patch is the first of a few patches which separates the
styling logic between template bindings (e.g. <div [style])
from host bindings (e.g. @HostBinding('style')). This patch
in particular introduces a series of host-specific styling
instructions and changes the existing set of template styling
instructions not to accept directives. The underyling code (which
communicates with the styling algorithm) still works as it did
before.

This PR also separates the styling instruction code into a separate
file and moves over all other instructions into an dedicated
instructions directory.

PR Close 
2019-03-19 16:33:39 -04:00
Adam Plumer
7b70760c8d refactor: move DOCUMENT imports from platform-browser to common ()
PR Close 
2019-03-14 16:01:57 -04:00
Alan
941c99ad7f build: turn off dts bundling for packages that still are not supported ()
PR Close 
2019-03-07 10:47:20 -08:00
Alan
d5a8be76f2 build: enable bundle_dts for common package ()
PR Close 
2019-03-06 10:59:18 -08:00
Pawel Kozlowski
04cf4ef0c7 test(ivy): remove ngComponentOutlet example with a lazy-loaded NgModule ()
PR Close 
2019-03-04 14:41:55 -08:00
Greg Magolan
ea09430039 build: rules_nodejs 0.26.0 & use @npm instead of @ngdeps now that downstream angular build uses angular bundles ()
PR Close 
2019-02-28 12:06:36 -08:00
Wassim Chegham
ce68b4d839 style: enforce buildifier lint on CI ()
PR Close 
2019-02-26 16:57:41 -08:00
Greg Magolan
75357ecb32 build(bazel): run a number of web tests with karma_web_test in saucelabs in CircleCI ()
PR Close 
2019-02-22 13:07:08 -08:00
Vani
65d839da03 docs(common): update docs for HttpClient methods ()
PR Close 
2019-02-21 20:56:11 -08:00
Matias Niemelä
cfb2d176f8 feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings ()
Prior to this fix, both the `NgStyle` and `NgClass` directives made use
of `Renderer2` and this dependency raised issues for future versions of
Angular that cannot inject it. This patch ensures that there are two
versions of both directives: one for the VE and another for Ivy.

Jira Issue: FW-882

PR Close 
2019-02-20 13:46:15 -08:00
Greg Magolan
67ad8a2632 build: move rxjs type reference to event emitter ()
PR Close 
2019-02-19 16:28:14 -08:00
Greg Magolan
25aae64274 build(bazel): do not build rxjs from source under Bazel ()
PR Close 
2019-02-19 16:28:14 -08:00
Vani
8accc98d28 docs: incorporate review feedback ()
PR Close 
2019-02-14 19:33:14 +00:00
Vani
aa8d0809d3 docs: update HttpInterceptor API docs ()
PR Close 
2019-02-14 19:33:14 +00:00
Paul Gschwendtner
7cbc36fdac build: remove unused rollup.config.js files ()
Since we build and publish the individual packages
using Bazel and `build.sh` has been removed, we can
safely remove the `rollup.config.js` files which are no
longer needed because the `ng_package` bazel rule
automatically handles the rollup settings and globals.

PR Close 
2019-02-14 19:28:08 +00:00
Judy Bogart
644e7a28d8 docs: add di-related api doc ()
PR Close 
2019-02-13 11:57:37 -08:00
Vani
c3fadadaa9 docs: update HttpHeader documentation ()
PR Close 
2019-02-07 16:42:13 -08:00
Paul Gschwendtner
40d64b6b58 build: run offline_compiler_test using bazel ()
PR Close 
2019-01-28 20:07:22 -08:00
Ben Lesh
a95e81978b refactor(ivy): Add newer, smaller NgOnChangesFeature ()
PR Close 
2019-01-23 10:59:34 -08:00
Ben Lesh
5552661fd7 refactor(ivy): revert onChanges change back to a feature ()
- adds fixmeIvy annotation to tests that should remain updated so we can resolve those issues in the subsequent commits

PR Close 
2019-01-23 10:59:33 -08:00
Judy Bogart
589dd479e2 docs: add input docs ()
PR Close 
2019-01-22 12:19:28 -08:00
Judy Bogart
661a98aeda docs: add api doc for ngif ()
PR Close 
2019-01-22 12:19:28 -08:00
Judy Bogart
988243437a docs: add method doc ()
PR Close 
2019-01-22 12:18:02 -08:00
Judy Bogart
3b9553bb17 docs: expand input descriptions ()
PR Close 
2019-01-22 12:18:02 -08:00
Judy Bogart
b6819fe9bb docs: add inpur vars doc ()
PR Close 
2019-01-22 12:18:02 -08:00
Judy Bogart
6c3b57a968 docs: add api doc for ngfor ()
PR Close 
2019-01-22 12:18:02 -08:00
Judy Bogart
37f8263430 docs: correct array to map ()
PR Close 
2019-01-22 12:16:45 -08:00
Judy Bogart
a84a9ba705 docs: add input doc ()
PR Close 
2019-01-22 12:16:45 -08:00
Judy Bogart
d73734dcb7 docs: add api doc for ng_style directive ()
PR Close 
2019-01-22 12:16:45 -08:00
Alex Eagle
38343a2388 build: set a default module_name for ts_library rules ()
PR Close 
2019-01-18 10:16:39 -08:00
Judy Bogart
850b86749c docs: add api doc for switch directives ()
PR Close 
2019-01-15 10:53:03 -08:00
Misko Hevery
6a9a48b0ac test: improve symbol-extractor test by ignoring $1 suffix ()
PR Close 
2019-01-14 09:55:30 -08:00
Ben Lesh
8ebdb437dc fix(ivy): ngOnChanges only runs for binding updates ()
PR Close 
2019-01-11 14:28:35 -08:00
Alan Agius
b61dafaeac refactor: remove redundant error in catch ()
PR Close 
2019-01-04 15:42:19 -08:00
Judy Bogart
c4f7727408 docs: add api doc for viewport scroller ()
PR Close 
2018-12-26 11:47:16 -08:00
Kara Erickson
a20b2f72f2 fix(ivy): process creation mode deeply before running update mode ()
Prior to this commit, we had two different modes for change detection
execution for Ivy, depending on whether you called `bootstrap()` or
`renderComponent()`. In the former case, we would complete creation
mode for all components in the tree before beginning update mode for
any component. In the latter case, we would run creation mode and
update mode together for each component individually.

Maintaining code to support these two different execution orders was
unnecessarily complex, so this commit aligns the two bootstrapping
mechanisms to execute in the same order. Now creation mode always
runs for all components before update mode begins.

This change also simplifies our rendering logic so that we use
`LView` flags as the source of truth for rendering mode instead of
`rf` function arguments. This fixed some related bugs (e.g. calling
`ViewRef.detectChanges` synchronously after the view's creation
would create view nodes twice, view queries would execute twice, etc).

PR Close 
2018-12-19 15:10:16 -05:00
Pawel Kozlowski
ea10a3abe5 test(ivy): enable all test for @angular/common ()
PR Close 
2018-12-17 09:32:09 -08:00
Ruslan Dzhabbarov
7dab458884 docs(common): fix documentation for getLocaleCurrencyName ()
PR Close 
2018-12-14 15:27:03 -08:00
Ingo Bürk
b39efdd9d6 fix(common): KeyValuePipe should return empty array for empty objects ()
This lets KeyValuePipe return an empty array (rather than undefined)
when the input is empty.

PR Close 
2018-12-14 15:19:13 -08:00
Christopher Dahm
d0d351cccb docs(common): update currencyPipe default digitsInfo values ()
Change the docs to reflect the actual default values

Fixes 
PR Close 
2018-12-14 10:26:56 -08:00
cooljeffro
7fae9114c8 docs(common): Fix typo in KeyValuePipe docs ()
PR Close 
2018-12-14 10:21:47 -08:00
Alex Eagle
d32939d51a build: restrict visibility of npm_package targets ()
dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder

PR Close 
2018-12-14 10:20:40 -08:00
Igor Minar
4f81a7c590 test(common): run @angular/common/http/testing tests under bazel ()
PR Close 
2018-12-05 20:55:31 -08:00