Commit Graph

10269 Commits

Author SHA1 Message Date
Alex Eagle 00497437a6 fix(bazel): don't inline tslib into fesms ()
PR Close 
2018-03-28 10:19:14 -07:00
Chuck Jazdzewski 4e004f3783 ci(compiler-cli): run compiler-cli tests in bazel ()
PR Close 
2018-03-28 10:02:53 -07:00
George Kalpakas d9dc46e651 fix(service-worker): ignore invalid `only-if-cached` requests ()
Under some circumstances (possibly related to opening Chrome DevTools),
requests are made with `cache: 'only-if-cached'` and `mode: 'no-cors'`.
These request will eventually fail, because `only-if-cached` is only
allowed to be used with `mode: 'same-origin'`.
This is likely a bug in Chrome DevTools.

This commit avoids errors related to such requests by not handling them.

Fixes 

PR Close 
2018-03-28 10:02:16 -07:00
George Kalpakas 9e9b8dd494 fix(service-worker): do not enter degraded mode when offline ()
Previously, when trying to fetch `ngsw.json` (e.g. during
`checkForUpdate()`) while either the client or the server were offline,
the ServiceWorker would enter a degrade mode, where only existing
clients would be served. This essentially meant that the ServiceWorker
didn't work offline.
This commit fixes it by differentiating offline errors and not entering
degraded mode. The ServiceWorker will remain in the current mode until
connectivity to the server is restored.

Fixes 

PR Close 
2018-03-28 10:02:16 -07:00
George Kalpakas 12665a749c test(service-worker): minor test fixes and refactorings ()
PR Close 
2018-03-28 10:02:16 -07:00
Kara Erickson e2e80ec61c refactor(ivy): remove pipe references from the template ()
PR Close 
2018-03-28 09:17:27 -07:00
Kara Erickson 5a86f7144f fix(ivy): store local variables in data instead of calling loadDirective ()
PR Close 
2018-03-28 09:17:05 -07:00
Alex Rickabaugh bd024c02e2 feat(compiler): lower @NgModule ids if needed ()
This change allows the id of an NgModule to be dynamically computed if
needed.

PR Close 
2018-03-28 09:15:16 -07:00
Alex Rickabaugh 884bf0ef09 fix: consistently rewrite Injector to INJECTOR ()
In Ivy mode we rewrite references to Injector to INJECTOR in ngInjectableDef, to fix tree-shaking.

This changes the rewrite to happen always, even in non-Ivy mode, and makes Angular understand
INJECTOR across the board at runtime.

PR Close 
2018-03-28 09:14:32 -07:00
Alex Eagle 0b348c8ffe build: fix bazel stamping ()
As pointed out in https://github.com/bazelbuild/rules_nodejs/issues/156
our mechanism would never pick up changes to the version info.

PR Close 
2018-03-28 09:00:02 -07:00
Alex Rickabaugh e1ea7ed019 docs: update examples for tree-shakeable providers ()
PR Close 
2018-03-28 07:53:04 -07:00
Keen Yee Liau ed53c5ccdd refactor(language-service): Remove angularOnlyResults ()
This commit is a duplicate of https://github.com/angular/angular/pull/18637
to remove Angular-specific results from the language service.

PR Close 
2018-03-27 17:22:44 -04:00
Olivier Combe d28ce50067 test(ivy): make sure `goog.getMsg()` is defined before being used ()
PR Close 
2018-03-27 17:07:50 -04:00
Joey Perrott ab348ee2be build: update browserstack key ()
PR Close 
2018-03-27 14:56:12 -04:00
Veres Lajos 0ebdb3d12f style: typo fix amendments ()
PR Close 
2018-03-27 14:51:53 -04:00
Veres Lajos de90314304 style: typos fixed - https://github.com/vlajos/misspell-fixer ()
PR Close 
2018-03-27 14:51:53 -04:00
Kara Erickson f739f756ce test(ivy): fix flaky tests ()
PR Close 
2018-03-27 14:48:50 -04:00
Kara Erickson 910a16a1ff refactor(ivy): remove directive references from template ()
PR Close 
2018-03-26 22:33:23 -04:00
Jeremy Elbourn 2aabbc51fa fix(bazel): ng_package packages attr not forwarded to npm_package ()
PR Close 
2018-03-26 22:32:09 -04:00
Jeremy Elbourn 2388f24256 build(bazel): add entry_point_name attr to ng_package ()
PR Close 
2018-03-26 22:30:16 -04:00
Alex Eagle 27e14b2fb3 feat(bazel): prefix private-export (barred-latin-o) symbols ()
This allows a bundle index to be re-exported by a higher-level module without fear of collisions.
Under bazel, we always set the prefix to be underscore-joined workspace, package, label

PR Close 
2018-03-26 22:28:55 -04:00
Victor Berchet 7a406a32fa refactor: add a commit-msg git hook to check commit messages ()
The commit command will fail if the commit message header does not follow the
Angular convetions as defined in /CONTRIBUTING.md.

You can force the commit by adding the `--no-verify` option.

NOTE:
You should remove all unused hooks (in <angular>/.git/hooks) before running
`yarn` so that husky hooks are installed correctly.

PR Close 
2018-03-26 18:34:31 -04:00
Matias Niemelä bf6a416bce revert: docs(common): add `HttpParamsOptions` to the public API ()
This reverts commit 7b7757dd3d.
2018-03-26 16:29:46 -04:00
George Kalpakas 7b7757dd3d docs(common): add `HttpParamsOptions` to the public API ()
Fixes 

PR Close 
2018-03-23 16:31:10 -04:00
Victor Berchet 4bd3a65764 fix(aio): mark the 'titlecase' pipe as pure ()
PR Close 
2018-03-23 16:28:05 -04:00
Alex Rickabaugh 6f0191744c fix(core): don't override ngInjectableDef in the decorator if present on the type ()
Previously, @Injectable() would generate an ngInjectableDef on the type it was
decorating, even if that type already had a compiled ngInjectableDef, overwriting
the compiled version.

PR Close 
2018-03-23 16:13:06 -04:00
Alex Eagle 4f0cae0676 build: allow bazel build //... ()
Also switch our CircleCI commands to just
bazel build //...
bazel test //...
as this is easier to understand.

Note, the reason this commit removes `firebase-tools` is:

1) firebase-tools has an optional dependency on
https://www.npmjs.com/package/@google-cloud/functions-emulator
2) yarn's `--ignore-optional` doesn't work for transitive deps, so
there's no way to yarn install without getting that functions-emulator
package
3) functions-emulator has a transitive dep on `grpc`
4) the version of `grpc` we get has `BUILD` files and no `WORKSPACE`
file so it always breaks `bazel build ...`

It could be solved by any of:
1) remove firebase-tools - this is what I did
2) fix yarn so you can omit optional deps of a transitive dep
3) make functions-emulator depend transitively on a more recent `grpc`
version
4) patch `grpc` after install by doing an `rm` command in our
postinstall or something

In its place we must install protobufjs. This is needed by the
ngc-wrapped test, which needs jasmine as well as bazel's worker mode
dependencies, and therefore cannot simply rely on
node_modules =
"@build_bazel_rules_typescript_tsc_wrapped_deps//:node_modules"

PR Close 
2018-03-23 15:02:32 -05:00
Victor Berchet 65f296a676 test(compiler): assert translation names pattern ()
PR Close 
2018-03-23 15:06:06 -04:00
Misko Hevery b9cbe83104 docs(ivy): update STATUS.md with compiler work breakdown ()
PR Close 
2018-03-23 15:04:55 -04:00
George Kalpakas 60d99839de docs: update available platforms for `test.sh` ()
PR Close 
2018-03-23 14:01:45 -04:00
sergeome 7966744a44 fix(common): titlecase pipe ()
PR Close 
2018-03-23 13:42:51 -04:00
Jeremy Elbourn d9a0a8ff3e build(bazel): add `data` attr to ng_package ()
PR Close 
2018-03-23 13:16:07 -04:00
Victor Berchet bcaa07b0ac refactor(compiler): move handling of translations to the ConstantPool ()
PR Close 
2018-03-23 13:12:58 -04:00
Victor Berchet d98e9e7c7f fix(compiler): take quoting into account when determining if object literals can be shared ()
PR Close 
2018-03-23 13:12:58 -04:00
Alberto Piras 16f021c319 docs(aio): fix TS warning error - filter expects a boolean function param ()
PR Close 
2018-03-23 13:07:57 -04:00
Igor Minar 3a30f5d937 build(aio): remove rxjs-compat dependency from examples ()
we should not longer need it.

PR Close 
2018-03-23 12:53:58 -04:00
Igor Minar 0f88fc73db build(aio): update examples to angular-in-memory-web-api@0.6.0 ()
PR Close 
2018-03-23 12:53:58 -04:00
George Kalpakas 01d2dd2a3a refactor(aio): switch to pipeable RxJS operators ()
PR Close 
2018-03-23 12:53:58 -04:00
George Kalpakas da76db9601 build(aio): upgrade `rxjs` to `6.0.0-beta.1` ()
PR Close 
2018-03-23 12:53:58 -04:00
George Kalpakas 91503e538e test(aio): minor improvements ()
PR Close 
2018-03-23 12:53:58 -04:00
George Kalpakas 53227abe7b build(aio): upgrade `rxjs` to `6.0.0-beta.0` ()
PR Close 
2018-03-23 12:53:58 -04:00
George Kalpakas 768100516f build(aio): upgrade `@angular/*` to `6.0.0-rc.0` ()
PR Close 
2018-03-23 12:53:58 -04:00
Igor Minar 328511be8e build(aio): update to typescript@2.7.2 ()
PR Close 
2018-03-23 12:53:58 -04:00
Igor Minar 56e545735c build(aio): update to @angular/core@6.0.0-beta.8 ()
PR Close 
2018-03-23 12:53:58 -04:00
Igor Minar 07e9969cb7 build(aio): update to @angular/cli@1.7.3 ()
PR Close 
2018-03-23 12:53:58 -04:00
Victor Berchet 5ab9d4d437 test(compiler): allow asserting matching identifier names ()
PR Close 
2018-03-22 21:24:19 -04:00
Victor Berchet 129bb1800b refactor(compiler): refactor code matching helpers for compliance spec ()
PR Close 
2018-03-22 21:24:19 -04:00
Kara Erickson 49396ca2ae refactor(ivy): move directives into separate array ()
PR Close 
2018-03-22 21:23:02 -04:00
Alex Eagle 34981063ec build: ts-api-guardian reuses root node_modules ()
This avoids the need to run bazel run :install instead of yarn install.
We merge the devDependencies of ts-api-guardian into the root package.json file.

PR Close 
2018-03-22 19:23:33 -04:00
Chuck Jazdzewski 8ca26a9ebb ci(compiler): run compiler tests in bazel ()
PR Close 
2018-03-22 19:22:14 -04:00