8663fa04a8
Merge remote-tracking branch 'en/master' into aio
...
# Conflicts:
# .nvmrc
# aio/content/cli/index.md
# aio/content/guide/ajs-quick-reference.md
# aio/content/guide/animations.md
# aio/content/guide/aot-compiler.md
# aio/content/guide/app-shell.md
# aio/content/guide/architecture-components.md
# aio/content/guide/architecture-modules.md
# aio/content/guide/architecture-services.md
# aio/content/guide/architecture.md
# aio/content/guide/attribute-directives.md
# aio/content/guide/bazel.md
# aio/content/guide/bootstrapping.md
# aio/content/guide/browser-support.md
# aio/content/guide/build.md
# aio/content/guide/cheatsheet.md
# aio/content/guide/cli-builder.md
# aio/content/guide/comparing-observables.md
# aio/content/guide/complex-animation-sequences.md
# aio/content/guide/component-interaction.md
# aio/content/guide/component-styles.md
# aio/content/guide/creating-libraries.md
# aio/content/guide/dependency-injection-in-action.md
# aio/content/guide/dependency-injection-navtree.md
# aio/content/guide/dependency-injection-providers.md
# aio/content/guide/dependency-injection.md
# aio/content/guide/deployment.md
# aio/content/guide/deprecations.md
# aio/content/guide/displaying-data.md
# aio/content/guide/dynamic-component-loader.md
# aio/content/guide/dynamic-form.md
# aio/content/guide/elements.md
# aio/content/guide/entry-components.md
# aio/content/guide/feature-modules.md
# aio/content/guide/file-structure.md
# aio/content/guide/form-validation.md
# aio/content/guide/forms-overview.md
# aio/content/guide/forms.md
# aio/content/guide/frequent-ngmodules.md
# aio/content/guide/glossary.md
# aio/content/guide/hierarchical-dependency-injection.md
# aio/content/guide/http.md
# aio/content/guide/i18n.md
# aio/content/guide/ivy.md
# aio/content/guide/language-service.md
# aio/content/guide/lazy-loading-ngmodules.md
# aio/content/guide/lifecycle-hooks.md
# aio/content/guide/module-types.md
# aio/content/guide/ngmodule-api.md
# aio/content/guide/ngmodule-faq.md
# aio/content/guide/ngmodule-vs-jsmodule.md
# aio/content/guide/ngmodules.md
# aio/content/guide/npm-packages.md
# aio/content/guide/observables-in-angular.md
# aio/content/guide/observables.md
# aio/content/guide/pipes.md
# aio/content/guide/providers.md
# aio/content/guide/reactive-forms.md
# aio/content/guide/releases.md
# aio/content/guide/reusable-animations.md
# aio/content/guide/route-animations.md
# aio/content/guide/router.md
# aio/content/guide/rx-library.md
# aio/content/guide/schematics-authoring.md
# aio/content/guide/schematics-for-libraries.md
# aio/content/guide/schematics.md
# aio/content/guide/security.md
# aio/content/guide/service-worker-communications.md
# aio/content/guide/service-worker-config.md
# aio/content/guide/service-worker-devops.md
# aio/content/guide/service-worker-getting-started.md
# aio/content/guide/service-worker-intro.md
# aio/content/guide/set-document-title.md
# aio/content/guide/setup-local.md
# aio/content/guide/sharing-ngmodules.md
# aio/content/guide/singleton-services.md
# aio/content/guide/static-query-migration.md
# aio/content/guide/structural-directives.md
# aio/content/guide/styleguide.md
# aio/content/guide/template-syntax.md
# aio/content/guide/testing.md
# aio/content/guide/transition-and-triggers.md
# aio/content/guide/typescript-configuration.md
# aio/content/guide/universal.md
# aio/content/guide/updating.md
# aio/content/guide/upgrade-setup.md
# aio/content/guide/upgrade.md
# aio/content/guide/user-input.md
# aio/content/guide/using-libraries.md
# aio/content/guide/visual-studio-2015.md
# aio/content/guide/web-worker.md
# aio/content/guide/workspace-config.md
# aio/content/marketing/events.html
# aio/content/marketing/resources.json
# aio/content/navigation.json
# aio/content/start/data.md
# aio/content/start/deployment.md
# aio/content/start/forms.md
# aio/content/start/index.md
# aio/content/start/routing.md
# aio/content/tutorial/index.md
# aio/content/tutorial/toh-pt0.md
# aio/content/tutorial/toh-pt1.md
# aio/content/tutorial/toh-pt2.md
# aio/content/tutorial/toh-pt3.md
# aio/content/tutorial/toh-pt4.md
# aio/content/tutorial/toh-pt5.md
# aio/content/tutorial/toh-pt6.md
# aio/package.json
# aio/src/app/app.component.spec.ts
# aio/src/app/custom-elements/api/api-list.component.html
# aio/src/app/layout/doc-viewer/doc-viewer.component.ts
# aio/src/app/layout/mode-banner/mode-banner.component.ts
# aio/src/app/layout/nav-item/nav-item.component.html
# aio/src/app/shared/toc.service.ts
# aio/src/styles/0-base/_typography.scss
# aio/src/styles/2-modules/_api-pages.scss
# aio/tools/transforms/templates/api/lib/memberHelpers.html
# aio/yarn.lock
# packages/common/http/src/headers.ts
# packages/common/http/src/interceptor.ts
# packages/common/http/src/params.ts
# packages/common/http/src/response.ts
# packages/common/src/common_module.ts
# packages/common/src/directives/ng_for_of.ts
# packages/common/src/location/location.ts
# packages/common/src/pipes/date_pipe.ts
# packages/core/src/change_detection/pipe_transform.ts
# packages/core/src/di/injectable.ts
# packages/core/src/metadata/di.ts
# packages/core/src/metadata/directives.ts
# packages/core/src/metadata/ng_module.ts
# packages/core/src/render3/component_ref.ts
# packages/forms/src/directives/reactive_directives/form_control_name.ts
# packages/forms/src/form_builder.ts
# packages/forms/src/model.ts
# packages/forms/src/validators.ts
# packages/router/src/config.ts
# packages/router/src/directives/router_outlet.ts
# packages/router/src/events.ts
# packages/router/src/router.ts
# packages/router/src/router_module.ts
# packages/router/src/router_state.ts
# packages/router/src/shared.ts
2020-01-24 15:55:22 +08:00
86e1e6c082
feat: typescript 3.6 support ( #32946 )
...
BREAKING CHANGE: typescript 3.4 and 3.5 are no longer supported, please update to typescript 3.6
Fixes #32380
PR Close #32946
2019-10-18 13:15:16 -04:00
d5057aec3b
Merge remote-tracking branch 'en/master' into aio
2019-06-03 10:09:20 +08:00
f84c4b066a
build(docs-infra): pin versions of packages installed in preview server docker image ( #29976 )
...
This minimises the risk of unexpected failures due to breaking changes,
when building a new image (e.g. as a result of an unrelated config
change in Dockerfile).
PR Close #29976
2019-04-23 08:33:27 -07:00
2f1a862b83
build(docs-infra): upgrade preview server docker image to Debian 9 ( #29976 )
...
Previously, the preview server docker image was based on Debian 8
(jessie). Recently, `jessie-updates` and `jessie-backborts` were removed
from the Debian mirrors ([more info][1]), thus breaking new builds of
the image.
Instead of updating `/etc/apt/sources.list` to remove the obsolete
sources, this commit upgrades to Debian 9 (stretch).
(The GCE VM running the preview server docker container was also
upgraded from Debian 8 to 9 this morning.)
---
Other changes:
- Removed dependency on `chkconfig`, which is not supported on Debian 9.
- Installing `nginx` from the regular repositories (instead of
`*-backports).
- Upgraded to `pm2` v3, which can handle hooking itself up to system
startup better (without `chkconfig` - see above).
- Updated tests to reflect the fact that `nginx` has dropped the reason
phrase in response status lines for HTTP/2 (in compliance with
[the spec][2]). (HTTP/1.1: `HTTP/1.1 200 OK` | HTTP/2: `HTTP/2 200`)
[1]: https://www.lucas-nussbaum.net/blog/?p=947
[2]: https://http2.github.io/http2-spec/#rfc.section.8.1.2.4
PR Close #29976
2019-04-23 08:33:27 -07:00
24c06091f2
build(docs-infra): increase build artifact size limit for preview server ( #29976 )
...
In #29926 , the size of the build artifacts has increased due to turning
on differential loading (which generates an es2015/es5 pair for each JS
resource).
To avoid the preview server's rejecting the build artifacts (as in
[288181][1]), this commit increases the max allowed artifact size from
20MB to 25MB (current artifact size after #29926 is ~22MB).
[1]: https://circleci.com/gh/angular/angular/288181
PR Close #29976
2019-04-23 08:33:27 -07:00
0c59342cd0
build(docs-infra): automatically create previews for members of `aio-auto-previews` ( #29293 )
...
PR Close #29293
2019-03-14 10:51:18 -04:00
b035e68480
Merge remote-tracking branch 'en/master' into aio
...
# Conflicts:
# .travis.yml
# aio/content/guide/aot-compiler.md
# aio/content/guide/architecture.md
# aio/content/guide/build.md
# aio/content/guide/dependency-injection-in-action.md
# aio/content/guide/deployment.md
# aio/content/guide/elements.md
# aio/content/guide/file-structure.md
# aio/content/guide/glossary.md
# aio/content/guide/hierarchical-dependency-injection.md
# aio/content/guide/lifecycle-hooks.md
# aio/content/guide/ngmodule-faq.md
# aio/content/guide/pipes.md
# aio/content/guide/router.md
# aio/content/guide/rx-library.md
# aio/content/guide/service-worker-communications.md
# aio/content/guide/service-worker-config.md
# aio/content/guide/singleton-services.md
# aio/content/guide/template-syntax.md
# aio/content/guide/testing.md
# aio/content/guide/typescript-configuration.md
# aio/content/guide/universal.md
# aio/content/marketing/docs.md
# aio/content/marketing/features.html
# aio/content/tutorial/toh-pt0.md
# aio/content/tutorial/toh-pt6.md
# aio/package.json
# aio/src/app/layout/footer/footer.component.html
# aio/tools/transforms/templates/api/lib/memberHelpers.html
# aio/yarn.lock
# integration/cli-hello-world-ivy-minimal/src/polyfills.ts
# modules/benchmarks/e2e_test/largetable_perf.ts
# modules/benchmarks/e2e_test/largetable_spec.ts
# packages/animations/src/animation_metadata.ts
# packages/common/http/src/headers.ts
# packages/common/http/src/interceptor.ts
# packages/common/src/directives/ng_for_of.ts
# packages/common/src/directives/ng_if.ts
# packages/common/src/directives/ng_style.ts
# packages/common/src/directives/ng_switch.ts
# packages/core/src/change_detection/change_detection_util.ts
# packages/core/src/di/injectable.ts
# packages/core/src/interface/lifecycle_hooks.ts
# packages/core/src/linker/template_ref.ts
# packages/core/src/metadata/di.ts
# packages/core/src/metadata/directives.ts
# packages/core/src/metadata/ng_module.ts
# packages/core/src/render/api.ts
# packages/forms/src/form_providers.ts
# packages/forms/src/model.ts
# packages/router/src/config.ts
# packages/router/src/directives/router_link.ts
2019-02-17 00:00:16 +08:00
a0cdefb5fb
ci(docs-infra): do not automatically post preview comments on PRs for team ( #28211 )
...
Right now, we post such comments whenever a file has been touched that
could potentially have affected the docs. Since the API docs are built
from comments in the source code, almost all non-docs changes are
generating such preview comments, even though most of the time they are
irrelevant to the author and create unnecessary noise on the PR
(especially for actively worked-on PRs).
This commit removes the `team` GitHub team from the list of teams whose
members will automatically get preview comments.
(Adding the `aio: preview` label would still work on any PR.)
Jira: FW-967
PR Close #28211
2019-01-17 14:11:42 -08:00
8744f17f5d
Merge remote-tracking branch 'en/master' into aio
...
# Conflicts:
# aio/content/cli/index.md
# aio/content/file-not-found.md
# aio/content/guide/architecture-modules.md
# aio/content/guide/architecture-services.md
# aio/content/guide/build.md
# aio/content/guide/deployment.md
# aio/content/guide/elements.md
# aio/content/guide/feature-modules.md
# aio/content/guide/file-structure.md
# aio/content/guide/forms-overview.md
# aio/content/guide/glossary.md
# aio/content/guide/i18n.md
# aio/content/guide/npm-packages.md
# aio/content/guide/releases.md
# aio/content/guide/router.md
# aio/content/guide/service-worker-config.md
# aio/content/guide/service-worker-intro.md
# aio/content/guide/testing.md
# aio/content/guide/upgrade-performance.md
# aio/content/navigation.json
# aio/content/tutorial/toh-pt0.md
# aio/content/tutorial/toh-pt5.md
# aio/content/tutorial/toh-pt6.md
# aio/package.json
# aio/src/app/custom-elements/api/api-list.component.ts
# aio/src/app/documents/document.service.ts
# aio/src/app/layout/top-menu/top-menu.component.ts
# aio/src/index.html
# aio/src/styles/2-modules/_api-pages.scss
# aio/tools/transforms/templates/api/base.template.html
# aio/tools/transforms/templates/api/lib/memberHelpers.html
# aio/tools/transforms/templates/cli/cli-container.template.html
# aio/tools/transforms/templates/lib/githubLinks.html
# aio/yarn.lock
# packages/animations/src/animation_metadata.ts
# packages/common/http/src/backend.ts
# packages/common/http/src/client.ts
# packages/common/http/src/headers.ts
# packages/common/http/src/interceptor.ts
# packages/common/http/src/module.ts
# packages/common/http/src/params.ts
# packages/common/http/src/request.ts
# packages/common/http/src/response.ts
# packages/common/src/common_module.ts
# packages/common/src/directives/ng_class.ts
# packages/common/src/directives/ng_style.ts
# packages/common/src/directives/ng_switch.ts
# packages/common/src/i18n/format_date.ts
# packages/common/src/pipes/number_pipe.ts
# packages/core/src/change_detection/change_detection_util.ts
# packages/core/src/change_detection/pipe_transform.ts
# packages/core/src/di/injectable.ts
# packages/core/src/linker/element_ref.ts
# packages/core/src/linker/template_ref.ts
# packages/core/src/metadata/di.ts
# packages/core/src/metadata/directives.ts
# packages/core/src/metadata/lifecycle_hooks.ts
# packages/core/src/metadata/ng_module.ts
# packages/core/src/render/api.ts
# packages/forms/src/directives/form_interface.ts
# packages/forms/src/directives/ng_form.ts
# packages/forms/src/directives/ng_model.ts
# packages/forms/src/directives/reactive_directives/form_control_name.ts
# packages/forms/src/directives/select_control_value_accessor.ts
# packages/forms/src/directives/validators.ts
# packages/forms/src/form_builder.ts
# packages/forms/src/form_providers.ts
# packages/forms/src/model.ts
# packages/forms/src/validators.ts
# packages/platform-browser/src/browser.ts
# packages/platform-browser/src/security/dom_sanitization_service.ts
# packages/router/src/config.ts
# packages/router/src/events.ts
# packages/router/src/router.ts
# packages/router/src/router_module.ts
# packages/router/src/shared.ts
2018-12-29 16:04:37 +08:00
7524c99be2
fix(docs-infra): log the successful creation of previews ( #27436 )
...
This can help with debugging issues, e.g. with the communication between
the preview server and CI, as it gives a better idea of exactly when was
the preview made available and how long it took.
PR Close #27436
2018-12-04 19:59:24 -08:00
f45aedcbf0
build(docs-infra): upgrade `npm-run-all` to latest version for security ( #27274 )
...
Earlier versions may transitively depend on a malicious version of
`flatmap-stream` (see dominictarr/event-stream#116).
The `aio-builds-setup/` had an older version of `event-stream` (3.3.4),
which did not depend on `flatmap-stream`, but upgraded it anyway.
PR Close #27274
2018-11-26 12:20:48 -08:00
ce6948fc1b
ci(docs-infra): remove jobs from Travis config ( #26377 )
...
PR Close #26377
2018-10-23 14:35:38 -07:00
ab6f055479
ci(docs-infra): show custom 404 page on preview server (for consistency) ( #26199 )
...
PR Close #26199
2018-10-05 15:39:02 -07:00
a01acec7fe
fix(docs-infra): use correct parameters for paginated requests to GitHub ( #25671 )
...
As it turns out, in GitHub API paginated requests, page numbering is
1-based. (https://developer.github.com/v3/#pagination )
Starting at page 0 (which returns the first page), results in making the
same request twice and logging incorrect numbers (since the first 100
items are listed twice).
PR Close #25671
2018-09-26 15:26:19 -07:00
021f4344b1
fix(docs-infra): fix preview server periodic clean-up ( #25671 )
...
Includes the following fixes:
- Fix cron entry format for clean-up script.
Crontabs in `/etc` should not have a user field. No idea why it used
to work before, but it started giving errors recently:
`/bin/sh: root: not found`.
- Set required env variable in clean-up script. (Broken in cc6f36a9d.)
This was producing the following error:
`ERROR: Missing required environment variable 'AIO_CIRCLE_CI_TOKEN'!`
- Use the correct path for downloads to be removed. (Broken in cc6f36a9d.)
PR Close #25671
2018-09-26 15:26:19 -07:00
f113b49909
test(docs-infra): remove unnecessary test helpers ( #25671 )
...
`supertest.Request` extends `Promise` and can be used directly without
"promisifying".
PR Close #25671
2018-09-26 15:26:19 -07:00
d8d276c245
docs(docs-infra): update preview server docs to account for recent changes ( #25671 )
...
Mostly (but not exclusively) a follow-up to #23576 .
PR Close #25671
2018-09-26 15:26:19 -07:00
6d6b0ff1ad
feat(docs-infra): add API endpoint for checking if PR can have preview ( #25671 )
...
There several reasons why PRs cannot have (public) previews:
- The PR did not affect any relevant files (e.g. non-spec files in
`aio/` or `packages/`).
- The PR cannot be automatically verified as "trusted" (based on its
author or labels).
Note:
The endpoint does not check whether there currently is a (public)
preview for the specified PR; only whether there can be one.
PR Close #25671
2018-09-26 15:26:19 -07:00
f378454c92
fix(docs-infra): correctly check PR files on preview server ( #25671 )
...
According to the docs, the response of GitHub's [PR files API][1]
_"includes a maximum of 300 files"_. This means that if a PR contains
more files, it is possible that not all files are retrieved (which
could, for example, give a false negative for the "significant files
touched" check - not likely but possible).
This commit fixes it by using paginated requests to retrieve all changed
files.
[1]: https://developer.github.com/v3/pulls/#list-pull-requests-files
PR Close #25671
2018-09-26 15:26:19 -07:00
c8c8436e58
test(docs-infra): fix test for preview server's `GithubPullRequests` ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
b31c8b6063
test(docs-infra): fix test for preview server's `BuildCleaner` completing prematurely ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
897261efdc
test(docs-infra): fix preview server unit tests on Windows ( #25671 )
...
Some tests where comparing actual with expected paths, without taking
into account that paths will be different on Windows.
This commit uses `path.resolve()` to convert expected paths to their
OS-specific form.
PR Close #25671
2018-09-26 15:26:19 -07:00
35d70ff265
test(docs-infra): add support for source-maps in preview server tests ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
fc0a7959a4
refactor(docs-infra): use mockable logger ( #25671 )
...
Related discussion:
https://github.com/angular/angular/pull/23576#discussion_r187925949 .
PR Close #25671
2018-09-26 15:26:19 -07:00
182c08bee1
refactor(docs-infra): fix method name (getPrfromBranch --> getPrFromBranch) ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
e2bc0ad6c2
build(docs-infra): upgrade preview server dependencies ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
73333ee3e5
build(docs-infra): replace `concurrently` with `npm-run-all` for preview server dev ( #25671 )
...
`npm-run-all` works just as well, but is better at handling termination on Windows.
PR Close #25671
2018-09-26 15:26:19 -07:00
c819859598
build(docs-infra): do not exit preview server `dev` script when `build` fails ( #25671 )
...
PR Close #25671
2018-09-26 15:26:19 -07:00
79aefa7659
build(docs-infra): avoid race condition in `aio-builds-setup/` npm scripts ( #25671 )
...
Previously, due to multiple scripts re-building during `yarn dev`
initialization, there could be race conditions that led to errors.
This commit fixes it by ensuring `yarn build` is run once (before
the main `yarn dev` script).
PR Close #25671
2018-09-26 15:26:19 -07:00
92c8752d0a
docs(docs-infra): the `build.sh` script was renamed to `create-image.sh`
2018-08-16 10:26:13 +01:00
68bfe686d8
ci(docs-infra): rename 'upload-server' to 'preview-server'
...
The server no longer has files uploaded to it. Instead it is more
accurate to refer to it as dealing with "previews" of PRs.
2018-08-16 10:26:13 +01:00
d604ef7cf0
ci(docs-infra): add explicit return types to methods
2018-08-16 10:26:13 +01:00
36c4c8daa9
ci(docs-infra): improve preview-server logging
2018-08-16 10:26:13 +01:00
cc6f36a9d7
ci(docs-infra): change AIO preview server stuff to pull builds from CircleCI
...
Previously, Travis pushed the build artitfacts to the preview server.
This required us to use JWT to secure the POST request from Travis, to
ensure we couldn't receive malicious builds.
JWT has been deprecated and we are moving our builds to CircleCI.
This commit rewrites the TypeScript part of the preview server that
handles converting build artifact into hosted previews of the docs.
2018-08-16 10:26:13 +01:00
643766637e
ci(docs-infra): factor out the aio-builds-setup environment variables
2018-08-16 10:26:12 +01:00
3b8b7f4087
ci(docs-infra): add helper scripts for running TDD in Docker
2018-08-16 10:26:12 +01:00
9b820555a3
docs(docs-infra): update the preview server documentation
2018-08-16 10:26:12 +01:00
364459c576
ci(docs-infra): move AIO preview deployment to CircleCI
...
Now instead of pushing the AIO build artifacts to the preview server
from inside a Travis job, the artifacts are built and hosted on the
CircleCI infrastructure. The preview server will then pull these
down after being triggered by a CircleCI build webhook.
2018-08-16 10:26:11 +01:00
8347bb0d2d
ci(docs-infra): update upload-server to run on node.js v10
2018-08-16 10:21:24 +01:00
5e8bf2f88d
build(docs-infra): ensure `dist/` directory is cleaned before running `tsc --watch` ( #24372 )
...
PR Close #24372
2018-06-11 09:18:46 -07:00
ea143e7498
build(docs-infra): upgrade preview server to latest `@types/shelljs` ( #24372 )
...
PR Close #24372
2018-06-11 09:18:46 -07:00
3e39fef274
refactor(aio): improve logging output in `update-preview-server.sh` ( #24071 )
...
PR Close #24071
2018-05-25 13:44:44 -04:00
79cecf9a5e
fix(aio): update trusted GitHub teams (angular-core --> team) ( #23181 )
...
PR Close #23181
2018-04-05 10:07:13 -07:00
de90314304
style: typos fixed - https://github.com/vlajos/misspell-fixer ( #22975 )
...
PR Close #22975
2018-03-27 14:51:53 -04:00
910735d732
build: fix `yarn install` command (`--freeze-lockfile` --> `--frozen-lockfile`)
2017-10-20 10:14:30 -07:00
dc038113a5
build(aio): freeze yarn lockfile for aio-builds-setup scripts ( #19616 )
...
PR Close #19616
2017-10-11 11:52:35 -07:00
9ae3742565
docs(aio): fix typo in preview server config file comment
2017-10-04 12:40:28 -07:00
0e00265647
build(aio): disable cache when building a new docker image for the preview server ( #19391 )
2017-09-28 09:28:54 -07:00
68078fd620
build(aio): run the upload server as a non-previleged user
...
closes #19352
Previously, the upload server (for PR previews) was run as root and
"downleveled" to a non-privileged user from inside the node script.
Now, with the latest version of `pm2` (which is used to run the upload server
scripts), we can get rid of that workaround and set the desired UID directly
through `pm2`.
2017-09-25 12:01:42 -07:00
Zhicheng WANG
Igor Minar
George Kalpakas
Pete Bacon Darwin
Veres Lajos