iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
19,149 Commits 5 Branches 1 Tag
Commit Graph

24 Commits

Author SHA1 Message Date
Misko Hevery
5db84d7221 refactor(core): Remove TViewNode as it is no longer used. (#38707) 
Previous commit change the logic to not rely on the `TViewNode` this
change removes it entirely.

PR Close #38707
 2020-09-28 16:15:59 -04:00
Andrew Kushnir
0879d2e85d refactor(core): throw more descriptive error message in case of invalid host element (#35916) 
This commit replaces an assert with more descriptive error message that is thrown in case `<ng-template>` or `<ng-container>` is used as host element for a Component.

Resolves #35240.

PR Close #35916
 2020-06-26 11:10:14 -07:00
Andrew Scott
779344012a refactor(core): assert TNode is not a container when setting attribute on element (#37111) 
This PR provides a more helpful error than the one currently present:
`el.setAttribute is not a function`. It is not valid to have directives with host bindings
on `ng-template` or `ng-container` nodes. VE would silently ignore this, while Ivy
attempts to set the attribute and throws an error because these are comment nodes
and do not have `setAttribute` functionality.

It is better to throw a helpful error than to silently ignore this because
putting a directive with host binding on an `ng-template` or `ng-container` is most often a mistake.
Developers should be made aware that the host binding will have no effect in these cases.

Note that an error is already thrown in Ivy, as mentioned above, so this
is not a breaking change and can be merged to both master and patch.

Resolves #35994

PR Close #37111
 2020-06-08 11:21:05 -07:00
Joey Perrott
d1ea1f4c7f build: update license headers to reference Google LLC (#37205) 
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close #37205
 2020-05-26 14:26:58 -04:00
pkozlowski-opensource
ddaa124162 refactor(core): remove _tViewNode field from ViewRef (#36814) 
The _tViewNode field (that was marked as internal) on the ViewRef is not
necessery as a reference to a relevant TView is available as a local
variable.

PR Close #36814
 2020-05-14 15:35:37 -07:00
Misko Hevery
f5c7e883a9 refactor(core): Take advantage of 'assert functions' for ngDevMode asserts (#35964) 
As of TypeScript 3.7, TypeScript supports [Assert Functions](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#assertion-functions). This change adds assert types to our `assert*` functions.

We can't fully take advantage of this due to [Assert functions do not constraint type when they are guarded by a truthy expression.](https://github.com/microsoft/TypeScript/issues/37295)

PR Close #35964
 2020-03-10 21:01:26 -04:00
Misko Hevery
994264c0ba refactor(ivy): simplify walkTNodeTree method for readability (#31065) 
PR Close #31065
 2019-08-19 10:12:38 -07:00
Misko Hevery
885f1af509 build: extract interface and util sub compilation from core (#28028) 
PR Close #28028
 2019-01-10 16:31:44 -08:00
Kara Erickson
e76a570908 refactor(ivy): remove LNode (#26426) 
PR Close #26426
 2018-10-15 11:20:32 -07:00
Kara Erickson
83a1334876 refactor(ivy): migrate previousOrParentNode to use TNodes (#25829) 
PR Close #25829
 2018-09-07 16:06:17 -07:00
Pawel Kozlowski
b00038c847 fix(ivy): inject ViewContainerRef for directives on ng-container (#25617) 
PR Close #25617
 2018-08-24 11:52:50 -04:00
Jason Aden
e3759f7a73 feat(ivy): add support of ApplicationRef.bootstrapModuleFactory (#23811) 
PR Close #23811
 2018-06-07 16:15:26 -04:00
Victor Berchet
c494d3cf60
Revert "feat(ivy): add support of ApplicationRef.bootstrapModuleFactory (#23811)" 
This reverts commit 22b58a717aad87092a7f7080805c10ef36960694.
This commit causes a breakage in g3.
 2018-06-05 22:11:47 -07:00
Jason Aden
22b58a717a feat(ivy): add support of ApplicationRef.bootstrapModuleFactory (#23811) 
PR Close #23811
 2018-06-05 20:10:25 -07:00
Kara Erickson
68bf8c36c6 refactor(ivy): move type from LNode to TNode (#24113) 
PR Close #24113
 2018-05-25 13:40:59 -04:00
Kara Erickson
e44f69c387 refactor(ivy): move dir flags to tnode (#22901) 
PR Close #22901
 2018-03-22 19:19:40 -04:00
Victor Berchet
a1d86daa71 refactor(ivy): assertion (#22189) 
Encourage the use of message to explain the assertion

PR Close #22189
 2018-02-15 09:53:05 -08:00
Matias Niemelä
f628797d91 Revert "refactor(ivy): assertion (#22189)" 
This reverts commit 0b683123d280f45e4fb904c1552292f50de6bfc7.
 2018-02-14 22:56:11 -05:00
Victor Berchet
0b683123d2 refactor(ivy): assertion (#22189) 
Encourage the use of message to explain the assertion

PR Close #22189
 2018-02-14 18:42:04 -05:00
Kara Erickson
6be9c0466c refactor(core): split up interface files in render3 (#21433) 
PR Close #21433
 2018-01-10 16:13:44 -08:00
Miško Hevery
5a7bf36723 build: fix circular dep between interface and l_node by merging (#20855) 
PR Close #20855
 2017-12-21 21:40:58 -08:00
Pawel Kozlowski
4f05d022c1 feat(core): support 'read' option for ngIvy queries (#20855) 
PR Close #20855
 2017-12-21 21:40:58 -08:00
Kara Erickson
b462f49ce7 refactor(core): renamed and split out interfaces (#20855) 
PR Close #20855
 2017-12-21 21:40:58 -08:00
Miško Hevery
0fa818b318 feat(core): Moving Renderer3 into @angular/core (#20855) 
PR Close #20855
 2017-12-21 21:40:58 -08:00