cexbrayat
851cf16134
docs(service-worker): note about isStable/setInterval ( #28102 )
...
The docs don't mention that the app will never be stable if a `setInterval` is running somewhere, and that it will prevent the servcie worker to be registered too.
PR Close #28102
2019-02-06 15:13:19 -05:00
jithil-kore
ad499628cb
docs: fix typo for Browserslist in build guide ( #28328 )
...
PR Close #28328
2019-01-29 16:35:26 -08:00
Matti Järvinen
24f5428187
docs: fix typo for Browserslist in file structure guide ( #28312 )
...
PR Close #28312
2019-01-29 16:33:18 -08:00
Nazar Nasirzada
a228d65412
docs: fix typo in lifecycle-hooks.md ( #28206 )
...
## PR Checklist
Please check if your PR fulfills the following requirements:
* [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
* [ ] Tests for the changes have been added (for bug fixes / features)
* [x] Docs have been added / updated (for bug fixes / features)
## PR Type
What kind of change does this PR introduce?
* [ ] Bugfix
* [ ] Feature
* [ ] Code style update (formatting, local variables)
* [ ] Refactoring (no functional changes, no api changes)
* [ ] Build related changes
* [ ] CI related changes
* [x] Documentation content changes
* [ ] angular.io application / infrastructure changes
* [ ] Other... Please describe:
## What is the current behavior?
Issue Number: N/A
## What is the new behavior?
## Does this PR introduce a breaking change?
* [ ] Yes
* [x] No
## Other information
PR Close #28206
2019-01-29 16:32:02 -08:00
onlyflix
41e68f7a7a
style: change to American English ( #27266 )
...
PR Close #27266
2019-01-29 16:30:25 -08:00
Kapunahele Wong
75074d009f
docs: rewrite event binding section and add example ( #26162 )
...
PR Close #26162
2019-01-22 11:31:41 -08:00
Giorgos Bamparopoulos
197676a6dd
docs: rename "internal" access modifier to "protected" ( #26627 )
...
PR Close #26627
2019-01-22 11:20:26 -08:00
Luiz Machado
1fb6731285
docs: fix crisis-detail milestone files ( #27025 )
...
Crisis Detail's template was being added two times and the component's TS none.
PR Close #27025
2019-01-22 11:19:51 -08:00
Hamza TEI
1df8be5573
docs: update link to post on redirects in router guide ( #27256 )
...
Change victor savkin's url post on redirects to:
http://vsavkin.tumblr.com/post/146722301646/angular-router-empty-paths-componentless-routes
PR Close #27256
2019-01-22 11:17:18 -08:00
ericksoen
6324ad45e7
docs: correct minor typo ( #27382 )
...
PR Close #27382
2019-01-22 10:19:05 -08:00
Stepan Suvorov
7439b46c5a
docs: fix explanation of Injectable decorator in architecture guide ( #27480 )
...
PR Close #27480
2019-01-22 10:18:05 -08:00
krzysztof-grzybek
cfb41452ce
docs: update testing doc example style for HostListener ( #26372 )
...
HostListener is preferred over host metadata by official style guide
PR Close #26372
2019-01-14 17:04:46 -08:00
Malgosia
857fcfe048
docs: ng config link fix ( #28115 )
...
Fixed 'ng config' link to lead to proper CLI command site
PR Close #28115
2019-01-14 10:47:05 -08:00
javatutorials2016
2c9f0139a3
docs: fix typo in singleton services guide ( #27948 )
...
PR Close #27948
2019-01-14 10:41:30 -08:00
Shivam_Vyas
1ec01d6758
docs: change in(what should I import? answer) NgModule FAQs ( #27677 )
...
I think only should be after BrowserModule , because we can import more than BrowserModule and I think we need to import other modules to AppModule in most of cases and we should import BrowserModule only in AppModule,so that thing seems okay.
PR Close #27677
2019-01-14 10:39:03 -08:00
Ashinze Ekene
4bb5f638bc
docs: fix typo in dependency injection guide ( #27616 )
...
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*
PR Close #27616
2019-01-14 10:38:05 -08:00
coultonluke
d6aca79410
docs: updates to minor spelling mistakes in pipes guide ( #27208 )
...
PR Close #27208
2019-01-14 10:34:17 -08:00
Brandon Roberts
e4c899e4ba
docs: add browser polyfills for IE11 with hash-based routing ( #27135 )
...
Closes #26511
PR Close #27135
2019-01-14 10:33:23 -08:00
Sasidhar Vanga
5e6e96d844
docs: fix GitHub pages deployment command ( #26896 )
...
closes #26803
PR Close #26896
2019-01-14 10:32:31 -08:00
Courtney Pattison
638375b7ca
docs: fix typo in testing guide ( #26828 )
...
PR Close #26828
2019-01-14 10:30:33 -08:00
cyraid
c5b67b95b7
docs: update link in universal guide ( #26628 )
...
Link to the document "53 percent of mobile site visits" was changed, updated link. Old link led to a page that didn't have the statistics on it.
PR Close #26628
2019-01-14 10:12:52 -08:00
Alan Agius
78bc21c63a
docs: fix scripts section and some minor issues in universal documentation ( #26444 )
...
PR Close #26444
2019-01-14 10:11:08 -08:00
Judy Bogart
e082fc24b2
docs: add library doc to guides in aio ( #27581 )
...
PR Close #27581
2019-01-11 16:22:19 -08:00
George Kalpakas
8c3f98fdbb
docs(service-worker): fix example of manually checking for updates ( #28020 )
...
Poll for updates in a way that does not prevent the SW from being
registered. Discussed in https://github.com/angular/angular/pull/27332#pullrequestreview-179504620 .
PR Close #28020
2019-01-11 11:17:18 -08:00
Judy Bogart
a6f7fe394a
docs: add schematics terms to glossary ( #27862 )
...
PR Close #27862
2019-01-11 11:15:08 -08:00
Kapunahele Wong
d505468fb7
docs: re-write interpolation section and add example ( #25170 )
...
PR Close #25170
2019-01-11 11:12:44 -08:00
Joseph Harrison-Lim
bccf8da35f
docs(router): fix misnamed path ( #27879 )
...
This change matches the routes found in the following code example
for auth.guard.ts as well as the login.component.1.ts in the "Add
the LoginComponent" section.
PR Close #27879
2019-01-10 17:06:05 -08:00
Mark Goho
acb2caced0
docs: fix typo ( #27865 )
...
PR Close #27865
2019-01-10 17:04:54 -08:00
Johannes Hoppe
96f4969a2b
docs: fix broken html for deployment.md ( #27851 )
...
without the closing quote the text and link are not displayed correctly
PR Close #27851
2019-01-10 17:03:54 -08:00
George Kalpakas
d0c3e252a3
docs: remove deprecated `fromPromise` from RxJS guide ( #28015 )
...
Follow-up to #27443 .
PR Close #28015
2019-01-09 15:37:52 -08:00
Michael De Wree
582395b8f5
docs: fix typo PageNotFoundCompponent ( #27799 )
...
closes : #27795
PR Close #27799
2019-01-09 12:42:39 -08:00
Paul Gschwendtner
c7d1890aaa
build: remove travisci leftovers ( #27979 )
...
PR Close #27979
2019-01-09 10:41:16 -08:00
Alan Agius
a0a3648e7a
docs: add more info on what is being cached ( #27343 )
...
PR Close #27343
2019-01-03 09:29:44 -08:00
Ronen Gelman
7df9040c05
docs: add missing comma to environment config in build guide ( #27476 )
...
PR Close #27476
2019-01-03 09:29:17 -08:00
Mohammed Salman
5638c1d507
docs: fix npm description in architecture modules guide ( #27818 )
...
PR Close #27818
2019-01-03 09:28:45 -08:00
Alan
755c8091af
docs: improve description of bundle budgets ( #27833 )
...
PR Close #27833
2019-01-03 09:28:16 -08:00
Cyrille Tuzi
59f64dd361
docs(service-worker): update service worker configuration doc ( #27868 )
...
PR Close #27868
2019-01-03 09:27:30 -08:00
Nico Jansen
707c6828b5
docs(elements): add "Firefox" for support of custom elements ( #27789 )
...
Firefox now supports custom elements: https://caniuse.com/#feat=custom-elementsv1
PR Close #27789
2018-12-26 11:27:45 -08:00
Emilio Martinez
94f17e9038
docs: remove misplaced code in Universal guide ( #26865 )
...
PR Close #26865
2018-12-17 09:35:35 -08:00
Lucas
dc1ed3c47e
docs: fix ngModel typo in form validation guide ( #27574 )
...
Fix typo
PR Close #27574
2018-12-11 16:22:58 -08:00
Michał Jawulski
3cb6dad6d5
docs: update npm scripts to support angular 7 ( #27334 )
...
PR Close #27334
2018-12-11 11:25:36 -08:00
dennisameling
3983d04b1c
docs: fix dynamic-component-loader example for Adblock Plus + EasyList ( #27212 )
...
Reported issue in #18138 is due to EasyList being selected in ABP. This commit fixes both the image at the bottom of the Dynamic Component Loader example, and the Stackblitz demo.
Fixes #18138
PR Close #27212
2018-11-30 13:35:38 -08:00
Jacob Foshee
9e391e010c
docs: Minor: insert missing space ( #27213 )
...
PR Close #27213
2018-11-28 11:41:21 -08:00
Amadou Sall
8424f587b0
docs: replace ChromeNoSandbox by ChromeHeadlessCI ( #27304 )
...
the custom launcher name should be named ChromeHeadlessCI instead of ChromeNoSandbox.
PR Close #27304
2018-11-28 11:40:03 -08:00
Brandon Roberts
30f12f2887
docs: add forms terms to glossary ( #27075 )
...
PR Close #27075
2018-11-26 09:26:06 -08:00
Elan Hasson
859da3af50
docs: The note had an indentation and was missing line breaks ( #27183 )
...
Fixed the formatting and made Note bold.
PR Close #27183
2018-11-20 10:43:31 -08:00
Alan
a4934a74b6
docs: fix code examples style ( #26573 )
...
PR Close #26573
2018-11-16 12:27:00 -08:00
Rae Krantz
efa443bba3
docs: fix typo ( #26878 )
...
PR Close #26878
2018-11-13 10:49:35 -08:00
Ferdinand Malcher
f80c6008af
docs: Fix wrong quoting in SSR guide ( #27057 )
...
PR Close #27057
2018-11-12 12:52:32 -08:00
Alvaro Junqueira
c89045fb77
docs: update links to TC39 and observable proposal ( #26715 )
...
Before (404 Not Found):
http://www.ecma-international.org/memento/TC39.htm
After:
https://www.ecma-international.org/memento/tc39-m.htm
PR Close #26715
2018-11-09 09:41:57 -08:00