angular-docs-cn/third_party
Paul Gschwendtner 7e895b9179 build: fix web_worker playground examples using external resources (#28562)
The `web_workers/images` example is not being tested by any e2e
spec and therefore it's technically not necessary to fix that it uses
external resources, though in order to ensure that the Bazel builds
are hermetic and that we can eventually add e2e specs for the
web_worker/image example, we should avoid any use of external
resources.

We remove the `web-animations` polyfill in the `web_workers/animations`
example because we should try to vendor as few as possible deps. Also
the animations API is already supported by browsers we run the e2e tests
against (note here: `web_workers/animations` is currently also disabled)

PR Close #28562
2019-02-13 12:01:54 -08:00
..
fonts.google.com/open-sans build: fix routing playground example using external resource (#28490) 2019-02-04 16:51:11 -05:00
github.com build: fix web_worker playground examples using external resources (#28562) 2019-02-13 12:01:54 -08:00
README.md docs: add a README for third_party usage (#28651) 2019-02-12 09:54:43 -08:00

README.md

third_party vendored sources in Angular

TL;DR: don't copy sources into this repo

All sources in this repo should be authored from scratch by the committer. Don't copy sources you've found in any other location.

What if I have a good reason?

We do "vendor in" some sources, in cases where we do not want our users to have a transitive dependency. For example, to make testing more reliable, we copy a font into our repo. That allows our integration tests to run without dynamically requesting that font.

Follow these guidelines for adding sources under third_party:

  1. Only vendor sources with compatible licenses. Apache 2.0 and MIT are good. Any other licenses, check with your team lead so we can verify our ability to comply with the license.
  2. Preserve the license for code. The best thing to do is copy the entire LICENSE file along with the sources.
  3. Indicate where the sources came from. Our convention is to create a directory based on the URL where the sources were fetched. Add version number or if missing, the retrieval date, as a comment in the build file just above the license() call. Example: https://github.com/angular/angular/blob/master/third_party/fonts.google.com/open-sans/BUILD.bazel
  4. Avoid changing the files you fetched. If you make any changes to the sources, first commit the original, then in a separate commit, make your edits. include another metadata file listing your changes, like https://github.com/bazelbuild/rules_nodejs/blob/master/third_party/github.com/source-map-support/LOCAL_MODS.md
  5. Any bundle or distribution which includes this code needs to propagate the LICENSE file or content. Talk to your TL to make sure this is done correctly.

Under Bazel

This directory is treated specially by Bazel.

All BUILD.bazel files under third_party are required to have a licenses statement. See https://docs.bazel.build/versions/master/be/functions.html#licenses

Note that we don't yet have a way to enumerate the licenses and include them in our distribution. Follow https://github.com/bazelbuild/bazel/issues/188