21c2a06811
Currently we have a common utility method for running commands in a child process. This method pipes all stdout and stderr, but sets the `stdin` to `inherited`. This seemed to work as expected in terms of allowing interactive commands being executed, but it messes with the TTY in Windows (and potentially other platforms) so that colors and prompts no longer work properly. See attached screenshot. We fix this by not inheriting the stdin by default; but exposing a dedicated method for interactive commands. This results in more readable and obvious code too, so it's worth making this change regardless of the TTY issues. PR Close #41948 |
||
|---|---|---|
| .. | ||
| actions | ||
| release-notes | ||
| test | ||
| BUILD.bazel | ||
| actions-error.ts | ||
| actions.ts | ||
| cli.ts | ||
| commit-message.ts | ||
| constants.ts | ||
| external-commands.ts | ||
| graphql-queries.ts | ||
| index.ts | ||
| pull-request-state.ts | ||