To improve cross platform support, all file access (and path manipulation) is now done through a well known interface (`FileSystem`). For testing a number of `MockFileSystem` implementations are provided. These provide an in-memory file-system which emulates operating systems like OS/X, Unix and Windows. The current file system is always available via the static method, `FileSystem.getFileSystem()`. This is also used by a number of static methods on `AbsoluteFsPath` and `PathSegment`, to avoid having to pass `FileSystem` objects around all the time. The result of this is that one must be careful to ensure that the file-system has been initialized before using any of these static methods. To prevent this happening accidentally the current file system always starts out as an instance of `InvalidFileSystem`, which will throw an error if any of its methods are called. You can set the current file-system by calling `FileSystem.setFileSystem()`. During testing you can call the helper function `initMockFileSystem(os)` which takes a string name of the OS to emulate, and will also monkey-patch aspects of the TypeScript library to ensure that TS is also using the current file-system. Finally there is the `NgtscCompilerHost` to be used for any TypeScript compilation, which uses a given file-system. All tests that interact with the file-system should be tested against each of the mock file-systems. A series of helpers have been provided to support such tests: * `runInEachFileSystem()` - wrap your tests in this helper to run all the wrapped tests in each of the mock file-systems. * `addTestFilesToFileSystem()` - use this to add files and their contents to the mock file system for testing. * `loadTestFilesFromDisk()` - use this to load a mirror image of files on disk into the in-memory mock file-system. * `loadFakeCore()` - use this to load a fake version of `@angular/core` into the mock file-system. All ngcc and ngtsc source and tests now use this virtual file-system setup. PR Close #30921
		
			
				
	
	
		
			191 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
			
		
		
	
	
			191 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			TypeScript
		
	
	
	
	
	
| /**
 | |
|  * @license
 | |
|  * Copyright Google Inc. All Rights Reserved.
 | |
|  *
 | |
|  * Use of this source code is governed by an MIT-style license that can be
 | |
|  * found in the LICENSE file at https://angular.io/license
 | |
|  */
 | |
| import * as ts from 'typescript';
 | |
| 
 | |
| import {ErrorCode, ngErrorCode} from '../../src/ngtsc/diagnostics';
 | |
| import {runInEachFileSystem} from '../../src/ngtsc/file_system/testing';
 | |
| import {loadStandardTestFiles} from '../helpers/src/mock_file_loading';
 | |
| 
 | |
| import {NgtscTestEnvironment} from './env';
 | |
| 
 | |
| const testFiles = loadStandardTestFiles();
 | |
| 
 | |
| runInEachFileSystem(() => {
 | |
|   describe('ngtsc module scopes', () => {
 | |
|     let env !: NgtscTestEnvironment;
 | |
| 
 | |
|     beforeEach(() => {
 | |
|       env = NgtscTestEnvironment.setup(testFiles);
 | |
|       env.tsconfig();
 | |
|     });
 | |
| 
 | |
|     describe('diagnostics', () => {
 | |
|       describe('imports', () => {
 | |
|         it('should emit imports in a pure function call', () => {
 | |
|           env.write('test.ts', `
 | |
|           import {NgModule} from '@angular/core';
 | |
| 
 | |
|           @NgModule({})
 | |
|           export class OtherModule {}
 | |
| 
 | |
|           @NgModule({imports: [OtherModule]})
 | |
|           export class TestModule {}
 | |
|         `);
 | |
| 
 | |
|           env.driveMain();
 | |
| 
 | |
|           const jsContents = env.getContents('test.js');
 | |
|           expect(jsContents).toContain('i0.ɵɵdefineNgModule({ type: TestModule });');
 | |
|           expect(jsContents)
 | |
|               .toContain(
 | |
|                   '/*@__PURE__*/ i0.ɵɵsetNgModuleScope(TestModule, { imports: [OtherModule] });');
 | |
| 
 | |
|           const dtsContents = env.getContents('test.d.ts');
 | |
|           expect(dtsContents)
 | |
|               .toContain(
 | |
|                   'static ngModuleDef: i0.ɵɵNgModuleDefWithMeta<TestModule, never, [typeof OtherModule], never>');
 | |
|         });
 | |
| 
 | |
|         it('should produce an error when an invalid class is imported', () => {
 | |
|           env.write('test.ts', `
 | |
|           import {NgModule} from '@angular/core';
 | |
| 
 | |
|           class NotAModule {}
 | |
| 
 | |
|           @NgModule({imports: [NotAModule]})
 | |
|           class IsAModule {}
 | |
|         `);
 | |
|           const [error] = env.driveDiagnostics();
 | |
|           expect(error).not.toBeUndefined();
 | |
|           expect(error.messageText).toContain('IsAModule');
 | |
|           expect(error.messageText).toContain('NgModule.imports');
 | |
|           expect(error.code).toEqual(ngErrorCode(ErrorCode.NGMODULE_INVALID_IMPORT));
 | |
|           expect(diagnosticToNode(error, ts.isIdentifier).text).toEqual('NotAModule');
 | |
|         });
 | |
| 
 | |
|         it('should produce an error when a non-class is imported from a .d.ts dependency', () => {
 | |
|           env.write('dep.d.ts', `export declare let NotAClass: Function;`);
 | |
|           env.write('test.ts', `
 | |
|           import {NgModule} from '@angular/core';
 | |
|           import {NotAClass} from './dep';
 | |
| 
 | |
|           @NgModule({imports: [NotAClass]})
 | |
|           class IsAModule {}
 | |
|         `);
 | |
|           const [error] = env.driveDiagnostics();
 | |
|           expect(error).not.toBeUndefined();
 | |
|           expect(error.messageText).toContain('IsAModule');
 | |
|           expect(error.messageText).toContain('NgModule.imports');
 | |
|           expect(error.code).toEqual(ngErrorCode(ErrorCode.VALUE_HAS_WRONG_TYPE));
 | |
|           expect(diagnosticToNode(error, ts.isIdentifier).text).toEqual('NotAClass');
 | |
|         });
 | |
|       });
 | |
| 
 | |
|       describe('exports', () => {
 | |
|         it('should emit exports in a pure function call', () => {
 | |
|           env.write('test.ts', `
 | |
|           import {NgModule} from '@angular/core';
 | |
| 
 | |
|           @NgModule({})
 | |
|           export class OtherModule {}
 | |
| 
 | |
|           @NgModule({exports: [OtherModule]})
 | |
|           export class TestModule {}
 | |
|         `);
 | |
| 
 | |
|           env.driveMain();
 | |
| 
 | |
|           const jsContents = env.getContents('test.js');
 | |
|           expect(jsContents).toContain('i0.ɵɵdefineNgModule({ type: TestModule });');
 | |
|           expect(jsContents)
 | |
|               .toContain(
 | |
|                   '/*@__PURE__*/ i0.ɵɵsetNgModuleScope(TestModule, { exports: [OtherModule] });');
 | |
| 
 | |
|           const dtsContents = env.getContents('test.d.ts');
 | |
|           expect(dtsContents)
 | |
|               .toContain(
 | |
|                   'static ngModuleDef: i0.ɵɵNgModuleDefWithMeta<TestModule, never, never, [typeof OtherModule]>');
 | |
|         });
 | |
| 
 | |
|         it('should produce an error when a non-NgModule class is exported', () => {
 | |
|           env.write('test.ts', `
 | |
|           import {NgModule} from '@angular/core';
 | |
| 
 | |
|           class NotAModule {}
 | |
| 
 | |
|           @NgModule({exports: [NotAModule]})
 | |
|           class IsAModule {}
 | |
|         `);
 | |
|           const [error] = env.driveDiagnostics();
 | |
|           expect(error).not.toBeUndefined();
 | |
|           expect(error.messageText).toContain('IsAModule');
 | |
|           expect(error.messageText).toContain('NgModule.exports');
 | |
|           expect(error.code).toEqual(ngErrorCode(ErrorCode.NGMODULE_INVALID_EXPORT));
 | |
|           expect(diagnosticToNode(error, ts.isIdentifier).text).toEqual('NotAModule');
 | |
|         });
 | |
| 
 | |
|         it('should produce a transitive error when an invalid NgModule is exported', () => {
 | |
|           env.write('test.ts', `
 | |
|           import {NgModule} from '@angular/core';
 | |
| 
 | |
|           export class NotAModule {}
 | |
| 
 | |
|           @NgModule({
 | |
|             imports: [NotAModule],
 | |
|           })
 | |
|           class InvalidModule {}
 | |
| 
 | |
|           @NgModule({exports: [InvalidModule]})
 | |
|           class IsAModule {}
 | |
|         `);
 | |
| 
 | |
|           // Find the diagnostic referencing InvalidModule, which should have come from IsAModule.
 | |
|           const error = env.driveDiagnostics().find(
 | |
|               error => diagnosticToNode(error, ts.isIdentifier).text === 'InvalidModule');
 | |
|           if (error === undefined) {
 | |
|             return fail('Expected to find a diagnostic referencing InvalidModule');
 | |
|           }
 | |
|           expect(error.messageText).toContain('IsAModule');
 | |
|           expect(error.messageText).toContain('NgModule.exports');
 | |
|           expect(error.code).toEqual(ngErrorCode(ErrorCode.NGMODULE_INVALID_EXPORT));
 | |
|         });
 | |
|       });
 | |
| 
 | |
|       describe('re-exports', () => {
 | |
|         it('should produce an error when a non-declared/imported class is re-exported', () => {
 | |
|           env.write('test.ts', `
 | |
|           import {Directive, NgModule} from '@angular/core';
 | |
| 
 | |
|           @Directive({selector: 'test'})
 | |
|           class Dir {}
 | |
| 
 | |
|           @NgModule({exports: [Dir]})
 | |
|           class IsAModule {}
 | |
|         `);
 | |
|           const [error] = env.driveDiagnostics();
 | |
|           expect(error).not.toBeUndefined();
 | |
|           expect(error.messageText).toContain('IsAModule');
 | |
|           expect(error.messageText).toContain('NgModule.exports');
 | |
|           expect(error.code).toEqual(ngErrorCode(ErrorCode.NGMODULE_INVALID_REEXPORT));
 | |
|           expect(diagnosticToNode(error, ts.isIdentifier).text).toEqual('Dir');
 | |
|         });
 | |
|       });
 | |
|     });
 | |
|   });
 | |
| 
 | |
|   function diagnosticToNode<T extends ts.Node>(
 | |
|       diag: ts.Diagnostic, guard: (node: ts.Node) => node is T): T {
 | |
|     if (diag.file === undefined) {
 | |
|       throw new Error(`Expected ts.Diagnostic to have a file source`);
 | |
|     }
 | |
|     const node = (ts as any).getTokenAtPosition(diag.file, diag.start) as ts.Node;
 | |
|     expect(guard(node)).toBe(true);
 | |
|     return node as T;
 | |
|   }
 | |
| });
 |