History

George Kalpakas 284af7308b fix(ngcc): do not fail hard when a format-path points to a non-existing or empty file (#40985 )

Previously, when `ngcc` encountered an entry-point with a format-path
that pointed to a non-existing or empty file it would throw an error and
stop processing the remaining tasks.

In the past, we used to ignore such format-paths and continue processing
the rest of the tasks ([see code][1]). This was changed to a hard
failure in 2954d1b5ca212548c5c4634a30ce773cfe3b9410. Looking at the code
history, the reason for changing the behavior was an (incorrect)
assumption that the condition could not fail. This assumption failed to
take into account the case where a 3rd-party library has an invalid
format-path in its `package.json`. This is an issue with the library,
but it should not prevent `ngcc` from processing other
packages/entry-points/formats.

This commit fixes this by reporting the task as failed but not throwing
an error, thus allowing `ngcc` to continue processing other tasks.

[1]: https://github.com/angular/angular/blob/3077c9a1f89c5bd75fb96c16e/packages/compiler-cli/ngcc/src/main.ts#L124

Fixes #40965

PR Close #40985

2021-02-26 08:26:33 -08:00

src

fix(ngcc): do not fail hard when a format-path points to a non-existing or empty file (#40985 )

2021-02-26 08:26:33 -08:00

test

fix(ngcc): do not fail hard when a format-path points to a non-existing or empty file (#40985 )

2021-02-26 08:26:33 -08:00

BUILD.bazel

refactor(ngcc): move sourcemaps into ngtsc (#37114 )

2020-06-22 13:38:47 -07:00

index.ts

refactor(ngcc): move logging code into ngtsc (#37114 )

2020-06-22 13:38:47 -07:00

main-ivy-ngcc.ts

build: update license headers to reference Google LLC (#37205 )

2020-05-26 14:26:58 -04:00

main-ngcc.ts

build: update license headers to reference Google LLC (#37205 )

2020-05-26 14:26:58 -04:00

README.md

refactor(ivy): move ngcc into a higher level folder (#29092 )

2019-03-20 14:45:54 -04:00

README.md

Angular Compatibility Compiler (ngcc)

This compiler will convert node_modules compiled with ngc, into node_modules which appear to have been compiled with ngtsc.

This conversion will allow such "legacy" packages to be used by the Ivy rendering engine.

Building

The project is built using Bazel:

yarn bazel build //packages/compiler-cli/ngcc

Unit Testing

The unit tests are built and run using Bazel:

yarn bazel test //packages/compiler-cli/ngcc/test

Integration Testing

There are tests that check the behavior of the overall executable:

yarn bazel test //packages/compiler-cli/ngcc/test:integration