6bf99e0eda
This is a follow up fix for
894286dd0c.
It turns out that comments can be closed in several ways:
- `<!-->`
- `<!-- -->`
- `<!-- --!>`
All of the above are valid ways to close comment per:
https://html.spec.whatwg.org/multipage/syntax.html#comments
The new fix surrounds `<` and `>` with zero width space so that it
renders in the same way, but it prevents the comment to be closed eagerly.
PR Close #40525
49 lines
1.8 KiB
TypeScript
49 lines
1.8 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {escapeCommentText} from '@angular/core/src/util/dom';
|
|
|
|
describe('comment node text escaping', () => {
|
|
describe('escapeCommentText', () => {
|
|
it('should not change anything on basic text', () => {
|
|
expect(escapeCommentText('text')).toEqual('text');
|
|
});
|
|
|
|
it('should escape "<" or ">"', () => {
|
|
expect(escapeCommentText('<!--')).toEqual('\u200b<\u200b!--');
|
|
expect(escapeCommentText('<!--<!--')).toEqual('\u200b<\u200b!--\u200b<\u200b!--');
|
|
expect(escapeCommentText('>')).toEqual('\u200b>\u200b');
|
|
expect(escapeCommentText('>-->')).toEqual('\u200b>\u200b--\u200b>\u200b');
|
|
});
|
|
|
|
it('should escape end marker', () => {
|
|
expect(escapeCommentText('before-->after')).toEqual('before--\u200b>\u200bafter');
|
|
});
|
|
|
|
it('should escape multiple markers', () => {
|
|
expect(escapeCommentText('before-->inline-->after'))
|
|
.toEqual('before--\u200b>\u200binline--\u200b>\u200bafter');
|
|
});
|
|
|
|
it('should caver the spec', () => {
|
|
// https://html.spec.whatwg.org/multipage/syntax.html#comments
|
|
expect(escapeCommentText('>')).toEqual('\u200b>\u200b');
|
|
expect(escapeCommentText('->')).toEqual('-\u200b>\u200b');
|
|
expect(escapeCommentText('<!--')).toEqual('\u200b<\u200b!--');
|
|
expect(escapeCommentText('-->')).toEqual('--\u200b>\u200b');
|
|
expect(escapeCommentText('--!>')).toEqual('--!\u200b>\u200b');
|
|
expect(escapeCommentText('<!-')).toEqual('\u200b<\u200b!-');
|
|
|
|
// Things which are OK
|
|
expect(escapeCommentText('.>')).toEqual('.>');
|
|
expect(escapeCommentText('.->')).toEqual('.->');
|
|
expect(escapeCommentText('<!-.')).toEqual('<!-.');
|
|
});
|
|
});
|
|
});
|