3b7a571cc5
In ngUpgradeLite, when a downgraded component [requests its downgraded module][1], the AngularJS injector is [temporarily stored][2] with the intention of grabbing it [once the module has been bootstrapped][3] (which also cleans up the [temporary injector reference][4]). In [some tests][5], bootstrapping a component might throw an error, which causes the test to fail immediatelly and move on to the next test. In slow browsers (e.g. on CI/Saucelabs), the (successful) bootstrapping of another downgraded module might not have been completed in time and thus the temporary injector reference not cleaned up. In such a case, if the following test (in our randomized test suite) happens to rely on the temporary injector reference's being initially unset (such as [this test][6]), it will fail. This might appear as a flake on CI, because it depends on a race condition and specific order of tests, so it usually goes away after a rerun. This commit fixes it by ensuring the temporary injector reference is manually cleaned up, when necessary. Jira issue: FW-939 [1]: |
||
|---|---|---|
| .buildkite | ||
| .circleci | ||
| .github | ||
| aio | ||
| docs | ||
| integration | ||
| modules | ||
| packages | ||
| scripts | ||
| third_party/github.com/bazelbuild/bazel-toolchains/bazelrc | ||
| tools | ||
| .bazelignore | ||
| .bazelrc | ||
| .clang-format | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .nvmrc | ||
| BUILD.bazel | ||
| CHANGELOG.md | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| README.md | ||
| WORKSPACE | ||
| browser-providers.conf.js | ||
| gulpfile.js | ||
| index.bzl | ||
| karma-js.conf.js | ||
| package.json | ||
| protractor-e2e.conf.js | ||
| protractor-examples-e2e.conf.js | ||
| protractor-perf.conf.js | ||
| shims_for_IE.js | ||
| test-events.js | ||
| test-main.js | ||
| tslint.json | ||
| yarn.lock | ||
| yarn.lock.readme.md | ||
README.md
Angular
Angular is a development platform for building mobile and desktop web applications using Typescript/JavaScript and other languages.
Quickstart
Changelog
Learn about the latest improvements.
Want to help?
Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues in the hotlist: community-help.