angular-docs-cn/dev-infra/format
Paul Gschwendtner 67f65a9d25 refactor(dev-infra): improve type-safety of git client utility (#42468)
Currently the `GitClient` accepts a generic parameter for determining
whether the `githubToken` should be set or not. This worked fine so far
in terms of distinguishing between an authenticated and
non-authenticated git client instance, but if we intend to conditionally
show methods only for authenticated instances, the generic parameter
is not suitable.

This commit splits up the `GitClient` into two classes. One for
the base logic without any authorization, and a second class that
extends the base logic with authentication logic. i.e. the
`AuthenticatedGitClient`. This allows us to have specific methods only
for the authenticated instance. e.g.

  * `hasOauthScopes` has been moved to only exist for authenticated
    instances.
  * the GraphQL functionality within `gitClient.github` is not
    accessible for non-authenticated instances. GraphQL API requires
    authentication as per Github.

The initial motiviation for this was that we want to throw if
`hasOAuthScopes` is called without the Octokit instance having
a token configured. This should help avoiding issues as within
3b434ed94d
that prevented the caretaker process momentarily.

Additionally, the Git client has moved from `index.ts` to
`git-client.ts` for better discoverability in the codebase.

PR Close #42468
2021-06-03 14:34:33 -07:00
..
formatters refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
BUILD.bazel build: upgrade angular build, integration/bazel and @angular/bazel package to rule_nodejs 2.2.0 (#39182) 2020-10-08 11:54:59 -07:00
cli.ts refactor(dev-infra): improve type-safety of git client utility (#42468) 2021-06-03 14:34:33 -07:00
config.ts fix(dev-infra): correct FormatConfig interface (#42154) 2021-05-18 15:40:23 -07:00
format.ts fix(dev-infra): format command incorrectly prints outdated files (#42252) 2021-05-25 17:57:01 +00:00
run-commands-parallel.ts fix(dev-infra): formatting errors not reported with failure message (#42202) 2021-05-21 18:06:47 +00:00