fd3cfbb678
Creates a Bazel macro that can be used to test packages for circular dependencies. We face one limitation with Bazel: * Built packages use module imports, and not relative source file paths. This means we need custom resolution. Fortunately, tools like `madge` support custom resolution. Also removes the outdated `check-cycles` gulp task that didn't catch circular dependencies. It seems like the test became broken when we switched the packages-dist output to Bazel. It breaks because the Bazel output doesn't use relative paths, but uses the module imports. This will be handled in the new Bazel macro/rule. PR Close #34774 |
||
---|---|---|
.. | ||
cldr | ||
README.md | ||
changelog-zonejs.js | ||
changelog.js | ||
cldr.js | ||
format.js | ||
lint.js | ||
platform-script-path.js | ||
source-map-test.js | ||
tools-build.js | ||
validate-commit-message.js |
README.md
Gulp Tasks folder
This folder contains one file for each task (or group of related tasks) for the project's gulpfile. The dependencies between the tasks is kept in the gulpfile.
Task File Structure
Each task is defined by a factory function that accepts gulp
as a parameter.
Each file exports either one factory or an object of factories.
E.g. The build.js
file contains only one task:
module.exports = (gulp) => (done) => {
...
};
E.g. The format.js
file contains two tasks:
module.exports = {
// Check source code for formatting errors (clang-format)
enforce: (gulp) => () => {
...
},
// Format the source code with clang-format (see .clang-format)
format: (gulp) => () => {
...
}
};
Loading Tasks
The tasks are loaded in the gulp file, by requiring them. There is a helper called loadTask(fileName, taskName)
will do this for us, where the taskName
is optional if the file only exports one task.
E.g. Loading the task that will run the build, from a task file that contains only one task.
gulp.task('build.sh', loadTask('build'));
E.g. Loading the task that will enforce formatting, from a task file that contains more than one task:
gulp.task('format:enforce', loadTask('format', 'enforce'));
E.g. Loading a task that has dependencies:
gulp.task('lint', ['format:enforce', 'tools:build'], loadTask('lint'));