0c105c38da
Previously, the `NotificationComponent` would be hidden by reducing its height to `0`. This allowed for a smoother hide animation when closing the notification, but left the component's interactive elements focusable via keyboard navigation. This was confusing for users, because the focused elements would not be visible on the page. This commit fixes the issue be also setting the `display` CSS property to `none` when the `NotificationComponent` is hidden, thus ensuring that its contents are not focusable via keyboard navigation. (This does not affect the hide animation, since the `display` style is not animatable and is only applied at the end of the animation.) PR Close #42584
public-api/
This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of the our bazel tests.
To check or update the public api goldens, run one of the following commands:
yarn public-api:check
yarn public-api:update
packages-circular-deps.json
This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.
To check or update the golden, run the following commands:
yarn ts-circular-deps:check
yarn ts-circular-deps:approve