Go to file
George Kalpakas 9498da1038 fix(service-worker): correctly determine client ID on navigation requests (#42607)
The ServiceWorker assigns an app-version to a each client to ensure that
all subsequent requests for a client are served using the same
app-version. The assignment is done based on the client ID.

Previously, the ServiceWorker would only try to read the client's ID off
of the `FetchEvent`'s `clientId` property. However, for navigation
requests the new client's ID will be set on [resultingClientId][1],
while `clientId` will either be empty or hold the ID of the client where
the request initiated from. See also related discussions in
w3c/ServiceWorker#870 and w3c/ServiceWorker#1266.

In theory, this could lead to the navigation request (i.e. `index.html`)
being served from a different app-version than the subsequent
sub-resource requests (i.e. assets). In practice, the likelihood of this
happening is probably very low though, since it would require the latest
app-version to be updated between the initial navigation request and the
first sub-resource request, which should happen very shortly after the
navigation request.

This commit ensures that the correct client ID is determined even for
navigation requests by also taking the `resultingClientId` property into
account.

[1]: https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/resultingClientId

PR Close #42607
2021-06-22 16:28:24 +00:00
.circleci Revert "build: build locale files for legacy saucelabs job (#42230)" (#42583) 2021-06-16 09:49:37 -07:00
.devcontainer build: upgrade to node 14 (#41544) 2021-04-14 09:40:17 -07:00
.github ci: update the sha of the feature request process bot (#42469) 2021-06-03 10:43:47 -07:00
.husky build: suppress errors in git hooks (#42484) 2021-06-04 13:34:01 -07:00
.ng-dev Revert "build: wire up new CLDR generation tool within Bazel (#42230)" (#42583) 2021-06-16 09:49:37 -07:00
.vscode build: use "outFiles" in .vscode/launch.json to speed up debugging sessions (#39848) 2020-12-17 11:23:13 -08:00
.yarn build: update to yarn v1.22.10 (#40562) 2021-01-26 10:52:27 -08:00
aio docs: improve styles of the roadmap done section (#42616) 2021-06-22 16:26:47 +00:00
dev-infra feat(dev-infra): update pullapprove verification to ensure all groups have reviewers (#42614) 2021-06-22 16:27:36 +00:00
docs ci: do not update shared dev-infra package in components-repo-unit-tests job (#42268) 2021-06-03 10:37:41 -07:00
goldens refactor(compiler-cli): support xi18n in ngtsc (#42485) 2021-06-21 16:50:28 +00:00
integration build: update all non-major dependencies (#42544) 2021-06-17 18:09:31 +00:00
modules fix(dev-infra): update build tooling for latest changes in rules_nodejs (#40710) 2021-02-09 10:48:43 -08:00
packages fix(service-worker): correctly determine client ID on navigation requests (#42607) 2021-06-22 16:28:24 +00:00
scripts ci: do not update shared dev-infra package in components-repo-unit-tests job (#42268) 2021-06-03 10:37:41 -07:00
third_party test(core): fix `Function#name` shim used in IE11 (#41439) 2021-04-05 08:56:17 -07:00
tools build: update to typescript 4.3.4 (#42600) 2021-06-21 16:42:49 +00:00
.bazelignore test: delete integration test for language service plugin (#41740) 2021-04-23 11:00:40 -07:00
.bazelrc build: use platform from shared dev-infra package for remote execution (#41767) 2021-04-23 11:01:40 -07:00
.bazelversion build: update .bazelversion (#40579) 2021-01-26 11:35:54 -08:00
.clang-format feat(tooling): Add a .clang-format for automated JavaScript formatting. 2015-04-02 08:44:34 -07:00
.editorconfig build: use https link to editorconfig.org in .editorconfig (#27664) 2018-12-18 09:30:09 -08:00
.gitattributes test: fix ts api guardian and public guard tests on windows (#30105) 2019-04-26 16:32:22 -07:00
.gitignore Revert "build: convert CLDR locale extraction from Gulp to Bazel tool (#42230)" (#42583) 2021-06-16 09:49:37 -07:00
.gitmessage fix(platform-webworker): remove platform-webworker and platform-webworker-dynamic (#38846) 2020-09-30 09:13:59 -04:00
.mailmap build: add a Git .mailmap with my new name (#19550) 2017-10-09 14:35:30 -07:00
.npmrc build: rely on engines to prevent using npm for dependency install (#41477) 2021-04-07 12:05:01 -07:00
.nvmrc build: upgrade to node 14 (#41544) 2021-04-14 09:40:17 -07:00
.prettierrc ci: use prettier to format yml files (#42136) 2021-05-19 11:20:20 -07:00
.pullapprove.yml ci: update pullapprove config (#42613) 2021-06-21 17:36:56 +00:00
.yarnrc build: update to yarn v1.22.10 (#40562) 2021-01-26 10:52:27 -08:00
BUILD.bazel build: remove `core-js` in favor of `core-js-bundle` (#41739) 2021-04-26 09:29:58 -07:00
CHANGELOG.md release: cut the v12.1.0-next.6 release (#42587) 2021-06-16 16:45:23 -07:00
CODE_OF_CONDUCT.md docs: add Discord as an official communication channel (#39149) 2020-10-14 10:23:15 -07:00
CONTRIBUTING.md docs: add link to fork repo how-to (#41266) 2021-03-23 11:22:31 -07:00
LICENSE docs: update the copyright notice date (#40707) 2021-02-16 10:04:23 -08:00
README.md docs: update tagline (#41922) 2021-05-03 10:04:05 -07:00
WORKSPACE build: update all non-major dependencies (#42544) 2021-06-17 18:09:31 +00:00
browser-providers.conf.js ci: remove IE 9 and IE 10 from CI (#38931) 2020-09-25 14:31:10 -04:00
gulpfile.js Revert "build: convert CLDR locale extraction from Gulp to Bazel tool (#42230)" (#42583) 2021-06-16 09:49:37 -07:00
karma-js.conf.js build: remove unnecessary polyfills from tests (#42567) 2021-06-14 14:14:41 -07:00
package.json build: update to typescript 4.3.4 (#42600) 2021-06-21 16:42:49 +00:00
renovate.json build(docs-infra): revert `watchr` to v3.0.1 to restore `docs-watch` performance (#41903) 2021-05-03 10:05:31 -07:00
test-events.js build: update license headers to reference Google LLC (#37205) 2020-05-26 14:26:58 -04:00
test-main.js build: remove unnecessary polyfills from tests (#42567) 2021-06-14 14:14:41 -07:00
tslint.json ci: add lint error for files with missing trailing new-line (#42478) 2021-06-04 13:31:03 -07:00
yarn.lock build: update to typescript 4.3.4 (#42600) 2021-06-21 16:42:49 +00:00
yarn.lock.readme.md build: remove travisci leftovers (#27979) 2019-01-09 10:41:16 -08:00

README.md

Angular - The modern web developer's platform.

angular-logo
Angular is a development platform for building mobile and desktop web applications
using Typescript/JavaScript and other languages.

www.angular.io

Contributing Guidelines · Submit an Issue · Blog

CI status   Angular on npm   Discord conversation


Documentation

Get started with Angular, learn the fundamentals and explore advanced topics on our documentation website.

Advanced

Development Setup

Prerequisites

Setting Up a Project

Install the Angular CLI globally:

npm install -g @angular/cli

Create workspace:

ng new [PROJECT NAME]

Run the application:

cd [PROJECT NAME]
ng serve

Angular is cross-platform, fast, scalable, has incredible tooling, and is loved by millions.

Quickstart

Get started in 5 minutes.

Ecosystem

angular ecosystem logos

Changelog

Learn about the latest improvements.

Upgrading

Check out our upgrade guide to find out the best way to upgrade your project.

Contributing

Contributing Guidelines

Read through our contributing guidelines to learn about our submission process, coding rules and more.

Want to Help?

Want to file a bug, contribute some code, or improve documentation? Excellent! Read up on our guidelines for contributing and then check out one of our issues labeled as help wanted or good first issue.

Code of Conduct

Help us keep Angular open and inclusive. Please read and follow our Code of Conduct.

Community

Join the conversation and help the community.

Love Angular badge

Love Angular? Give our repo a star ⬆️.