98001a065d
This is a basic implementation of error logging using the limited facilities provided by Google Analytics. Errors within the Angular app itself will be handled by a new `ReportingErrorHandler` service, which overrides and extends the built-in `ErrorHandler`. Further, errors outside the app, which arrive at `window.onerror` will also be reported to Google Analytics. Closes #21943 PR Close #22011
65 lines
2.3 KiB
TypeScript
65 lines
2.3 KiB
TypeScript
import { ErrorHandler, ReflectiveInjector } from '@angular/core';
|
|
import { TestBed } from '@angular/core/testing';
|
|
import { WindowToken } from 'app/shared/window';
|
|
import { AppModule } from 'app/app.module';
|
|
|
|
import { ReportingErrorHandler } from './reporting-error-handler';
|
|
|
|
describe('ReportingErrorHandler service', () => {
|
|
let handler: ReportingErrorHandler;
|
|
let superHandler: jasmine.Spy;
|
|
let onerrorSpy: jasmine.Spy;
|
|
|
|
beforeEach(() => {
|
|
onerrorSpy = jasmine.createSpy('onerror');
|
|
superHandler = spyOn(ErrorHandler.prototype, 'handleError');
|
|
|
|
const injector = ReflectiveInjector.resolveAndCreate([
|
|
{ provide: ErrorHandler, useClass: ReportingErrorHandler },
|
|
{ provide: WindowToken, useFactory: () => ({ onerror: onerrorSpy }) }
|
|
]);
|
|
handler = injector.get(ErrorHandler);
|
|
});
|
|
|
|
it('should be registered on the AppModule', () => {
|
|
handler = TestBed.configureTestingModule({ imports: [AppModule] }).get(ErrorHandler);
|
|
expect(handler).toEqual(jasmine.any(ReportingErrorHandler));
|
|
});
|
|
|
|
describe('handleError', () => {
|
|
it('should call the super class handleError', () => {
|
|
const error = new Error();
|
|
handler.handleError(error);
|
|
expect(superHandler).toHaveBeenCalledWith(error);
|
|
});
|
|
|
|
it('should cope with the super handler throwing an error', () => {
|
|
const error = new Error('initial error');
|
|
superHandler.and.throwError('super handler error');
|
|
handler.handleError(error);
|
|
|
|
expect(onerrorSpy).toHaveBeenCalledTimes(2);
|
|
|
|
// Error from super handler is reported first
|
|
expect(onerrorSpy.calls.argsFor(0)[0]).toEqual('super handler error');
|
|
expect(onerrorSpy.calls.argsFor(0)[4]).toEqual(jasmine.any(Error));
|
|
|
|
// Then error from initial exception
|
|
expect(onerrorSpy.calls.argsFor(1)[0]).toEqual('initial error');
|
|
expect(onerrorSpy.calls.argsFor(1)[4]).toEqual(error);
|
|
});
|
|
|
|
it('should send an error object to window.onerror', () => {
|
|
const error = new Error('this is an error message');
|
|
handler.handleError(error);
|
|
expect(onerrorSpy).toHaveBeenCalledWith(error.message, undefined, undefined, undefined, error);
|
|
});
|
|
|
|
it('should send an error string to window.onerror', () => {
|
|
const error = 'this is an error message';
|
|
handler.handleError(error);
|
|
expect(onerrorSpy).toHaveBeenCalledWith(error);
|
|
});
|
|
});
|
|
});
|