9b93bd625f
Previous to this change, we assumed embedded views could only be created after their parent template node had completed processing. As a result, we only set up query logic for containers after directives on the node were created. However, this assumption didn't take into account the case where a directive on a template node could create views in its constructor. This commit fixes query logic to work with views created in constructors. In that case, we need to create a query container before the new view is rendered so query results in the view aren't lost. But since the query container is created before directives have completed processing, we also have to ensure that query results gathered later on the template node are inserted before that query container. Otherwise, query results in embedded views will clobber query results on template nodes. This splice mode may be slightly slower than the normal matching for queries on containers, but we should only fall back to this strategy in the edge case where views are created in constructors. (We should encourage developers to create views in ngOnInit instead). PR Close #29983 |
||
|---|---|---|
| .. | ||
| animations | ||
| bazel | ||
| benchpress | ||
| common | ||
| compiler | ||
| compiler-cli | ||
| core | ||
| docs | ||
| elements | ||
| examples | ||
| forms | ||
| http | ||
| language-service | ||
| platform-browser | ||
| platform-browser-dynamic | ||
| platform-server | ||
| platform-webworker | ||
| platform-webworker-dynamic | ||
| private/testing | ||
| router | ||
| service-worker | ||
| upgrade | ||
| BUILD.bazel | ||
| README.md | ||
| empty.ts | ||
| goog.d.ts | ||
| license-banner.txt | ||
| system.d.ts | ||
| tsconfig-build.json | ||
| tsconfig-test.json | ||
| tsconfig.json | ||
| types.d.ts | ||
README.md
Angular
The sources for this package are in the main Angular repo. Please file issues and pull requests against that repo.
License: MIT