When a pipe inherits its constructor, and as a result its factory, from an injectable in AOT mode, it can end up throwing an error, because the inject implementation hasn't been set yet. These changes ensure that the implementation is set before the pipe's factory is invoked. Note that this isn't a problem in JIT mode, because the factory inheritance works slightly differently, hence why this test isn't going through `TestBed`. Fixes #35277. PR Close #35468
106 lines
4.0 KiB
TypeScript
106 lines
4.0 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {Injectable as _Injectable, Pipe as _Pipe, PipeTransform, WrappedValue, ɵɵdefineInjectable, ɵɵdefinePipe, ɵɵgetInheritedFactory, ɵɵinject} from '@angular/core';
|
|
import {expect} from '@angular/platform-browser/testing/src/matchers';
|
|
|
|
import {ɵɵtext, ɵɵtextInterpolate1} from '../../src/render3/instructions/all';
|
|
import {ɵɵpipe, ɵɵpipeBind1} from '../../src/render3/pipe';
|
|
|
|
import {TemplateFixture} from './render_util';
|
|
|
|
const Pipe: typeof _Pipe = function(...args: any[]): any {
|
|
// In test we use @Pipe for documentation only so it's safe to mock out the implementation.
|
|
return () => undefined;
|
|
} as any;
|
|
|
|
const Injectable: typeof _Injectable = function(...args: any[]): any {
|
|
// In test we use @Injectable for documentation only so it's safe to mock out the implementation.
|
|
return () => undefined;
|
|
} as any;
|
|
|
|
|
|
describe('pipe', () => {
|
|
// TODO: hasn't been moved over into acceptance, because the `WrappedValue` tests need to
|
|
// use an impure pipe which always throws "changed after checked errors" with `TestBed`
|
|
// both in Ivy and ViewEngine.
|
|
describe('WrappedValue', () => {
|
|
@Pipe({name: 'wrappingPipe'})
|
|
class WrappingPipe implements PipeTransform {
|
|
transform(value: any) { return new WrappedValue('Bar'); }
|
|
|
|
static ɵfac = function WrappingPipe_Factory() { return new WrappingPipe(); };
|
|
static ɵpipe = ɵɵdefinePipe({name: 'wrappingPipe', type: WrappingPipe, pure: false});
|
|
}
|
|
|
|
function createTemplate() {
|
|
ɵɵtext(0);
|
|
ɵɵpipe(1, 'wrappingPipe');
|
|
}
|
|
|
|
function updateTemplate() { ɵɵtextInterpolate1('', ɵɵpipeBind1(1, 1, null), ''); }
|
|
|
|
it('should unwrap', () => {
|
|
const fixture =
|
|
new TemplateFixture(createTemplate, updateTemplate, 2, 3, undefined, [WrappingPipe]);
|
|
expect(fixture.html).toEqual('Bar');
|
|
});
|
|
|
|
it('should force change detection', () => {
|
|
const fixture =
|
|
new TemplateFixture(createTemplate, updateTemplate, 2, 3, undefined, [WrappingPipe]);
|
|
expect(fixture.html).toEqual('Bar');
|
|
|
|
fixture.hostElement.childNodes[0] !.textContent = 'Foo';
|
|
expect(fixture.html).toEqual('Foo');
|
|
|
|
fixture.update();
|
|
expect(fixture.html).toEqual('Bar');
|
|
});
|
|
});
|
|
|
|
// This test isn't in `acceptance`, because we can't capture the same behavior that we want
|
|
// when going through `TestBed`. Here we're testing the behavior of AOT-compiled code which
|
|
// differs from the JIT code in `TestBed`, because it includes a `ɵɵgetInheritedFactory` call
|
|
// when the pipe is using inheritance.
|
|
it('should be able to use DI in a Pipe that extends an Injectable', () => {
|
|
@Injectable({providedIn: 'root'})
|
|
class SayHelloService {
|
|
getHello() { return 'Hello there'; }
|
|
static ɵfac = () => new SayHelloService();
|
|
static ɵprov = ɵɵdefineInjectable(
|
|
{token: SayHelloService, factory: SayHelloService.ɵfac, providedIn: 'root'});
|
|
}
|
|
|
|
@Injectable()
|
|
class ParentPipe {
|
|
constructor(protected sayHelloService: SayHelloService) {}
|
|
static ɵfac = (t?: any) => new (t || ParentPipe)(ɵɵinject(SayHelloService));
|
|
static ɵprov = ɵɵdefineInjectable({token: ParentPipe, factory: ParentPipe.ɵfac});
|
|
}
|
|
|
|
@Pipe({name: 'sayHello', pure: true})
|
|
class SayHelloPipe extends ParentPipe implements PipeTransform {
|
|
transform() { return this.sayHelloService.getHello(); }
|
|
static ɵfac = (t?: any) => ɵɵgetInheritedFactory(t || SayHelloPipe)(SayHelloPipe);
|
|
static ɵpipe = ɵɵdefinePipe({name: 'sayHello', type: SayHelloPipe, pure: true});
|
|
}
|
|
|
|
const fixture = new TemplateFixture(
|
|
() => {
|
|
ɵɵtext(0);
|
|
ɵɵpipe(1, 'sayHello');
|
|
},
|
|
() => { ɵɵtextInterpolate1('', ɵɵpipeBind1(1, 1, null), ''); }, 2, 3, undefined,
|
|
[SayHelloPipe]);
|
|
|
|
expect(fixture.html).toBe('Hello there');
|
|
});
|
|
|
|
});
|