b5ab7aff43
In combination with the TS `noImplicitOverride` compatibility changes, we also want to follow the best-practice of adding `override` to members which are implemented as part of abstract classes. This commit fixes all instances which will be flagged as part of the custom `no-implicit-override-abstract` TSLint rule. PR Close #42512
56 lines
1.5 KiB
TypeScript
56 lines
1.5 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {join} from 'path';
|
|
import {exec} from 'shelljs';
|
|
|
|
import {error} from '../../utils/console';
|
|
|
|
import {Formatter} from './base-formatter';
|
|
|
|
/**
|
|
* Formatter for running prettier against Typescript and Javascript files.
|
|
*/
|
|
export class Prettier extends Formatter {
|
|
override name = 'prettier';
|
|
|
|
override binaryFilePath = join(this.git.baseDir, 'node_modules/.bin/prettier');
|
|
|
|
override defaultFileMatcher = ['**/*.{t,j}s'];
|
|
|
|
/**
|
|
* The configuration path of the prettier config, obtained during construction to prevent needing
|
|
* to discover it repeatedly for each execution.
|
|
*/
|
|
private configPath =
|
|
this.config['prettier'] ? exec(`${this.binaryFilePath} --find-config-path .`).trim() : '';
|
|
|
|
override actions = {
|
|
check: {
|
|
commandFlags: `--config ${this.configPath} --check`,
|
|
callback:
|
|
(_: string, code: number, stdout: string) => {
|
|
return code !== 0;
|
|
},
|
|
},
|
|
format: {
|
|
commandFlags: `--config ${this.configPath} --write`,
|
|
callback:
|
|
(file: string, code: number, _: string, stderr: string) => {
|
|
if (code !== 0) {
|
|
error(`Error running prettier on: ${file}`);
|
|
error(stderr);
|
|
error();
|
|
return true;
|
|
}
|
|
return false;
|
|
},
|
|
},
|
|
};
|
|
}
|