d28a391385
When we deactivate a child route, we deactivate its outlet as well as its children. We also need to clear the stored information about the route and the associated component. If we do not, the context will keep these references and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes #41379 PR Close #41381
244 lines
8.2 KiB
TypeScript
244 lines
8.2 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import {CommonModule} from '@angular/common';
|
|
import {ChangeDetectionStrategy, ChangeDetectorRef, Component, NgModule, TemplateRef, Type, ViewChild, ViewContainerRef} from '@angular/core';
|
|
import {ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
|
|
import {Router} from '@angular/router';
|
|
import {RouterTestingModule} from '@angular/router/testing';
|
|
|
|
describe('Integration', () => {
|
|
describe('routerLinkActive', () => {
|
|
it('should update when the associated routerLinks change - #18469', fakeAsync(() => {
|
|
@Component({
|
|
template: `
|
|
<a id="first-link" [routerLink]="[firstLink]" routerLinkActive="active">{{firstLink}}</a>
|
|
<div id="second-link" routerLinkActive="active">
|
|
<a [routerLink]="[secondLink]">{{secondLink}}</a>
|
|
</div>
|
|
`,
|
|
})
|
|
class LinkComponent {
|
|
firstLink = 'link-a';
|
|
secondLink = 'link-b';
|
|
|
|
changeLinks(): void {
|
|
const temp = this.secondLink;
|
|
this.secondLink = this.firstLink;
|
|
this.firstLink = temp;
|
|
}
|
|
}
|
|
|
|
@Component({template: 'simple'})
|
|
class SimpleCmp {
|
|
}
|
|
|
|
TestBed.configureTestingModule({
|
|
imports: [RouterTestingModule.withRoutes(
|
|
[{path: 'link-a', component: SimpleCmp}, {path: 'link-b', component: SimpleCmp}])],
|
|
declarations: [LinkComponent, SimpleCmp]
|
|
});
|
|
|
|
const router: Router = TestBed.inject(Router);
|
|
const fixture = createRoot(router, LinkComponent);
|
|
const firstLink = fixture.debugElement.query(p => p.nativeElement.id === 'first-link');
|
|
const secondLink = fixture.debugElement.query(p => p.nativeElement.id === 'second-link');
|
|
router.navigateByUrl('/link-a');
|
|
advance(fixture);
|
|
|
|
expect(firstLink.nativeElement.classList).toContain('active');
|
|
expect(secondLink.nativeElement.classList).not.toContain('active');
|
|
|
|
fixture.componentInstance.changeLinks();
|
|
fixture.detectChanges();
|
|
advance(fixture);
|
|
|
|
expect(firstLink.nativeElement.classList).not.toContain('active');
|
|
expect(secondLink.nativeElement.classList).toContain('active');
|
|
}));
|
|
|
|
it('should not cause infinite loops in the change detection - #15825', fakeAsync(() => {
|
|
@Component({selector: 'simple', template: 'simple'})
|
|
class SimpleCmp {
|
|
}
|
|
|
|
@Component({
|
|
selector: 'some-root',
|
|
template: `
|
|
<div *ngIf="show">
|
|
<ng-container *ngTemplateOutlet="tpl"></ng-container>
|
|
</div>
|
|
<router-outlet></router-outlet>
|
|
<ng-template #tpl>
|
|
<a routerLink="/simple" routerLinkActive="active"></a>
|
|
</ng-template>`
|
|
})
|
|
class MyCmp {
|
|
show: boolean = false;
|
|
}
|
|
|
|
@NgModule({
|
|
imports: [CommonModule, RouterTestingModule],
|
|
declarations: [MyCmp, SimpleCmp],
|
|
entryComponents: [SimpleCmp],
|
|
})
|
|
class MyModule {
|
|
}
|
|
|
|
TestBed.configureTestingModule({imports: [MyModule]});
|
|
|
|
const router: Router = TestBed.inject(Router);
|
|
const fixture = createRoot(router, MyCmp);
|
|
router.resetConfig([{path: 'simple', component: SimpleCmp}]);
|
|
|
|
router.navigateByUrl('/simple');
|
|
advance(fixture);
|
|
|
|
const instance = fixture.componentInstance;
|
|
instance.show = true;
|
|
expect(() => advance(fixture)).not.toThrow();
|
|
}));
|
|
|
|
it('should set isActive right after looking at its children -- #18983', fakeAsync(() => {
|
|
@Component({
|
|
template: `
|
|
<div #rla="routerLinkActive" routerLinkActive>
|
|
isActive: {{rla.isActive}}
|
|
|
|
<ng-template let-data>
|
|
<a [routerLink]="data">link</a>
|
|
</ng-template>
|
|
|
|
<ng-container #container></ng-container>
|
|
</div>
|
|
`
|
|
})
|
|
class ComponentWithRouterLink {
|
|
// TODO(issue/24571): remove '!'.
|
|
@ViewChild(TemplateRef, {static: true}) templateRef!: TemplateRef<any>;
|
|
// TODO(issue/24571): remove '!'.
|
|
@ViewChild('container', {read: ViewContainerRef, static: true})
|
|
container!: ViewContainerRef;
|
|
|
|
addLink() {
|
|
this.container.createEmbeddedView(this.templateRef, {$implicit: '/simple'});
|
|
}
|
|
|
|
removeLink() {
|
|
this.container.clear();
|
|
}
|
|
}
|
|
|
|
@Component({template: 'simple'})
|
|
class SimpleCmp {
|
|
}
|
|
|
|
TestBed.configureTestingModule({
|
|
imports: [RouterTestingModule.withRoutes([{path: 'simple', component: SimpleCmp}])],
|
|
declarations: [ComponentWithRouterLink, SimpleCmp]
|
|
});
|
|
|
|
const router: Router = TestBed.inject(Router);
|
|
const fixture = createRoot(router, ComponentWithRouterLink);
|
|
router.navigateByUrl('/simple');
|
|
advance(fixture);
|
|
|
|
fixture.componentInstance.addLink();
|
|
fixture.detectChanges();
|
|
|
|
fixture.componentInstance.removeLink();
|
|
advance(fixture);
|
|
advance(fixture);
|
|
|
|
expect(fixture.nativeElement.innerHTML).toContain('isActive: false');
|
|
}));
|
|
|
|
it('should set isActive with OnPush change detection - #19934', fakeAsync(() => {
|
|
@Component({
|
|
template: `
|
|
<div routerLink="/simple" #rla="routerLinkActive" routerLinkActive>
|
|
isActive: {{rla.isActive}}
|
|
</div>
|
|
`,
|
|
changeDetection: ChangeDetectionStrategy.OnPush
|
|
})
|
|
class OnPushComponent {
|
|
}
|
|
|
|
@Component({template: 'simple'})
|
|
class SimpleCmp {
|
|
}
|
|
|
|
TestBed.configureTestingModule({
|
|
imports: [RouterTestingModule.withRoutes([{path: 'simple', component: SimpleCmp}])],
|
|
declarations: [OnPushComponent, SimpleCmp]
|
|
});
|
|
|
|
const router: Router = TestBed.get(Router);
|
|
const fixture = createRoot(router, OnPushComponent);
|
|
router.navigateByUrl('/simple');
|
|
advance(fixture);
|
|
|
|
expect(fixture.nativeElement.innerHTML).toContain('isActive: true');
|
|
}));
|
|
});
|
|
|
|
it('should not reactivate a deactivated outlet when destroyed and recreated - #41379',
|
|
fakeAsync(() => {
|
|
@Component({template: 'simple'})
|
|
class SimpleComponent {
|
|
}
|
|
|
|
@Component({template: ` <router-outlet *ngIf="outletVisible" name="aux"></router-outlet> `})
|
|
class AppComponent {
|
|
outletVisible = true;
|
|
}
|
|
|
|
TestBed.configureTestingModule({
|
|
imports: [RouterTestingModule.withRoutes(
|
|
[{path: ':id', component: SimpleComponent, outlet: 'aux'}])],
|
|
declarations: [SimpleComponent, AppComponent],
|
|
});
|
|
|
|
const router = TestBed.inject(Router);
|
|
const fixture = createRoot(router, AppComponent);
|
|
const componentCdr = fixture.componentRef.injector.get<ChangeDetectorRef>(ChangeDetectorRef);
|
|
|
|
router.navigate([{outlets: {aux: ['1234']}}]);
|
|
advance(fixture);
|
|
expect(fixture.nativeElement.innerHTML).toContain('simple');
|
|
|
|
router.navigate([{outlets: {aux: null}}]);
|
|
advance(fixture);
|
|
expect(fixture.nativeElement.innerHTML).not.toContain('simple');
|
|
|
|
fixture.componentInstance.outletVisible = false;
|
|
componentCdr.detectChanges();
|
|
expect(fixture.nativeElement.innerHTML).not.toContain('simple');
|
|
expect(fixture.nativeElement.innerHTML).not.toContain('router-outlet');
|
|
|
|
fixture.componentInstance.outletVisible = true;
|
|
componentCdr.detectChanges();
|
|
expect(fixture.nativeElement.innerHTML).toContain('router-outlet');
|
|
expect(fixture.nativeElement.innerHTML).not.toContain('simple');
|
|
}));
|
|
});
|
|
|
|
function advance<T>(fixture: ComponentFixture<T>): void {
|
|
tick();
|
|
fixture.detectChanges();
|
|
}
|
|
|
|
function createRoot<T>(router: Router, type: Type<T>): ComponentFixture<T> {
|
|
const f = TestBed.createComponent(type);
|
|
advance(f);
|
|
router.initialNavigation();
|
|
advance(f);
|
|
return f;
|
|
}
|