008eaf3b7d
Close #41522 `zone.js` patches event listeners and run all event listeners together, if one event handler throws error, the listeners afterward may not be invoked. Reproduction: ``` export class AppComponent implements AfterViewInit { @ViewChild('btn') btn: ElementRef; title = 'event-error'; constructor(private ngZone: NgZone) {} ngAfterViewInit() { this.ngZone.runOutsideAngular(() => { this.btn.nativeElement.addEventListener('click', () => { throw new Error('test1'); }); this.btn.nativeElement.addEventListener('click', () => { console.log('add eventlistener click'); }); }); } } ``` Until now no Angular users report this issue becuase in the `ngZone`, all error will be caught and will not rethrow, so the event listeners afterward will still continue to execute, but if the event handlers are outside of `ngZone`, the error will break the execution. This commit catch all errors, and after all event listeners finished invocation, rethrow the errors in seperate `microTasks`, the reason I am using `microTask` here is to handle multiple errors case. PR Close #41562
27 lines
1.1 KiB
TypeScript
27 lines
1.1 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
Zone.__load_patch('shadydom', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
|
|
// https://github.com/angular/zone.js/issues/782
|
|
// in web components, shadydom will patch addEventListener/removeEventListener of
|
|
// Node.prototype and WindowPrototype, this will have conflict with zone.js
|
|
// so zone.js need to patch them again.
|
|
const HTMLSlotElement = global.HTMLSlotElement;
|
|
const prototypes = [
|
|
Object.getPrototypeOf(window), Node.prototype, Text.prototype, Element.prototype,
|
|
HTMLElement.prototype, HTMLSlotElement && HTMLSlotElement.prototype, DocumentFragment.prototype,
|
|
Document.prototype
|
|
];
|
|
prototypes.forEach(function(proto) {
|
|
if (proto && proto.hasOwnProperty('addEventListener')) {
|
|
proto[Zone.__symbol__('addEventListener')] = null;
|
|
proto[Zone.__symbol__('removeEventListener')] = null;
|
|
api.patchEventTarget(global, api, [proto]);
|
|
}
|
|
});
|
|
});
|